Bovine M2TW Checker

[Gigantus]

Sorry to hear, hope it clears up soon. Thanks for popping in and letting us know.

[diealot]

Bovine Tool Fail to run with the Mod Insularis Draco. It generated 9 files 4 of which is totally empty. These files are: filerefference.error.log, sounds.error.logs, edct.error.log,eda.error.log.
What did I do wrong?

[Belovèse]

Do you have the right java version, and can you also post your checkers config file (not the mod!)?

[diealot]

Yes I have java 1.8.
Here is my config file:
==================================================================
;Set DATAFOLDER to the data folder for your mod, such as C:/Games/M2TW/mods/my_mod_name/data
;C:/Games/M2TW needs to be changed to wherever your M2TW is installed to.
;my_mod_name needs to be changed to whatever your mod folder is called.
DATAFOLDER=E:\Game\Medieval II Total War\mods\InsularisDraco\data


;Set STRAT to the folder containing your campaign script, descr_strat, descr_events and the like.
;Probably this is the default imperial_campaign and you should leave it alone!
STRAT=world/maps/campaign/imperial_campaign


;When encountering a file (animation, sound, model etc) where it cannot see
;any usage, it gets reported as unused. You will probably want to actually
;reference it, but possibly you instead wish to remove it to reduce mod size.
;Provide commands for what to do with these below.
;Suggested variants below, not all of them will be relevant for you.
;Use this with caution, and ONLY after checking for possible typos in
;references and files that you really want to use in the mod after all!
;You can define more than one - this will cause each of them to be executed,
;in sequence. If you want to move to a backup folder, ensure that works
;properly before enabling the deletion command!
;REMOVE_UNUSED_FILES=COPY_TO unused_backup
;REMOVE_UNUSED_FILES=CONSOLE_COMMAND svn delete %DATAFOLDER%/%FILENAME%
;REMOVE_UNUSED_FILES=CONSOLE_COMMAND git rm %DATAFOLDER%/%FILENAME%
;REMOVE_UNUSED_FILES=CONSOLE_COMMAND del %DATAFOLDER%/%FILENAME%


;The checker can be configured to require vanilla animations to be present in
;the mod's own animations folder. As this is the case for EB2, this is the
;default setting even if most mods can rely on vanilla animation files being
;available to the mod. Chances are that you want to uncomment the setting
;below for any other mod than EB2.
;VANILLA_ANIMATIONS_REQUIRED=NO


;The checker expects all hidden traits to use descriptions "hidden_desc" and
;"hidden_effects_desc". Any hidden traits with specific descriptions are
;considered to be intended to be shown to the player and assigned as hidden by
;mistake. If your mod wishes to keep trait specific text even for hidden
;traits, uncomment this line below to suppress those reports.
;HIDDEN_TRAIT_DESCRIPTIONS_SUPPRESSED=YES


;The checker tries to match all sound file names with the accent it is used for.
;Any file names not matching the defined accent prefixes will be reported. If
;you are not doing voice modding or otherwise don't want these reports, you can
;suppress them by uncommenting the line below.
;ACCENT_PREFIXES_SUPPRESSED=YES


;The checker tries to match all referenced sound files with the file system.
;If all your sound files are packed rather than available as individual files,
;you want to suppress reports about missing files by uncommenting the line below.
;SOUNDFILE_INTEGRITY_SUPPRESSED=YES


;Some agent types may not be in use in your mod, despite them being part of
;some of your files. In this case you are probably encountering a bunch of
;reported issues that are not really relevant for you. You can enter any number
;of these agents here and their file references should not be checked. If you
;still get some reports concerning them, I may have forgot to check the config
;in some instances. Let me know in the forum.
UNUSED_AGENT=merchant
UNUSED_AGENT=priest
UNUSED_AGENT=inquisitor
UNUSED_AGENT=witch
UNUSED_AGENT=heretic
=======================================================
I haven't change anything but the mod folder location. Should I change some other options?

[diealot]

Yes I have Java 1.8
Here is my configuration.txt file for Bovine Text Checker
I haven't change anything else beside my Mod Data Folder location

[Gigantus]

What I am getting from your error screenshot is this part in the checker files, red being the line in question:

            {
                var found = false
                for(factionNames :FactionCharacterNames in main.data.strat.names.values)
                {
                    found = factionNames.characterSurnames.contains(nameReference.reference)
                    if(found)
                        break
                }
                if(!found)
                    main.writeScriptLog("${nameReference.filename} ${nameReference.lineNumber}: Surname reference to ${nameReference.reference}, which is not defined for any faction.")
            }

If you look at the blue mark you will see what I think is a reference to character names. Possibly the use of special characters in one of the name files (data\descr_names or text\names inside the brackets). Else it could be a wrong format of the files themselves.
Providing the checker.output file in the bovine directory might help as well.

[diealot]

Here is the Checker.Output log hope you can identify the problem!

[Gigantus]

descr_character.txt
Unhandled parsing error on line 702, contents (possibly partial) are: "dictionary "

unit_models/battle_models.modeldb (parsing)
Unhandled parsing error on line 3216, contents (possibly partial) are: ""

Check what's happening in those two files at those lines. If you can't figure it upload those as well together with descr_names and text\names.txt. Best to simply zip them first.

[diealot]

Here are all 4 files you mentioned above. Thanks for your help. Can I ask how you check and fix these errors?(the program you use)

[Belovèse]

To open the files, a recommended program on twcenter is notepad++, personally I like Sublime Text.
To open the modeldb there is no need for a special program, just right-click it and choose the right program in the "open with..." option.

---

The problem in descr_character is that you lack a number for the dictionary entry, from the other entries I'm guessing it should be 2:

faction			milan
dictionary		
strat_model		roman_spy

---

For the modeldb error, maybe it is a false report the checker throws because of the previous descr_character error, or maybe it is something else but I'm less versed in it. From what I know though the problem might also come from your lines 3212 and 3213

4 
4 None

which are usually

1 
4 None

but you should take that info with caution

[Gigantus]

Agreed with the descr_character issue.

Can't see the one in modeldb either - the 4,4 numbers relate first to the count of animations, eg none, camel, horse, elephant, and then to the count of 'none'. But I am suspecting that it is the 2 at the end of 15 MTW2_Fast_Spear 2 in line 3214, try replacing that with a zero.

4 
4 None 
15 MTW2_Fast_Spear 2 
1 
18 MTW2_Spear_primary 
0 
5 horse 
18 MTW2_HR_Non_Shield 0  
1 
18 MTW2_Sword_Primary 
0 
8 elephant 
18 MTW2_Elephant_Crew 0  
1 
18 MTW2_Sword_Primary 
0 
5 camel 
18 MTW2_HR_Non_Shield 0  
1 
18 MTW2_Sword_Primary 
0 -1 0 0 0 0 0 0

There are empty lines in descr_names, see example, delete those:

        Victorinus_Eparchius
        Volusius_Saturninus
empty, delete
        Arcadius_Apollinaris
empty, delete
        Sangiban
empty, delete
        Ardabarus

    women
        Acerronia
        Aelia_Eudoxia

There are a lot of those empty lines, after that run the checker again, I couldn't see any use special characters. My guess is that the checker expects a faction or section entry (like 'women') after a blank line.

[diealot]

Thanks Belovese and Gigantus. While I am deleting those empty line in descr_names do you guys think I should also fill in the missing number for the dictionary entries in descr_character to match the ones around it.

Another question I have is: isn't the whole point of Bovine M2TW Checker Tool is to check for errors and generate these errors into log files why do these errors in these files make the tool fail to run correctly on a mod which I already know have load of errors and is the exact reason why I want to run the the Tool through the mod in the first place?

I guess the fact that the Tool fail to run correctly with the mod mean that the error it generated in these log will be incomplete am I right?

[Belovèse]

Yes you should first correct the descr_character, then run the checker and onky then see if there is still the modeldb error reported or if it was a false report due to the descr_character error.

About the checker: if the error in the mod is not anticipated by the checker, you can have various results, from no message about it at all to false positive. So when you're used to a checker it is a sign you messed up something the developer of the tool you use didn't though you'll mess, or didn't take into account

[Gigantus]

Making a checker fool proof is about at par with making a feasible financial script. Holy grail level stuff.

[diealot]

No luck guys. I have fixed all the things you guys told me to fix in descr_character.txt and descr_names.txt but the tool still fail to run correctly like last time.

[Belovèse]

You mean with the same errors messages? Can you post a link to your mod files, the exact version you're working on?

Sent from my FP2 using Tapatalk

[diealot]

Here is the link to the mod on ModDB:https://www.moddb.com/mods/insularis...ris-draco-beta
Here are the 2 files descr_character.txt and dscr_names.txt I edited to run the Bovine Tool Correctly. I did not touch the models.Modeldb
See if you get the same result..

[Belovèse]

From a first look there is quite a few errors pointed out by the standard M2TW log already, I would start by fixing those ones and then seeing if bovi's checker can take you further.
Especially errors in descr_strat, IIRC they can really throw the checker off-scent.
Hit me up if you need help or when it's done!

[diealot]

From a first look there is quite a few errors pointed out by the standard M2TW log already, I would start by fixing those ones and then seeing if bovi's checker can take you further.
Especially errors in descr_strat, IIRC they can really throw the checker off-scent.
Hit me up if you need help or when it's done!

What tool do you recommend I use to extract the errors in the descr_strat. I can't find a tool that only verify and return the descr_strat file errors into a log

[Belovèse]

I'll continue the discussion on your mod's discord so this thread remain centered on bovi's checker

EDIT: for future reference, after trying the mod my guess is that those errors come from encoding problems: mod was edited on osx using textedit at some point.

Sent from my FP2 using Tapatalk