List of non or mal functioning script terms (events, conditions and commands)

[Belovèse]

Hello guys, is there a known CTD with the faction_emerge command?

We use it on sship to simulate a civil war with cities emerging to slave faction. I'm on mobile right now, but can post more details in a few hours if needed.

EDIT: here is the script we use actually (inside a monitor_event PreFactionTurnStart FactionType slave):

if I_FactionLeaderTrait spain Usurper > 2
            and I_EventCounter civil_war_spain_going_on = 0
            and RandomPercent > 50

            set_event_counter civil_war_spain_going_on 1
            historic_event civil_war_spain
            increment_kings_purse spain -1000


            if I_NumberOfSettlements spain > 2
                faction_emerge slave spain 1 100.0 0.0 1.2 town true

                if I_NumberOfSettlements spain > 5
                    faction_emerge slave spain 1 100.0 0.0 1.2 town true

                    if I_NumberOfSettlements spain > 8
                        faction_emerge slave spain 1 100.0 0.0 1.2 town true unused_label1 unused_name 30

                        if I_NumberOfSettlements spain > 11
                            faction_emerge slave spain 1 100.0 0.0 1.2 town true unused_label1 unused_name 30

                            if I_NumberOfSettlements spain > 14
                                faction_emerge slave spain 1 100.0 0.0 1.2 town true unused_label1 unused_name 30
                            end_if
                        end_if
                    end_if
                end_if
            end_if

        end_if

I tried wait 0.1 before and after, still CTD at various points in the "if" chain.

[Withwnar]

The slave faction never dies, right? In which case you're emerging a faction that is already emerged (alive). That would be fair grounds for a CTD I'd say.

[Belovèse]

That's what I thought, but the script can also sometime work perfectly fine, and I also found this post in one of your threads. For now all the faction slots are use in SSHIP, so using the method you describe (emerge settlement to a hidden faction the give_all to a living faction (would require some sacrifice). I'll make more tries an report any findings.

[Jadli]

The slave faction never dies, right? In which case you're emerging a faction that is already emerged (alive). That would be fair grounds for a CTD I'd say.

Not true at all Im afraid. It might be problem with the usual emerging events, but this one is special.

Afaik there is no issue using faction_emerge for faction already in the game. (Especially if its a slave faction ). It just gives the faction a setttlement(s) in such case

I think Brittania DLC might be also doing it possibly (for BA), be it uintentionally or intentionally

When requirements for a condition are not met (too high popuarity in all settlements), it simply doesnt happen (in case you have hit "true" to scroll to show up, it will inform you that "rebellion failed") so that shouldnt be cause of CTD

Only thing that could possibly cause the CTD is posibly the unused_label and unused_name perhaps? Try removing them. The if chains dont exclude each other, hence spawning a character leader with the same name/label like this could cause an issue perhaps?

Perhaps, also try to make the if chains exclude each other (so the first fire only if spain has from 2 to 5 settlements, etc), perhaps when its happening all at once, it migh bring up issues....

[Belovèse]

I tried with and without character label, with true and false for scroll to show up (wich it never does by the way even if the script works, could it be related to the CTD?). I tried firing it during a few different factions turn. I used this for testing purpose.

    monitor_event PreFactionTurnStart FactionType slave
        log SOULD TEST EMERGENCE
        if I_EventCounter civil_war_byzantium_going_on = 0
            ; and RandomPercent > 50

            log TEST EMERGENCE
            ; set_event_counter civil_war_byzantium_going_on 1
            ; historic_event civil_war_byzantium
            ; increment_kings_purse byzantium -1000


            if I_NumberOfSettlements byzantium > 2
                log FIRST EMERGE
                faction_emerge slave byzantium 1 400.0 0.0 1.2 town false
                ; campaign_wait 0.1
            end_if               

            ; if I_NumberOfSettlements byzantium > 3
                ; log SECOND EMERGE
                ; faction_emerge slave byzantium 1 100.0 0.0 1.2 town false
                ; campaign_wait 0.1
            ; end_if

            ; if I_NumberOfSettlements byzantium > 4
                ; log THIRD EMERGE
                ; faction_emerge slave byzantium 1 100.0 0.0 1.2 town false
                ; campaign_wait 0.1
            ; end_if

            ; if I_NumberOfSettlements byzantium > 5
                ; log FOURTH EMERGE
                ; faction_emerge slave byzantium 1 100.0 0.0 1.2 town false
                ; campaign_wait 0.1
            ; end_if

            ; if I_NumberOfSettlements byzantium > 6
                ; log FIFTH EMERGE
                ; faction_emerge slave byzantium 1 100.0 0.0 1.2 town false
                ; campaign_wait 0.1
            ; end_if
            
        log END TEST EMERGENCE
        end_if
    end_monitor

so in my last test, almost everything was commented out but it was still crashing. Here is the log

[Jadli]

Nothing of interest in the log it seems....

Regarding the scrolls, I think it shows up only for other factions from what I found out (ie, if the rebellion happens to Byzantium, you will see the scrolls only as other fation than byzantium. So for byzantium, you need to make an event to inform the byzantium player about it I suppose.

Check this guide, in it the guy explains how to use use something like this and shows how the script should look, so try his structure with campaign_waits I guess (section 2 "Gifting regions")

And if that doesnt help...

Also, perhaps just try to switch "slave" to some other faction and see what happens, perhaps it helps to localize the issue?

And perhaps... it doesnt work well with PreFactionTurnStart? In all instances I have seen it used in my installed mods and in my own mod (where it works fine, though I dont use it for civil wars) its used withFactionTurnEnd of a target faction.... so in your case FactionTurnEnd FactionType byzantium?

[Belovèse]

Thanks for all the infos! Just did some test with this

    monitor_event PreFactionTurnStart FactionType slave
        log SOULD TEST EMERGENCE
        if I_TurnNumber > 0
            log TEST EMERGENCE
            if I_NumberOfSettlements byzantium > 2
                log FIRST EMERGE
                wait 0.1
                faction_emerge norway byzantium 1 400.0 0.0 1.2 town true unused_label1 unused_name 30
                wait 0.1
            end_if               
        log END TEST EMERGENCE
        end_if
    end_monitor

and it works sometime but is still a hit and miss. I had looked at the guide you linked yesterday, tried it and couldn't make it work in my case, but I'm not quite sure I fully understood everything.
I had also tried it with FactionTurnEnd, same results. It seems to be a hit and miss: sometimes it works more than 5 turns in a row, sometimes it CTD in the first attempt.

[Jadli]

Well, any news? Were you trying this test script without the spawn of new FL/general as well?

Anyway, regarding the thought behind the script itself, there is zero reason for you to script a faction leader/general to emerge as well (via the last three parts of faction_emerge), right? Because the rebels dont need a new one... (and it might give a general to the rebel settlement anyway?). And if you are using this extensively, it may be delaing turn times as you are making lof ot new characters, which would be the case if these are not unusual...

[Belovèse]

Hello Jadli, I'm still testing options. Mainly I'll have to test the faction emergence in EBII to see if there is something wrong with SSHIP, and I'll have other persons test it to see if there is something wrong with my install. I'll report any findings!
I did test:
- with wait commands
- with/without scripting a new FL
- with various factions, alive or dead
- with/without slaves
- at various moments: FactionTurnStart, PreFactionTurnStart, FactionTurnEnd, all these with various factions
- on different turns, from 1 to 5 (or 0 to 4 in internal counting)

For now I'm also working on a replacement script that uses both settlement_add_turmoil and provoke_rebellion:

  monitor_event FactionTurnEnd FactionType FACTION
    
        ; here conditions and counters, same as current script
    
        if I_FactionLeaderTrait FACTION Usurper > 2
            and I_EventCounter civil_war_FACTION_going_on = 0
            
            set_event_counter civil_war_FACTION_going_on 1
            historic_event civil_war_FACTION
            increment_kings_purse FACTION -1000

            if I_SettlementOwner SETTLEMENT = FACTION
                and RandomPercent < 40        ; or any other 
                
                add_settlement_turmoil SETTLEMENT 1000
                provoke_rebellion SETTLEMENT
            end_if
        end_if

        ; duplicate for every settlement
        ; add a way to remove the huge turmoil, maybe with counters?
    end_monitor

I did test what was said in various post, and provoke_rebellion command is active any number of turns until conditions are met, eg the target settlement goes bellow 70% public order, BUT it doesn't survive loading the saved game.

[Jadli]

Hm, yay, shame... I was hoping this could work reliably...

Though, one other thought.. Have you tested this when playing as the target or source faction? Or as different faction (a faction not affected by this at all)?

[Belovèse]

Yes, I have tested both as one of the affected faction or as a non-affected faction. But I cannot yet rule out that there is a problem with either SSHIP or my own install, I'll post here again after some more testing.

[Jadli]

Hm, perhaps Withwnar actually knows something? https://www.twcenter.net/forums/show...1#post15755663

That could explain why its CTDing sometimes?

[Belovèse]

Thanks for the link, I'll have a look. In the meantime I can say that emerging a dead faction from slave seems to be working fine, when emerging slaves from a living faction creates random CTD.
I'm putting logging entries in the new SSHIP version to track this, I hop we'll have more data and reports to understand what is happening.
But not too much reports, I mainly hope it works fine!

[Withwnar]

Another one for the list.

This...

monitor_event ArmyTakesCrusadeTarget IsJihad

...only fires when the army - all units within it - is on jihad. It does not fire if the army is a mixture of jihad and non-jihad. And does not fire if the army is not on jihad at all. And therefore does not fire if the army is of another faction (non-islam).

This works just fine...

monitor_event GeneralCaptureSettlement IsJihadTarget

Presumably, the same applies to crusades but I didn't test that. I don't have the demons handy so don't know the equivalents but from memory they'd be "not IsJihad" for the first one an IsCrusadeTarget for the second.

[Belovèse]

I can't test it right now, but do you know if GeneralTakesCrusadeTarget has the same problem?

[Withwnar]

No I don't know.

[Jadli]

btw, I found out that if in EDB you use for example

recruit_pool "Stormcloacks Th" 1 0.15 2 0 requires factions { scotland, } and region_religion catholic 25 and event_counter is_the_4th_era 0

it doesnt work, you have to write "and not event_counter is_the_4th_era 1" instead.

Not sure if its known or not...

[Jadli]

I believe NumEnemiesInBattle can be used used PostBattle (it counts the numer of remaining enemies), and it doesnt crash even when you fought multiple armies (tested with two)

[Gigantus]

Added link to your post in the respective line in the OP.

[Jurand of Cracow]

I believe NumEnemiesInBattle can be used used PostBattle (it counts the numer of remaining enemies), and it doesnt crash even when you fought multiple armies (tested with two)

In my notes I've got that it causes a crash if three AI armies are involved. I've never tested it, it's just from somebody's entry in the deep past.