weird building level bug

[MagusCaligula]

So in a modding I'm making I've added some new building trees, everything seems fine, I'm well under building trees limit (have only 81) and there aren't any errors in the log. What happens is this: if, in descr_strat, I add a building level above the base level it will show an wrong culture and the icon doesn't show up. In the building browser everything seems correct and the icon even shows up. If I upgrade in the game the culture is also correct, no problem. So apparently the issue is only if the building is added to the descr_strat and only if it's above the base level, if I add just the base level the culture is correct. All other buildings seems fine. When I had a similar thing happened was when I've gone above the building trees limit which is not the case. Any ideas on what could cause this? Thanks in advance.

[Gigantus]

That is most likely related to the ownership of the settlement at the start of the game: buildings present at start are deemed to have been build by the owner. Unless I mix that up with the loyalty faction entry in descr_region (3rd line) - but it will be either of these reasons, a simple change in descr_regions to a faction with a different culture will confirm which one it is.

[Withwnar]

Your first answer I'd wager, Gigantus. e.g. If england is the region's faction_creator in descr_strat and england is not in the factions{} list of that building level then the building may not look or read as expected. The solution is to change that faction_creator or add the creator to the factions{} list or, if none of those suit, add a creator line to the building in descr_strat for a faction that is in the factions{} list...

	building
	{
		type elf_community elf_community
		creator poland
	}

[Gigantus]

Thanks, I was wondering why 'creator' was bouncing around in my skull.

[MagusCaligula]

Forget about this, It's just all building levels besides the base one were restrict to cities and I added it to a castle -_-' As the mods I've made didn't had castles I completely forgot about that line, thanks for trying to help anyway

[MagusCaligula]

Well now I have a different issue related to this. The thing is now I've correct the lines for what I want but although the line for city is working (can't build the building in castles) the other way around doesn't work, the ones that should only be built in catles also show up in cities to build. I'm thinking this is maybe a bug related to the complex structure of this building tree.

Level1 and level2 have no restrictions, but level2 has then 3 upgrade possibilities like for example in the government system of EBII. The possibilities are level 3, 4 and 5. Level3 has the "city" tag and works as intended but level4 and 5 have the "castle" tag however it's not working as they also appear in the city browser. Might it be that castle buildings get bugged if all other levels aren't set for castles only?

[Gigantus]

It's a logic issue: each level requires the previous level to exist. Which means if a level 4 building that should only appear in castle has a level 3 city only building then it will obviously not happen.

Your conclusion is therefore true: "Might it be that castle buildings get bugged if all other levels aren't set for castles only?"

Edit: it should however work if there are no city\castle restrictions in the first three levels and castle restrictions from level four onward. That will enable the first three in castle and city and restrict the following levels to castle.

[MagusCaligula]

Well I was already thinking in adding hidden_resource to limit where the highest level buildings could be built so it will kinda fix this, but it would be good if we could have that option. I think it's just the engine is not prepared to have multiple choices in the building tree, it even seems confused when adding multiple choices and sometimes an error will be show in the log but is harmless apparently.

Edit: on the other hand I'll also need to remove the conversion stuff to guarantee is a castle, although I was already thinking about this to keep things more historical.

[Gigantus]

If you are not convinced that the EDB is a multi faced, multi limbed monster waiting to crash your mod then you should have a look at the EDB file of EBII. The govrome building tree is one of my all time favorites. It simply excels in the art of stupendous conditions, here is one for a unit's recruitment:

and hidden_resource celtic and hidden_resource gallic and not hidden_resource belgic and not hidden_resource eastcelt and not hidden_resource hr_river and hidden_resource hr_d or hidden_resource hr_j or hidden_resource teutonic_migration

And how is this for upgrade choices? It effectively reduces a six level building tree to a base building with 5 upgrade choices for the final level 2 building.

            upgrades
            {
                civlib requires factions { f_rome, } and not hidden_resource italy
                socit requires factions { f_rome, } and event_counter ecCamillanEra 1 or event_counter ecPolybianEra 1
                provinc requires factions { f_rome, } and not hidden_resource italy
                iuslat requires factions { f_rome, } and event_counter ecMarianEra 1
                municip requires factions { f_rome, } and hidden_resource italy and hidden_resource hr_i    ;;; to allow reconstitute Rome anytime in case it is lost - always available here
            }

[MagusCaligula]

If you are not convinced that the EDB is a multi faced, multi limbed monster waiting to crash your mod then you should have a look at the EDB file of EBII. The govrome building tree is one of my all time favorites. It simply excels in the art of stupendous conditions, here is one for a unit's recruitment:

and hidden_resource celtic and hidden_resource gallic and not hidden_resource belgic and not hidden_resource eastcelt and not hidden_resource hr_river and hidden_resource hr_d or hidden_resource hr_j or hidden_resource teutonic_migration

And how is this for upgrade choices? It effectively reduces a six level building tree to a base building with 5 upgrade choices for the final level 2 building.

            upgrades
            {
                civlib requires factions { f_rome, } and not hidden_resource italy
                socit requires factions { f_rome, } and event_counter ecCamillanEra 1 or event_counter ecPolybianEra 1
                provinc requires factions { f_rome, } and not hidden_resource italy
                iuslat requires factions { f_rome, } and event_counter ecMarianEra 1
                municip requires factions { f_rome, } and hidden_resource italy and hidden_resource hr_i    ;;; to allow reconstitute Rome anytime in case it is lost - always available here
            }

Yeah but the problem is if you want to make the choices vary with city and castle restrictions as I'm trying. I think their building trees are either for cities or castles (camps), they don't have a tree with a mix of cities and castles.

[Gigantus]

Well, you have a total of 128 building trees to play with - that should be enough to allow you to do castle\city options (with or without conversion option) like it is done in the default game.

[Callistonian]

Can someone kindly tell me what actually happens when you have more than 128 building chains in EDB? Is there a startup crash? If so, what is the nature of the crash? Error report with "max records exceeded..."?

[Gigantus]

Possibly, but I have never heard of it being reported.

[Callistonian]

From what I can tell, the hard coded limit manifests itself as a CTD when the user attempts to open the building scroll (for recruitment or construction). The "unspecified error" message pops up and there is nothing useful in the log. Another thing I've noticed is that some of the over-128 buildings can replace sub-128 buildings in settlements. There doesn't appear to be any pattern for which buildings get replaced.

This behavior suggests that the count of buildings in EDB is simply stored as a 16-bit word rather than using a comparison against an arbitrary value.