Page 20 of 20 FirstFirst ... 1011121314151617181920
Results 381 to 395 of 395

Thread: Bovine M2TW Checker

  1. #381

    Default Re: Bovine M2TW Checker

    Quote Originally Posted by bovi View Post
    For EB2, most units seem to be fine except possibly 4, so that speaks in favour of it being accurate. If you're not surprised by the great number of dangly bits, I'll assume it's accurate for now. I'll make a check for surplus files in those folders using the results from the existence checks.
    Actually I used your last version and it seems there are false reports for missing units info pictures in SSHIP. I looked at the "italian cavalry militia" for instance, here was the report:
    Code:
    export_descr_unit.txt 1135 (italian cavalry militia - Faction pisa): italian_cavalry_militia_info.tga under folder ../SSHIP_098/data/ui/unit_info/pisa/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction venice): italian_cavalry_militia_info.tga under folder ../SSHIP_098/data/ui/unit_info/venice/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction papal_states): italian_cavalry_militia_info.tga under folder ../SSHIP_098/data/ui/unit_info/papal_states/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction sicily): italian_cavalry_militia_info.tga under folder ../SSHIP_098/data/ui/unit_info/sicily/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction slave): italian_cavalry_militia_info.tga under folder ../SSHIP_098/data/ui/unit_info/slave/ does not exist.
    It turns out the only folder it was missing in was the slave folder, but even after putting the tga in it your tool still reported it as missing.

    Anything more I can do to help? Do you want a link to our current beta version?

    EDIT: Also, second report: I have a lot of unused mount and missing mount reports that are false positive. It seem to me like the tool does not recognize spaces in the mount name, and so it searches for example it the mount is named "barded horse" in descr_mount it search for "barded" only in EDU.
    Last edited by Belovèse; April 06, 2021 at 11:59 AM.
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  2. #382

    Default Re: Bovine M2TW Checker

    Yeah, I expected there couldn't be that many missing ones... A download for your current dev build would be helpful, yes, as I would then have the same line numbers as you. I'll look into why it's not recognizing the files for the italian cavalry militia, and that will probably wipe out a lot of other false reports as well.

    Thanks also for mentioning the mounts. I'll see what it's doing - probably it's only looking at the second token, while it should look at all the tokens until a comma or similar as there can be spaces in their names.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  3. #383

    Default Re: Bovine M2TW Checker

    I'll put together a new testing version tomorrow I think, I'll send you the link by PM then.
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  4. #384

    Default Re: Bovine M2TW Checker

    I got to looking at this today. On my computer, on the version of your mod I have, these are the messages output by it:

    export_descr_unit.txt 1135 (italian cavalry militia - Faction slave): italian_cavalry_militia_info.tga under folder ../../../../M2TWOtherMods/mods/ss6.3/data/ui/unit_info/slave/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction venice): #italian_cavalry_militia.tga under folder ../../../../M2TWOtherMods/mods/ss6.3/data/ui/units/venice/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction papal_states): #italian_cavalry_militia.tga under folder ../../../../M2TWOtherMods/mods/ss6.3/data/ui/units/papal_states/ does not exist.
    export_descr_unit.txt 1135 (italian cavalry militia - Faction sicily): #italian_cavalry_militia.tga under folder ../../../../M2TWOtherMods/mods/ss6.3/data/ui/units/sicily/ does not exist.

    So, only the slave one for the info picture, while three other factions for the unit card picture. After copying pisa's info picture into slave's folder, that report disappeared.

    The three unit cards are also truly missing, as far as I can see in my version of your mod, and it's not reporting the two factions where that file is present (slave and pisa).

    So, it looks correct to me for that unit at least. For better or for worse, I guess... I'm not sure what kind of changes I could have been making in the meantime that makes it better than in your version of the checker, but there should at least be a chance that it's fine for you as well once I release a new version. Will do so when I have looked at the mount references.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  5. #385

    Default Re: Bovine M2TW Checker

    Uploaded a new version.

    Quote Originally Posted by change log
    New checks:
    All present files under data/ui/unit_info are in use for the unit detail page.
    All present files under data/ui/units are in use for unit cards in the army composition panel.

    Bugfixes:
    Reading mount usage in EDU now reads the full line rather than only the first token of the mount name, as these can contain spaces.
    When dynamically encountering a file reference starting with "data/", this part is now omitted, as the search for any files start in the data folder as is. Dynamic here means a constructed path, such as from unit ownership to necessary unit card pictures. Static file references would be straight file names encountered in various files. Static file references already got shaved off this part upon storing the reference, but dynamic references go directly to checking the reference rather than being stored first. It would be better to just not include the data bit in the first place, will probably fix that later.

    Technical:
    Converted a number of data storage classes to Kotlin.
    Edit: Oops, did a mistaken rename of a java file that was not yet converted to Kotlin. While the compiled classes should work correctly, the sources would not have compiled. Amended now.
    Last edited by bovi; April 13, 2021 at 08:38 AM.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  6. #386

    Default Re: Bovine M2TW Checker

    Thanks a lot Bovi, I'll double-check this unit cards business when I get on my comp.

    Just thought of one thing: does your checker take into account the vanilla unit cards and Info's pics, if they are not present in the mod folder? If the names are right the game will look for them in the vanilla folder, so there's no need for them to be in the mod folder in this case.
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  7. #387

    Default Re: Bovine M2TW Checker

    Yes, it should do so. In general:

    1. Look in the mod folder for the exact file in question.
    2. Look in the mod folder for the file with an additional extension that it could have.
    3. Look in the mod folder for the file with an alternative extension that it could have.
    4. Check if the exact filename is contained in config/acceptedMissingFiles.txt.
    5. Check if the exact filename is contained in config/vanillaFiles.txt.
    6. Check if the filename with additional extension is contained in config/vanillaFiles.txt.
    7. Check if the filename with alternative extension is contained in config/vanillaFiles.txt.

    About additional and alternative extensions, texture files often have ".dds" tacked on their names in addition to the reference stated in the model files, and model files are typically referenced as filename.cas, but sometimes these files are actually called filename.cmi instead. The game successfully finds these files, so the checker must too.

    About acceptedMissingFiles, you would add filenames here to suppress reports about them missing. This is useful if there is some piece of the game that needs to be present, but it is actually never in use. In EB2, for instance, the "peasants" unit ostensibly needs to exist for the game to run, but the unit cannot ever be created. Thus, it's fine even if the files referenced in their definition don't exist.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  8. #388

    Default Re: Bovine M2TW Checker

    Thanks a lot, so if I understand correctly it doesn't check the vanilla folder himself, but rather the lists contained in those 2 files? So I'll have to add a list of the vanilla unit cards and pics in it to suppress those reports.

    I also was wondering about animations, I get a lot of missing animations reports but maybe it is the same thing here. I didn't tackle it yet because I don't know anything about animations!
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  9. #389

    Default Re: Bovine M2TW Checker

    Quote Originally Posted by Belovèse View Post
    Thanks a lot, so if I understand correctly it doesn't check the vanilla folder himself, but rather the lists contained in those 2 files?
    Yes.

    Quote Originally Posted by Belovèse View Post
    So I'll have to add a list of the vanilla unit cards and pics in it to suppress those reports.
    No. The vanilla unit cards and pictures should already be in vanillaFiles.txt, and only those missing from your mod and not part of a vanilla installation should be reported as is. If this is not true, please point out a concrete example.

    Quote Originally Posted by Belovèse View Post
    I also was wondering about animations, I get a lot of missing animations reports but maybe it is the same thing here. I didn't tackle it yet because I don't know anything about animations!
    Have you considered this option in the checker configuration file?

    ;The checker can be configured to require vanilla animations to be present in
    ;the mod's own animations folder. As this is the case for EB2, this is the
    ;default setting even if most mods can rely on vanilla animation files being
    ;available to the mod. Chances are that you want to uncomment the setting
    ;below for any other mod than EB2.

    ;VANILLA_ANIMATIONS_REQUIRED=NO

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  10. #390

    Default Re: Bovine M2TW Checker

    Quote Originally Posted by bovi View Post
    No. The vanilla unit cards and pictures should already be in vanillaFiles.txt, and only those missing from your mod and not part of a vanilla installation should be reported as is. If this is not true, please point out a concrete example.
    Thanks, when I asked this I was not on my comp, but I saw this morning that the files are indeed well listed in vanillaFiles.txt, and I have no error to report about this!

    Quote Originally Posted by bovi View Post
    Have you considered this option in the checker configuration file?

    ;The checker can be configured to require vanilla animations to be present in
    ;the mod's own animations folder. As this is the case for EB2, this is the
    ;default setting even if most mods can rely on vanilla animation files being
    ;available to the mod. Chances are that you want to uncomment the setting
    ;below for any other mod than EB2.

    ;VANILLA_ANIMATIONS_REQUIRED=NO
    This option is already uncommitted on my config, here is the file just in case I messed something up (even if this config file is straight-forward and well documented!)
    Code:
    ;Set DATAFOLDER to the data folder for your mod, such as C:/Games/M2TW/mods/my_mod_name/data
    ;C:/Games/M2TW needs to be changed to wherever your M2TW is installed to.
    ;my_mod_name needs to be changed to whatever your mod folder is called.
    DATAFOLDER=../SSHIP_098/data
    
    ;Set STRAT to the folder containing your campaign script and descr_events.
    ;Probably this is the default imperial_campaign.
    STRAT=world/maps/campaign/imperial_campaign
    
    ;When encountering a file (animation, sound, model etc) where it cannot see
    ;any usage, it gets reported as unused. You will probably want to actually
    ;reference it, but possibly you instead wish to remove it to reduce mod size.
    ;Provide commands for what to do with these below.
    ;Suggested variants below, not all of them will be relevant for you.
    ;Use this with caution, and ONLY after checking for possible typos in
    ;references and files that you really want to use in the mod after all!
    ;You can define more than one - this will cause each of them to be executed,
    ;in sequence. If you want to move to a backup folder, ensure that works
    ;properly before enabling the deletion command!
    ;REMOVE_UNUSED_FILES=COPY_TO unused_backup
    ;REMOVE_UNUSED_FILES=CONSOLE_COMMAND svn delete %DATAFOLDER%/%FILENAME%
    ;REMOVE_UNUSED_FILES=CONSOLE_COMMAND git rm %DATAFOLDER%/%FILENAME%
    ;REMOVE_UNUSED_FILES=CONSOLE_COMMAND del %DATAFOLDER%/%FILENAME%
    
    ;The checker can be configured to require vanilla animations to be present in
    ;the mod's own animations folder. As this is the case for EB2, this is the
    ;default setting even if most mods can rely on vanilla animation files being
    ;available to the mod. Chances are that you want to uncomment the setting
    ;below for any other mod than EB2.
    VANILLA_ANIMATIONS_REQUIRED=NO
    
    ;The checker expects all hidden traits to use descriptions "hidden_desc" and 
    ;"hidden_effects_desc". Any hidden traits with specific descriptions are
    ;considered to be intended to be shown to the player and assigned as hidden by
    ;mistake. If your mod wishes to keep trait specific text even for hidden
    ;traits, uncomment this line below to suppress those reports.
    HIDDEN_TRAIT_DESCRIPTIONS_SUPPRESSED=YES
    
    ;The checker tries to match all sound file names with the accent it is used for.
    ;Any file names not matching the defined accent prefixes will be reported. If
    ;you are not doing voice modding or otherwise don't want these reports, you can
    ;suppress them by uncommenting the line below.
    ACCENT_PREFIXES_SUPPRESSED=YES
    
    ;The checker tries to match all referenced sound files with the file system.
    ;If all your sound files are packed rather than available as individual files,
    ;you want to suppress reports about missing files by uncommenting the line below.
    ;SOUNDFILE_INTEGRITY_SUPPRESSED=YES
    
    ;Some agent types may not be in use in your mod, despite them being part of
    ;some of your files. In this case you are probably encountering a bunch of
    ;reported issues that are not really relevant for you. You can enter any number
    ;of these agents here and their file references should not be checked. If you
    ;still get some reports concerning them, I may have forgot to check the config
    ;in some instances. Let me know in the forum.
    ; UNUSED_AGENT=merchant
    ; UNUSED_AGENT=priest
    ; UNUSED_AGENT=princess
    ; UNUSED_AGENT=inquisitor
    ; UNUSED_AGENT=witch
    ; UNUSED_AGENT=heretic
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  11. #391

    Default Re: Bovine M2TW Checker

    In that case, you'll have to bring up a concrete example if you think there's something wrong with the animation checks. There certainly could be, but it seems right to me.
    Last edited by bovi; April 14, 2021 at 11:38 PM.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  12. #392

    Default Re: Bovine M2TW Checker

    Got your PM. No worries about the delay - we at EB2 are no strangers to stuff cluttering up plans of releases, to be sure.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  13. #393

    Default Re: Bovine M2TW Checker

    I've got the download and have unpacked it, but could I ask what the "data XII" and "data XIII" folders are meant to be? Should I patch the data folder with their contents?

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

  14. #394

    Default Re: Bovine M2TW Checker

    ah yes, sorry, these are part of the Kostic Chronology Costumes: it is used to swaps textures when you progress in the game years, to reflect historical evolution. Well it is not automatic, the player has to do it.
    There is no need for you to do anything at first, the countents in data XII are the same that are in the regular data folder.
    Belovèse's Toolbox: export text files to spreadsheet, detailed unit stats
    Stainless Steel Historical Improvement Project (SSHIP) team member.
    Mini-mods: diplomacy and relation/reputation - detailled unit stats

  15. #395

    Default Re: Bovine M2TW Checker

    In that case I'll just delete those folders, the main data folder should be sufficient to run my tests of checks on.

    Having problems getting EB2 to run? Try these solutions.
    ================
    I do NOT answer PM requests for help with EB. Ask in a new help thread in the tech help forum.
    ================
    I think computer viruses should count as life. I think it says something about human nature that the only form of life we have created so far is purely destructive. We've created life in our own image. - Stephen Hawking

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •