WIP Fix Pack 1.2.2c

[Dresden]

This is now included in the main mod, thanks for helping test!

Update Notes

Population System (Thanks to Litharion!)
- Naval recruitment changed: The closest port region is now used for replenishment and recruitment instead of the capital unless there is no port.
- City names now added for unit recruitment so you can see what city the unit is drawing population from.

Other Changes/Fixes
- Fixed civil war crash. Civil wars still have reform units in newly spawned armies, unfortunately.
- Added some new ancillaries from new DLC into older campaigns.
- Changed non-empire faction leader public order traits to be local rather than global.
- Fixed range buff display error.

[projectcorner]

Great work Dresden, that is really a quick update! Can't imagine how much work you put behind.

[servent9]

i can't open this file with PFM [errors]

you modified this file from some kind of creative assembly editor?

i just hope the file was not corrupt and not ruin my 3months save games

[Dresden]

Its just a normal pack file, but you dont have to open it. You can just put it in your data directory like any other mod. Also as long as you dont save over a save game it cant be ruined.

Edit - I just downloaded it to test and it works for me, I can open it etc. Maybe you need to re-download it, perhaps your download got corrupted somehow?

[krissmus]

I'll take a look at it after work and give you my results.

[servent9]

oh my new update at 11/3?

new 5.0 version is work fine. i don't know why PFM was not auto updated..

anyway much appreciate your works.

[CIaagent11]

What was the cause of the civil war crash?

[Dresden]

From what I can tell:
1. The faction_civil_war table is referenced and saved into a save game when it is first loaded/saved after the beta update. That table then tells the save what civil war factions to use. Some of those factions don't exist in our startpos files. This will also be a problem for vanilla in save games from what I can tell.
2. For new games, factions starting with more than 2 parties seem to crash with an early civil war. Perhaps due to the way the hardcoded algorithm works, I don't know. Maybe the game is expecting a certain number of parties and our starting 4 is bugging it out.


I tested this fix pack out with a new baktria campaign and a civil war worked. It also worked in 2 old campaigns I had - an IA Armenia campaign and a GC Thrace campaign.

[Morticia Iunia Bruti]

The new faction_civil_war table has three columns instead of two like before Patch 18.

[Dresden]

Yep, I have it in the mod and now in the fix pack also - I assumed it was fine to leave it as vanilla since it references factions that don't exist in save games (and also won't exist in vanilla saves). But I was wrong, so I changed it to reference only our civil war factions.

[Dresden]

Updated
- Fixed missing commander permissions missing for some civil war factions in GC (Scordisci, Armenia, Parthia, Bosporus, Colchis, Pergamon, Kartli) that also was probably causing issues for those factions and civil wars.

[krissmus]

i tried Macedon with the new patch, and i got a crash

[Dresden]

Damn, okay thanks. It worked with baktria for me, I will test with Macedon. I had hoped I had fixed it

Edit - can you upload the save so I can test it a bit? Thanks again

Edit 2 - I just ran a test with Macedon and the new fix pack and the civil war worked for me at turn 21 as long as the other faction had a leader with an army. When the other faction was just a statesman, it crashes...

Maybe since we are trying to force a civil war early and the other faction doesn't have any influence over lands, the system bugs out?

[krissmus]

Damn, okay thanks. It worked with baktria for me, I will test with Macedon. I had hoped I had fixed it

Edit - can you upload the save so I can test it a bit? Thanks again

Edit 2 - I just ran a test with Macedon and the new fix pack and the civil war worked for me at turn 21 as long as the other faction had a leader with an army. When the other faction was just a statesman, it crashes...

Maybe since we are trying to force a civil war early and the other faction doesn't have any influence over lands, the system bugs out?

civil war test 3.rar
I think i just missed your last update when i tried it, but i noted that there was just a single opposing family when i started a new campaign, is that intentional or do i have a bad install? (im not running any other mods btw)

Also did you capture any territory when it worked for you? I just spammed the end turn button and still just had Pella.

[Dresden]

Just 2 parties is what I am testing right now, we will see if that helps with fixing things or not. Thanks again for helping out.

I just got a civil war to work but I had to remove some of our unit tables, so I think maybe its something to do with the army spawn. Basically, if the other civil war faction has an army then it works right now. If they don't, then the game tries to create one and something is messing that up. Maybe its having custom units, I am not sure yet.

[krissmus]

Just 2 parties is what I am testing right now, we will see if that helps with fixing things or not. Thanks again for helping out.

I just got a civil war to work but I had to remove some of our unit tables, so I think maybe its something to do with the army spawn. Basically, if the other civil war faction has an army then it works right now. If they don't, then the game tries to create one and something is messing that up. Maybe its having custom units, I am not sure yet.

ok i finally got it to work, but i had to spawn the opposing leader and give him a full stack of mercs (it crashed for me if the army was empty) so yeah i think you're right it's probably trying to spawn invalid units if it has no armies

[krissmus]

sorry for double post, but i don't have permission to edit my posts, but i wanted to tell you that i just tried to trigger a full blown civil war on a save from the beta.
it kept the 4 families in that save so i was a bit worried that it was not possible in this version, but i got it to work after i gave all the family leaders full armies.

[CIaagent11]

Maybe this will make the debugging process easier: https://steamcommunity.com/sharedfil...?id=1190558996

[Dresden]

So, I figured it out - its due to our roster sizes. For some reason, the civil war army spawn script crashes when there are too many units in a roster. The problem is, we have a lot of units due to our AOR and Aux systems. So, unless they fix the way civil war armies spawn, we are either stuck with a crash or we will have to remove a lot of our AOR/Aux systems which just isn't something that we would ever want to do.

The army spawns also ignore reform and technology restrictions....

[KYREAPER]

So, I figured it out - its due to our roster sizes. For some reason, the civil war army spawn script crashes when there are too many units in a roster. The problem is, we have a lot of units due to our AOR and Aux systems. So, unless they fix the way civil war armies spawn, we are either stuck with a crash or we will have to remove a lot of our AOR/Aux systems which just isn't something that we would ever want to do.

The army spawns also ignore reform and technology restrictions....

That really sucks.. because i highly doubt they will go back and change something so specific that would just HAPPEN to help this mod...
Unless someone brought the attention of a CA developer in here(who likes the mod) and has some swing and could help yall out.

I wouldnt bet on them fixing it without directly bringing one into the thread.