OfferedForMarriage event

**selv** · June 02, 2018, 01:57 AM

Originally Posted by Withwnar

This works...

A new hidden trait:

Code:

;------------------------------------------
Trait IsNotANewlyRecruitedGeneral
    Characters family
    Hidden

    Level IsNotANewlyRecruitedGeneral
        Description IsNotANewlyRecruitedGeneral_desc
        EffectsDescription IsNotANewlyRecruitedGeneral_effects_desc
        Threshold  1

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger1
    WhenToTest CharacterTurnStart

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger2
    WhenToTest CharacterMarries

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger3
    WhenToTest OfferedForAdoption

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger4
    WhenToTest LesserGeneralOfferedForAdoption

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger RecruitedGeneral_trigger1
    WhenToTest CharacterTurnEndInSettlement

    Condition Trait IsNotANewlyRecruitedGeneral = 0
         ;and [building test or whatever can go here]

    Affects ...

It works because unit recruitment (and therefore recruited general creation) happens before CharacterTurnEnd/CharacterTurnEndInSettlement. CharacterTurnStart has not yet fired upon him so he does not yet have the IsNotANewlyRecruitedGeneral trait. i.e. IsNotANewlyRecruitedGeneral = 0 means that he IS a newly recruited general.

Everybody else starts 'life' (in this faction) with the IsNotANewlyRecruitedGeneral trait. No need for a ComesOfAge trigger because CharacterTurnStart will fire upon them before CharacterTurnEnd does. Whereas marriages and adoptions happen between TurnStart and TurnEnd so, without those triggers, RecruitedGeneral_trigger1 would think that they're recruited.

I feel like a dwarf, in the company of a giant... Otherwise known as, if I was able to see further than the other men, it's because I stood on the shoulders of a giant...

You must spread reputation before giving it again, on the other hand, is a much less fitting sentence.

**Titus le Chmakus** · June 04, 2018, 07:08 AM

Originally Posted by Withwnar

That's true. Alternatively, just change that first original trigger to CharacterTurnEnd.

Yeah, seems there's no relevant event for it to use as the WhenToTest. Not directly.

This works...

A new hidden trait:

Code:

;------------------------------------------
Trait IsNotANewlyRecruitedGeneral
    Characters family
    Hidden

    Level IsNotANewlyRecruitedGeneral
        Description IsNotANewlyRecruitedGeneral_desc
        EffectsDescription IsNotANewlyRecruitedGeneral_effects_desc
        Threshold  1

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger1
    WhenToTest CharacterTurnStart

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger2
    WhenToTest CharacterMarries

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger3
    WhenToTest OfferedForAdoption

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger IsNotANewlyRecruitedGeneral_trigger4
    WhenToTest LesserGeneralOfferedForAdoption

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

;------------------------------------------
Trigger RecruitedGeneral_trigger1
    WhenToTest CharacterTurnEndInSettlement

    Condition Trait IsNotANewlyRecruitedGeneral = 0
         ;and [building test or whatever can go here]

    Affects ...

It works because unit recruitment (and therefore recruited general creation) happens before CharacterTurnEnd/CharacterTurnEndInSettlement. CharacterTurnStart has not yet fired upon him so he does not yet have the IsNotANewlyRecruitedGeneral trait. i.e. IsNotANewlyRecruitedGeneral = 0 means that he IS a newly recruited general.

Everybody else starts 'life' (in this faction) with the IsNotANewlyRecruitedGeneral trait. No need for a ComesOfAge trigger because CharacterTurnStart will fire upon them before CharacterTurnEnd does. Whereas marriages and adoptions happen between TurnStart and TurnEnd so, without those triggers, RecruitedGeneral_trigger1 would think that they're recruited.

You're defenetly mad at coding Withwnar !!! Did CA ask you how to do when they coded the game ? If not, they should have !!!

thanks again.

I feel like a dwarf, in the company of a giant... Otherwise known as, if I was able to see further than the other men, it's because I stood on the shoulders of a giant...

I have ceased trying to compare with that guy ! He's better at coding Med 2 than CA !!!

You must spread reputation before giving it again, on the other hand, is a much less fitting sentence.

Well how can you spread rep to somebody even over the concept of Rep ? Withwnar and Gigantus are both abov that !!!

Permission to piggyback?
Would the Affects [Trait] -1 also work to remove ancillaries from a family member?
I was looking to "fix" the authority mechanic for selecting the next heir with a trait and a unique ancillary. The trait was simply called RoyalBlood and triggered on comes of age, condition Father has trait RoyalBlood, authority +2.
The ancillary, royal_line, required Trait RoyalBlood, Father is FactionHeir or FactionLeader, and ancillary does not exist in Faction; and gave authority +10
The problem I ran into was removing the ancillary once the next in line became FactionHeir.

It is all in there : http://www.twcenter.net/forums/showt...d-faction-heir

**DanishTerror** · June 02, 2018, 10:22 AM

Permission to piggyback?
Would the Affects [Trait] -1 also work to remove ancillaries from a family member?
I was looking to "fix" the authority mechanic for selecting the next heir with a trait and a unique ancillary. The trait was simply called RoyalBlood and triggered on comes of age, condition Father has trait RoyalBlood, authority +2.
The ancillary, royal_line, required Trait RoyalBlood, Father is FactionHeir or FactionLeader, and ancillary does not exist in Faction; and gave authority +10
The problem I ran into was removing the ancillary once the next in line became FactionHeir.

**selv** · June 02, 2018, 06:29 PM

The giant explain the shortcoming of using ancillaries for this here:
http://www.twcenter.net/forums/showt...illary-mission

And no, Affect can't be use in the EDA. Use a hidden trait only instead, that trigger via script on whoever you want to be the next heir. Then you can remove it easily once he become heir/leader:
http://www.twcenter.net/forums/showt...te-24-07-2015)

I don't want to use it for my own gameplay reasons but it has become quite popular I think.

**DanishTerror** · June 03, 2018, 04:38 AM

This is the Trait I used to determine the natural royal family, in other words, excluding adoptions.

Spoiler Alert, click show to read:

Here's the original ancillary:

Spoiler Alert, click show to read:

So, If I changed royal_line from an ancillary to a trait, would the trigger work if left as is? Then add a second trigger; becomes factionHeir, affect trait -1

Btw, my apologies, I did not intend to hijack the thread.

As always, the help is appreciated.

Edit: Posted new thread here: http://www.twcenter.net/forums/showt...3#post15603483

**selv** · June 03, 2018, 07:11 AM

I never use NoGoingBackLevel, I prefer making more triggers and I think there is some sort of bug with it, but I never experienced it since I don't use it, and antitraits neither.

But that's beside the point right now. If I am following your idea, this is how I would go with it:

Code:

;------------------------------------------
Trait RoyalBlood
    Characters family
     Hidden


    Level Royal_Blood
        Description Royal_Blood_desc
        EffectsDescription Royal_Blood_effects_desc
        Threshold  1 


        Effect Authority 5 
        Effect PersonalSecurity 1
;------------------------------------------
Trait AdoptedBlood
    Characters family
     Hidden


    Level Adopted_Blood
        Description Royal_Blood_desc
        EffectsDescription Royal_Blood_effects_desc
        Threshold  1

;------------------------------------------
Trigger dads_royal1
    WhenToTest CharacterComesOfAge


    Condition FatherTrait Factionleader > 0
    and Trait RoyalBlood < 1
    and not IsFactionLeader

    Affects RoyalBlood  1  Chance  100 

;------------------------------------------
Trigger dads_royal2
    WhenToTest CharacterComesOfAge

    Condition FatherTrait Factionheir > 0
    and Trait RoyalBlood < 1
    and not IsFactionLeader

    Affects RoyalBlood  1  Chance  100 

OfferedForAdoption
LesserGeneralOfferedForAdoption

;------------------------------------------
Trigger AdoptedBlood1
    WhenToTest OfferedForAdoption


    Condition AdoptedBlood < 1
     and not IsFactionLeader

    Affects AdoptedBlood  1  Chance  100 

;------------------------------------------
Trigger AdoptedBlood2
    WhenToTest LesserGeneralOfferedForAdoption

    Condition Trait AdoptedBlood < 1
    and not IsFactionLeader

    Affects AdoptedBlood  1  Chance  100

;------------------------------------------
Trigger dads_royal3
    WhenToTest CharacterTurnStart


    Condition FatherTrait Factionleader > 0
    and Trait RoyalBlood < 1
    and Trait AdoptedBlood < 1
    and not IsFactionLeader

    Affects RoyalBlood  1  Chance  100 

;------------------------------------------
Trigger dads_royal4
    WhenToTest CharacterTurnStart

    Condition FatherTrait Factionheir > 0
    and Trait RoyalBlood < 1
     and Trait AdoptedBlood < 1
    and not IsFactionLeader

    Affects RoyalBlood  1  Chance  100

;------------------------------------------
Trigger RemoveRBLeader
WhenToTest BecomesFactionLeader


Condition Trait RoyalBlood = 1


Affects RoyalBlood -1 Chance 100

;------------------------------------------
Trigger RemoveRBHeir
WhenToTest BecomesFactionHeir


Condition Trait RoyalBlood = 1


Affects RoyalBlood -1 Chance 100

The traits are hidden, as it is more technical traits than gameplay ones, and that way they aren't getting in the way of real gameplay traits to trigger. Also note that I putted a 5 authority , seem a good boost but feel free to test other values, max is 10 for a attribute I think. Ah, and one great thing of hidden traits, it's that neither you or the game have to care about their description, you can make them share the same text since they will never be visible in game. Just comment out the Hidden part with a ; character in front, when you need to test quickly that they do trigger.

So the two first triggers are giving the authority boost to the sons of currents FactionLeader/heir, the next two track adopted characters, and the CharacterTurnStart are there as a assurance in case of a sudden change of lineage on the throne, including checks that some 'sons' weren't adopted.
Then the last remove the hidden authority boost trait from characters becoming FactionLeader/heir. I guess I would go for a system like this when I will be near the end of my mod, as such considerations are low in my priority of 'to do' list, and I am not hot about directly choosing directly the heir by script, it seem too easy.
This one might give a serious boost to lineages while keeping some of the vanilla surprise part, probably. Let me know if I forgot something as I just made this up quickly. Or if I misunderstood what you want but this little excercise might not be lost anyway as I sort of like the concept, for some of my factions maybe. Mh ha ha ha...

**Titus le Chmakus** · June 04, 2018, 07:56 AM

EDIT : Sorry Withwnar there must be something wrong, it does not work ...

Are you sure when you have 2 different conditions, both tested by the event, it works ? Or do the condition have to be both testing the same ? I mean Trait is exportingcharacter_record and SettlementBuildingExists exports settlement ... But they are both tested by the CharacterTurnEndInSettlement !

Here is what I have replaced in your blue text

Code:

 
Trigger ChurchTalosRecruitedGeneral_trigger1
    WhenToTest CharacterTurnEndInSettlement

    Condition Trait IsNotANewlyRecruitedGeneral = 0
        and SettlementBuildingExists = church_talos

    Affects Genocide  3  Chance  100

**selv** · June 04, 2018, 09:41 AM

Originally Posted by Titus le Chmakus

Are you sure when you have 2 different conditions, both tested by the event, it works ? Or do the condition have to be both testing the same ? I mean Trait is exportingcharacter_record and SettlementBuildingExists exports settlement ... But they are both tested by the CharacterTurnEndInSettlement !

Yes it work, but conditions don't export anything, it's the events that do. CharacterTurnEndInSettlement is the right event here, I have similar triggers. If it doesn't work, then either there is something missing in the other triggers, or a recruited general somehow get a turn start at his creation?

I have ceased trying to compare with that guy !
Well how can you spread rep to somebody even over the concept of Rep ? Withwnar and Gigantus are both abov that !!!

I will tell the story of Darth Withwnar the wise, Dark lord of the script, to my apprentice someday...

It is all in there : http://www.twcenter.net/forums/showt...d-faction-heir

I still prefer my version, it could work well to some degree with the ai also.

**Jurand of Cracow** · June 05, 2018, 01:48 AM

On the margin I've got a question related to CoA and marriages: can I use "not" with "FactionBuildingExists"? Eg.

Code:

;------------------------------------------
Trigger MasterGuild_9
 WhenToTest CharacterComesOfAge


 Condition FactionBuildingExists = m_theologians_guild
       and not FactionBuildingExists = gm_theologians_guild

**Withwnar** · June 05, 2018, 07:06 AM

Thanks for the kind words guys.

Originally Posted by selv

If it doesn't work, then either there is something missing in the other triggers, or a recruited general somehow get a turn start at his creation?

It worked for me, so it can't be a turn start problem. Anything in the log? I'd try without the building condition just to make sure it's working at all.

Does the settlement you're trying have that building? If it's in the construction queue and due to finish in the same turn as the general recruitment then maybe that's why: if unit recruitment happens before construction completion (I don't know) then it isn't there yet when he is brought to life.

@JoC
I expect so but never tried it. Easy enough to test: pre-build one of each in descr_strat, test, then destroy the gm_ one and test again.

**Titus le Chmakus** · June 05, 2018, 07:11 AM

Yes it work, but conditions don't export anything, it's the events that do. CharacterTurnEndInSettlement is the right event here, I have similar triggers.

I know ! But you understand what I mean !!!

If it doesn't work, then either there is something missing in the other triggers, or a recruited general somehow get a turn start at his creation?

Good question ? And is a recruited general considered by the game as a general when it is created ?

EDIT :

It worked for me, so it can't be a turn start problem. Anything in the log? I'd try without the building condition just to make sure it's working at all.

I tried and still does not work ... How do you see the triggers in the log ? I'm using the *trace and cannot see any errors ...

Does the settlement you're trying have that building? If it's in the construction queue and due to finish in the same turn as the general recruitment then maybe that's why: if unit recruitment happens before construction completion (I don't know) then it isn't there yet when he is brought to life.

Cannot be ! I always start a new campaign when trying my scripts ! The buildings are already in the descr_strat !

**Withwnar** · June 05, 2018, 10:17 AM

Log: I meant only errors. Trace mode isn't necessary for that.

So, just to make sure we're not missing the obvious here, you ARE recruiting a general_unit unit and you ARE getting a named character (general) as a result. A general that looks in every way like a normal general: portrait, name, etc. Yes? And when you take out the settlement condition he is not getting the Genocide trait (Brutal Conqueror)?

**Titus le Chmakus** · June 06, 2018, 02:46 AM

Log: I meant only errors. Trace mode isn't necessary for that.

Well I have nothing in trace mode but maybe I should get back to errors.

So, just to make sure we're not missing the obvious here

that's right !!! It sometimes happen !

you ARE recruiting a general_unit unit and you ARE getting a named character (general) as a result. A general that looks in every way like a normal general: portrait, name, etc. Yes? And when you take out the settlement condition he is not getting the Genocide trait (Brutal Conqueror)?

Correct ! That makes me think that the general_unit is getting the trait, not the named character ...
I also had made this trigger and it is useless

Code:

;------------------------------------------
Trigger church_talos_member1
    WhenToTest AgentCreated

    Condition TrainedAgentType = general (could be replaced with AgentType = named character or whatever combination of the two, it does not change anything)
          and SettlementBuildingExists = church_talos

    Affects Genocide  3  Chance  100

**Withwnar** · June 06, 2018, 04:25 AM

Aha! You're right Titus, it doesn't work. My mistake: I added those marriage and adoption triggers to the original post later, and never tested it with them in. Now they are in the recruited general isn't getting the trait.

The reason is because OfferedForAdoption fires on him. Strange. The game does not ask me if I wish to adopt, and he isn't present in the family tree, so I'm guessing that he isn't actually adopted. Nevertheless, OfferedForAdoption is firing and giving him the IsNotANewlyRecruitedGeneral trait before his TurnEnd trigger fires (so this adoption 'offer' must be happening as he's created) and that's enough to break the concept.

Remove the OfferedForAdoption trigger and it works. The problem now becomes that anybody else who is offered for adoption will also be seen as a recruited general by the RecruitedGeneral_trigger1 trigger, if they don't already have the IsNotANewlyRecruitedGeneral trait.

Are they actually in the settlement at the time of adoption offers? No idea. If not then that should be fine.

**Titus le Chmakus** · June 06, 2018, 08:17 AM

And if it does, it should be fine too !!! Shall I remember you that I wanted to have it applied to anybody newly recruited !!!

In fact, what I do not want is that it happens more than once ...

Do you think I could remove everything but the first

Code:

Trigger IsNotANewlyRecruitedGeneral_trigger1
    WhenToTest CharacterTurnStart

    Condition Trait IsNotANewlyRecruitedGeneral = 0

    Affects IsNotANewlyRecruitedGeneral 1 Chance 100

So that every character that is not newly created do not get the trait ...? And all newly recruited all get the trait !

EDIT : after testing, it seems to work as intented ! It even works for adopted Generals. Got an Offer For Adoption, just at the very same time as when I recruited a General. The General I had recruited poped up with the traits already included but for the one I have had to accept the Adoption, I got the traits on the next turn, having kept him inside the city with the relevant buildings.

Cheers mate (cannot spread rep)

**DanishTerror** · June 06, 2018, 11:54 AM

Glad to see you got it working!

**Titus le Chmakus** · June 07, 2018, 02:26 AM

Yeah that could help people to give traits to recruited generals ! Otherwise, they start with almost nothing ...

Withwnar, to answer your question, I think generals deserve an education, no matter where they come from ! I mean, it is logical, when you recruit a general, that this guy has had the opportunity to go to school/university. But it is the same when you adopt a general or when you marry one of your girls ... Would you choose a morron as candidate for adoption/marriage ?

I mean my mod is a fantasy world where some of the factions have access to high levels of education. So these factions who have universities will have the traits. Others that have no education don't even have the tech tree of schools ... Do you find my explanation coherent ?

**Withwnar** · June 07, 2018, 04:15 AM

Originally Posted by Titus le Chmakus

Withwnar, to answer your question...

What question was that? This...?

Are they actually in the settlement at the time of adoption offers?

That wasn't a question about how it would impact your is-building-present concept. It's a question of whether the is-recruited-general trick is broken by adoptions; that 'normal' adoptions (of non-recruited-generals) are in fact seen as recruited generals by the RecruitedGeneral_trigger1 trigger. i.e. For anybody wishing to use this technique for recruited generals for any purpose.

Anyway, to answer your question, yes that's pretty much what I said earlier. That for any general coming into the faction other than by ComesOfAge he'd have a % chance of already being educated. What that chance is is up to you. If you think it's 100% then fine.

**selv** · June 07, 2018, 11:51 AM

I am having a little doubt about this, because I can't be sure that all those traits aren't given by other triggers I have no time to search for right now, but it seem that named characters spawned specificaly by the faction_emerge command might benefit from the OfferedForAdoption triggers as well. I already noticed before but I wasn't really paying attention.

Will try soon with a new boggus trait triggered only by adoption, once I will have finished something else. It might even apply to normally spawned scripted characters if they don't have a set of traits defined within the script? I don't really care for now, but you never know.

**DanishTerror** · June 07, 2018, 02:31 PM

Almost all of those traits are triggered either through the FatherTrait condition in EDCT or finishing a building while in settlement.

Thread: OfferedForMarriage event

Thread Tools

Search Thread

Display

Hybrid View

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Re: OfferedForMarriage event

Posting Permissions