General Portrait in Custom Battle Permissions overrides Unit Cards?

[Cyclone Jack]

I've been trying to get custom portraits working on my Lords and Heroes; all of my other units are working fine. Oddly, I had three units that had the correct unit cards showing up, but on the battlefield they did not have the Lord or Hero unit selection markers (the star and circle), but instead had the standard troop marker (the arrow). I found that I had skipped over the general_portrait field in the units_custom_battle_permissions table. Once I added it in, they had the correct selection markers, but were now defaulting to the standard unit card (either a great shaman or a big boss, since those are the only grn ones available). So now I know that this field must be filled in to get the correct selection markers, but these seem to override the unit_card defined in unit_variants.

So I copy over some .pngs into the ui/portraits/portholes/wh_main_grn_greenskins/ folder, set the pointer, export, build, launch the game. The porthole portrait is showing up correctly (if a little stretched), I get the Lord/Hero selection marker, but now my unit card is a Goblin Spearmen unit? The only other table linked in units_custom_battle_permissions is agent_uniforms, and that just links to variants (and I have agent_uniforms filled in correctly).

How does the general_portrait field tie into the Goblin Spearmen unit card? I guess a better question would be, why is the Lord/Hero selection marker tied to a porthole portrait that is only used on a loading screen for a few seconds? And why does that override the unit card already defined? Blaaargh!

[Cyclone Jack]

Figured this one out.

In units_custom_battle_permissions you set the general_portrait, eg: ui/portraits/portholes/wh_main_grn_greenskins/wh_main_grn_gitilla_0.png

What it doesn't tell you is that you also need a unit card in ui/portraits/units, using the exact same filename. The standard path for unit cards is ui/units/icons, which is why this one threw me for a loop.