Buff and Shine 2.4: New Factions, Changed Recruitment and more

[WeekendGeneral]

I just take a look and I love it, I will play in these days. I have 2,4,2 Broken.

When will be the version 1.0 of this submod?
Can I give some Advices regarding what could be added?

1.0 will be out hopefully before the new year.

You can always give suggestions, I can't promise I'll always adopt them though. I'm increasing short on time unfortunately

[ZSV]

Pay attention to the left parenthesis:

(Alexios}Alexios Komnenos
(AlexiosK}Alexios Megas Komnenos

[Iskar]

I'm experiencing a CTD at the end of turn 12/beginning of turn 13, playing ERE. The logs are inconclusive (just mentioning an "unspecified error" in no significant temporal vicinity to any other log entries) and I cannot see any obvious reason for this. As far as I checked there are no events/scripts for that turn.

Any idea what may be causing it?

[vsivak]

The same problem as the problem mentioned by ZSV is in the file export_vnvs.txt, line (GreatImam_gain_desc)This man's knowledge of legal codes and piety have elevated him to this position.

Regarding your problem Iskar, please post your log. I have suspicion that it can be caused by the mistake in text files and the log can help me find the exact cause. Please try the attached txt files with the fixed entries found by me and ZSV (don't forget to delete the associated bin files). Maybe it will help.

Best regards

EDIT: I played 30 turns with ERE with attached files and I had no CTD. And i found another bug. In campaign script in this part there are wrong coordinates. These coordinates are in Caspian sea. The correct ones are x 240, y 139

monitor_event FactionTurnStart FactionType fars
    if I_LocalFaction fars
        terminate_monitor
    end_if
    if I_NumberOfSettlements fars <= 2
    and I_TurnNumber >= 5
        spawn_army
            faction fars
            character    random_name, named character, age 27, x 139, y 240
            traits LoyaltyStarter 1, GoodCommander 2, ReligionStarter 1, BattleChivalry 1, Loyal 3
            unit        bodyguard seljuks                exp 6 armour 0 weapon_lvl 0
            unit        ghulams elite                exp 5 armour 0 weapon_lvl 0
            unit        ghulams elite ha                exp 5 armour 0 weapon_lvl 0
            unit        aor iraq nobles                exp 4 armour 0 weapon_lvl 0
            unit        aux arab swordsmen                exp 4 armour 0 weapon_lvl 0
            unit        aux arab swordsmen                exp 4 armour 0 weapon_lvl 0
            unit        turkoman heavy bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman medium bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman light bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman heavy macemen                exp 4 armour 0 weapon_lvl 0
            unit        turkoman medium swordsmen                exp 3 armour 0 weapon_lvl 0
            unit        turkoman medium swordsmen                exp 3 armour 0 weapon_lvl 0
            unit        turkoman heavy bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman medium bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman light bowman                exp 4 armour 0 weapon_lvl 0
            unit        turkoman heavy macemen                exp 4 armour 0 weapon_lvl 0
            unit        turkoman medium swordsmen                exp 3 armour 0 weapon_lvl 0
            unit        turkoman medium swordsmen                exp 3 armour 0 weapon_lvl 0            
    end

[Iskar]

I tried the attached files, but to no avail.

I think it does not have anything to do with round 12/13 in particular, rather that my game has happened to run into a specific constellation that causes the error. I have attached the log and the zipped save. Maybe you can find the cause of the CTD. Thanks for your efforts
system.log.txtQuicksave.rar

[vsivak]

Ok Iskar, I found the bug. Please find attached the fixed historic_events.txt. Put it to text folder and delete the bin file.

http://www.mediafire.com/file/iohaqt...ric_events.txt


For everybody else who wants to begin a new campaign I attach my bugfixer which corrects all the so far mentioned bugs and the bugs I found. Requires a new game.

https://www.mediafire.com/?j1w9i0ggn3sm61d

For people who has got CTD and want to continue their campaign, try to use the Text folder from the second link, it may help.

Best regards

[Iskar]

Excellent, that worked splendidly. Finally I can continue my game. Thanks a lot

[vsivak]

Glad to help. If you find any bugs or any imbalances please post them so the game can be further improved. Thank you

[Iskar]

There is in fact one thing, in export_descr_buildings.txt.

The small orthodox church has as building condition "requires factions { greek, african, saxons, } AND event_counter khitan_nestorian 1"
which makes it so that all other orthodox factions can only build the smal church (and thus any non-pre-built church) if the Karakhitai accept Nestorianism.
The line should be corrected to:
"requires factions { greek, african, } OR factions { saxons, } AND event_counter khitan_nestorian 1"

---------------------

I just noticed that the military infrastructure buildings (droungos, tourma, thema, pronoia for the byzantines, for example) still have the "hidden resource recruit_<faction>" requirement for recruitment of troops. Why would one spend thousands of florins and wait dozens of rounds to establish military infrastructure if one still cannot recruit one's own troops outside of one's core regions?

I'm gonna remove said requirements for my game and I would suggest to reassess this in general.

[Roger II]

Is this Mod a stand alone or does it need to be copied over 2.4.2?

[vsivak]

Iskar,

You found another bug. The problem is that WeekendGeneral used condition "and not hidden_resource" for the recruitment of units outside your home regions. But this condition doesn't work (for more info check http://www.twcenter.net/forums/showt...ngs-themselves or http://www.twcenter.net/forums/showthread.php?705939 or http://www.twcenter.net/forums/showt...esource-X-quot).
My quick solution is that I deleted these conditions. This leads to a bit higher recruitment rates in your home regions because this way the game increments the rate of the recruit pool with "and hidden_resource" by the recruit pool of the lines that don't have any hidden_resource requirements.
I updated my Bugfixer with this fix, orthodox church fix and fixes of another bugs I found. Thank you Iskar.

Roger II
Instal 2.4.2 then BUFF AND SHINE 0.95 and then I would advise you to use my bugfixer.

Here is the new link for Bugfixer https://www.mediafire.com/?j1w9i0ggn3sm61d

[WeekendGeneral]

Vsivak, fantastic as always the changes work very well. I unfortunately was unaware of the bug I fully admit that I am still very much a novice at modding and often feel that I am bumbling round in the dark when it comes to getting it all to work!

Thanks Iskar, for finding the bugs please let me know of any others you find.

I'll upload the bugfixer into the main download shortly with some minor tweaks updates.

[HuoShan]

Vsivak, fantastic as always the changes work very well. I unfortunately was unaware of the bug I fully admit that I am still very much a novice at modding and often feel that I am bumbling round in the dark when it comes to getting it all to work!

Thanks Iskar, for finding the bugs please let me know of any others you find.

I'll upload the bugfixer into the main download shortly with some minor tweaks updates.

Great！Are you still working in 1.0 update？

[WeekendGeneral]

Iskar,

You found another bug. The problem is that WeekendGeneral used condition "and not hidden_resource" for the recruitment of units outside your home regions. But this condition doesn't work (for more info check http://www.twcenter.net/forums/showt...ngs-themselves or http://www.twcenter.net/forums/showthread.php?705939 or http://www.twcenter.net/forums/showt...esource-X-quot).
My quick solution is that I deleted these conditions. This leads to a bit higher recruitment rates in your home regions because this way the game increments the rate of the recruit pool with "and hidden_resource" by the recruit pool of the lines that don't have any hidden_resource requirements.
I updated my Bugfixer with this fix, orthodox church fix and fixes of another bugs I found. Thank you Iskar.

Roger II
Instal 2.4.2 then BUFF AND SHINE 0.95 and then I would advise you to use my bugfixer.

Here is the new link for Bugfixer https://www.mediafire.com/?j1w9i0ggn3sm61d

The new bugfix is causing a crash turn 1 every time now :S

The edits to export_descr_buildings is what is causing the crash

crashlog https://www.mediafire.com/?cc5rrokqojg35fc

[vsivak]

What a bugfixer. I will take a look at it today.

[Iskar]

Crashes due to export_descr_buildings often relate to rather small things, like a missing or redundant space left somewhere. Try using advanced editors like Notepad++ that do not mess up the structure like Editor does.

[WeekendGeneral]

What a bugfixer. I will take a look at it today.

Fixed it, I believe this issue was that there were to many recruitable units with the change, as such scrapped the hidden_resource requirements for troops buildings. Just putting together your bugfix with my other edits and will upload it all.

[vsivak]

Fixed it, I believe this issue was that there were to many recruitable units with the change, as such scrapped the hidden_resource requirements for troops buildings. Just putting together your bugfix with my other edits and will upload it all.

I read somewhere that there is a limit how many recruit pools one building have but I am not sure where I read it or what is the number. Did you delete some recruit pools or how did you fix this issue? I was afraid that this can happen and I didnt have much time to test it.

[WeekendGeneral]

I read somewhere that there is a limit how many recruit pools one building have but I am not sure where I read it or what is the number. Did you delete some recruit pools or how did you fix this issue? I was afraid that this can happen and I didnt have much time to test it.

Yes that's what I read and in response I streamlined many of the recruit pools and the issue seems fixed.

No stress, we all have lives that prevent us from testing everything thoroughly. I was just lucky enough today to be given the day off to test it all.

Currently uploading the update though I'm currently in rural Australia for work and the internet is at dial up speeds so may take a while.

[vsivak]

Yes that's what I read and in response I streamlined many of the recruit pools and the issue seems fixed.

No stress, we all have lives that prevent us from testing everything thoroughly. I was just lucky enough today to be given the day off to test it all.

Currently uploading the update though I'm currently in rural Australia for work and the internet is at dial up speeds so may take a while.

I found the exact cause of the problem. It is the building cuman3 that has got 33 active recruit pools if cumans are played by AI. If you delete one it is OK . In Sarkel_Region the Cumans have got from the start the building cuman2 and they are immediately trying to build cuman3 what leads to CTD during their turn. If the player is playing as cumans number of active recruit_pools is lower than 33 because you used "and event_counter ai_is_kyp 1" for several recruit pools. So max number of recruit pools we can use for one building in one region is 32 and we have to check every building in EDB not to have more. And buildings like barracks should be OK because you used a lot of hidden resources for different regions.

I think the system as you meant is brilliant and I am for retaining the different recruit pools in home regions and other regions. If you used more than 32 pools for any building I would rather delete the ones made especially for AI (and this way we can also reduce the spam stack a bit).

Best regards