2.05a trigger bug in ICERating for Coming of Age

[myarta]

Hey guys,

I've noticed that my Romani sons coming of age all seem to be Sharp/Uncharismatic/Languorous. So I checked my family tree:

It's literally every single one, except for one who is D/U/L, and I'm on turn 193. Adoptees (clearly marked thanks to the "Adopted into gens...") are whatever ones I vetted as good, but every single coming-of-age son has S/U/L except maybe that one that is D/U/L and this is across several different fathers.

It looks like the random birth triggers use NaturalIntelligence, NaturalCharisma, and NaturalEnergy to assign states (lines 25416 - 25493):

Since it's working for OfferedForMarriage, OfferedForAdoption, and LesserGeneralOfferedForAdoption, I suspect that the Natural* variables for CharacterComesOfAge aren't generous enough compared to OfferedFor*.

Natural* is on a 5 point scale, where the cutoff is 3 points for S/C/V.

The initialization is a little weird:

; Section 1.1.1 - Primary Triggers - ICE Rating - CharacterComesOfAge
;------------------------------------------
Trigger random_birth_ICE_Trigger_Initialize1
  WhenToTest CharacterComesOfAge


  Condition Trait NaturalIntelligence < 1


  Affects NaturalIntelligence  1  Chance  100
  Affects NaturalCharisma  1  Chance  100
  Affects NaturalEnergy  1  Chance  100
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50


;------------------------------------------
Trigger random_birth_ICE_Trigger_Initialize2
  WhenToTest CharacterComesOfAge


  Condition Trait NaturalCharisma < 1


  Affects NaturalCharisma  1  Chance  100
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50

The +1 to NaturalCharisma in the first trigger at 100% makes the second trigger never activate, so you're stuck with an average of 3 points of intelligence (explaining the Sharp) (100% + 4x 50% = 300%). Then you only get 1 point of Charisma and 1 point of Energy from the first trigger, thus always U and L. My one guy who was dull must have failed some of his 50s.

These values are added to by father traits, but not enough to compensate for losing the firing of the Charisma and Energy trigger.

So I guess what I would do is split it into three triggers, one each for Intelligence, Charisma, and Energy with a < 1 check and the 100 base and 4x 50 rolls.

[QuintusSertorius]

We've had trouble with this for a while, and no one with sufficient focus to fix it. While I do mechanics more broadly, traits are a rather specialised area that I only have the most passing familiarity and expertise in. So this is a timely intervention.

How would you split it into three triggers? That sounds to me like a good solution.

[myarta]

Well, I just had a CTD loading my save game after modifying this file, but I reverted to the 2.05a EDT and it still is crashing, so it may just be my savegame in general that's borked for some reason. But you would do:

; Section 1.1.1 - Primary Triggers - ICE Rating - CharacterComesOfAge
;------------------------------------------
Trigger random_birth_ICE_Trigger_Initialize1
  WhenToTest CharacterComesOfAge


  Condition Trait NaturalIntelligence < 1


  Affects NaturalIntelligence  1  Chance  100
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50
  Affects NaturalIntelligence  1  Chance  50


;------------------------------------------
Trigger random_birth_ICE_Trigger_Initialize2
  WhenToTest CharacterComesOfAge


  Condition Trait NaturalCharisma < 1


  Affects NaturalCharisma  1  Chance  100
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50
  Affects NaturalCharisma  1  Chance  50


;------------------------------------------
Trigger random_birth_ICE_Trigger_Initialize3
  WhenToTest CharacterComesOfAge


  Condition Trait NaturalEnergy < 1


  Affects NaturalEnergy  1  Chance  100
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50
  Affects NaturalEnergy  1  Chance  50

So each trait has its own trigger. I'd have to find a faction with a son that is coming of age on the first winter (or tweak one in descr_strat just for testing) to see if it works. I nuked my install and am doing a fresh one to try to recover from the aforementioned CTD.

[QuintusSertorius]

Any change you make to the EDCT won't be savegame compatible anyway - same as with any of the other fundamental files like the EDU, EDB and so on. Before re-installing, see if it works with a new campaign.


EDIT: Can you have three random_birth_ICE_Trigger_Initializen triggers? All the others in that section and the STL section after all have only two.

[V.T. Marvin]

The "Condition Trait NaturalIntelligence < 1" condition is superfluous - the trigger fires only once - just as the event happens only once per character. I dunno what I was thinking when adding there and why. Corrected in the dev build. Sorry for the mess.

[myarta]

I'm not pro enough to know whether there is a cap on trigger counts in general or for coming of age in particular, but VT makes a good point that you don't need a check at all since it's guaranteed to fire just once.