Marian trait bug (yes I know it's not Autumn) in 2.05a

[myarta]

Hey guys,

I see you have the Reformator trait in, though the code isn't complete yet to use this.

I discovered this when a character of mine got Potential Reformator PLUS Reformator all on the same turn! Here is the code:

;------------------------------------------
Trigger General_PotentialReformator_Marian_Consul
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_NumberOfSettlements f_rome > 40
        and Trait ICERating > 7
        and Trait Popularis > 0
        and Attribute Piety > 2
        and Attribute Command > 2
        and Trait Consul > 0
        and I_EventCounter ecMarianEra < 1


  Affects Reformator  1  Chance  100


;------------------------------------------
Trigger General_PotentialReformator_Marian_ExConsul
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_NumberOfSettlements f_rome > 40
        and Trait ICERating > 7
        and Trait Popularis > 0
        and Attribute Piety > 2
        and Attribute Command > 2
        and Trait RomanRank = 5
        and I_EventCounter ecMarianEra < 1
        and I_EventCounter ecAugustanEra < 1


  Affects Reformator  1  Chance  100

He is currently a "Proconsul" [Consul = 3], so he fired the first trigger, plus he has already completed a full 3 year cycle of Consul/Proconsul in the past, so his hidden RomanRank is already 5.

The second trigger should add "and Trait Reformator < 1" so that both being a current consul and a former consul doesn't make Potential Reformator upgrade right into Reformator.

Similarly, I don't see any reason why the first trigger wouldn't just fire every turn and keep upping your Reformator score. It should also have "and Trait Reformator < 1" otherwise someone on their first term as consul will go from Potential to actual Reformator on the very next turn. I realize you don't actually do anything based on this yet, since Marian reforms aren't done yet (need a hand?), but I wanted to make the report anyway since when you DO use it, you won't want Potential Reformators jumping right to actual ones immediately/in one turn.


Fixed:

;------------------------------------------
Trigger General_PotentialReformator_Marian_Consul
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_NumberOfSettlements f_rome > 40
        and Trait ICERating > 7
        and Trait Popularis > 0
        and Attribute Piety > 2
        and Attribute Command > 2
        and Trait Consul > 0
        and I_EventCounter ecMarianEra < 1
        and Trait Reformator < 1


  Affects Reformator  1  Chance  100


;------------------------------------------
Trigger General_PotentialReformator_Marian_ExConsul
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_NumberOfSettlements f_rome > 40
        and Trait ICERating > 7
        and Trait Popularis > 0
        and Attribute Piety > 2
        and Attribute Command > 2
        and Trait RomanRank = 5
        and I_EventCounter ecMarianEra < 1
        and I_EventCounter ecAugustanEra < 1
        and Trait Reformator < 1


  Affects Reformator  1  Chance  100

[QuintusSertorius]

Good spot - fixed for 2.05b (and in the dev build). Though we've yet to decide how the reform is going to be triggered.