Roman Military Tribute triggers

**myarta** · August 06, 2015, 09:10 PM

Hey guys,

Can someone help me understand how these triggers work, please? BTW this is 2.04a.

First, here's the info for the RomanMilitaryService trait:

Code:

Trait RomanMilitaryService
    Characters family
    Hidden


    Level Military_Service
         Description Hidden_desc
         EffectsDescription Hidden_effects_desc
         Threshold  10


    Level Half_Service
         Description Hidden_desc
         EffectsDescription Hidden_effects_desc
         Threshold  20


    Level Full_Service
         Description Hidden_desc
         EffectsDescription Hidden_effects_desc
         Threshold  30
         
         Effect Command  1
         Effect Authority  1

Your points in this trait are ticked up 1 per turn when you end the turn outside of a settlement. So it would take 10 turns to reach the first level, 20 to reach the second, and 30 to achieve RomanMilitaryService = 3.

Now here are the triggers for using that trait for attaining the rank of Military Tribune:

Code:

;------------------------------------------
Trigger Elected_MilitaryTribune1
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_EventCounter ecWinter = 1
        and Trait RomanRank = 1
        and Trait MilitaryTribune < 1
        and Trait RomanMilitaryService > 1


  Affects MilitaryTribune  1  Chance  10


;------------------------------------------
Trigger Elected_MilitaryTribune2
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_EventCounter ecWinter = 1
        and Trait RomanRank = 1
        and Trait MilitaryTribune < 1
        and Trait RomanMilitaryService > 2


  Affects MilitaryTribune  1  Chance  25


;------------------------------------------
Trigger Elected_MilitaryTribune3
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_EventCounter ecWinter = 1
        and Trait RomanRank = 1
        and Trait MilitaryTribune < 1
        and Trait RomanMilitaryService = 3


  Affects MilitaryTribune  1  Chance  100

My question is, does 'and Trait RomanMilitaryService > 1' find people who have 11 points in RomanMilitaryService, or does it only start evaluating true for them when they've reached 20 points and thus are at the second level [Half_Service]?

If it's the latter, then isn't Elected_MilitaryTribune2 a useless trigger, since RomanMilitaryService > 2 would make you have a 25% chance of getting the office once you reach the 3rd rank, immediately followed by a 100% chance of getting the office now that you're at the 3rd rank thanks to Elected_MilitaryTribune3?

ETA: I meant to title this Roman Military TribUNE, but I'm a dork and I can't edit it now.

**Poppis** · August 07, 2015, 03:09 AM

Yeah this a reported bug. Hopefully it'll be fixed in the autumn update.

**myarta** · August 07, 2015, 03:40 AM

Yeah? Okay.

Should be able to just change the first trigger to > 0, the second to > 1 and the third to > 2, for RomanMilitaryService then.

With the config file settings, it will pick that up, save game compatible.

I'll give that a shot.

**myarta** · October 11, 2015, 11:41 PM

Looks like this is still up in 2.05a. Can we toss it into the next one since it's just two numbers?

Fixed code:

Code:

;------------------------------------------
Trigger Elected_MilitaryTribune1
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_EventCounter ecWinter = 1
        and Trait RomanRank = 1
        and Trait MilitaryTribune < 1
        and Trait RomanMilitaryService > 0


  Affects MilitaryTribune  1  Chance  10


;------------------------------------------
Trigger Elected_MilitaryTribune2
  WhenToTest CharacterTurnEnd


  Condition FactionType f_rome
        and I_EventCounter ecWinter = 1
        and Trait RomanRank = 1
        and Trait MilitaryTribune < 1
        and Trait RomanMilitaryService > 1


  Affects MilitaryTribune  1  Chance  25

Elected_MilitaryTribune1's RomanMilitaryService check should go from > 1 to > 0 as depicted
Elected_MilitaryTribune2's RomanMilitaryService check should go from > 2 to > 1 as depicted
Elected_MilitaryTribune3's RomanMilitaryService check = 3 can stay as-is (omitted paste of unchanged trigger)

To see this issue, consider:

Currently, if RomanMilitaryService = 0 (< 10 turns outside of settlements), your chance of getting MilitaryTribune is 0%. This fix doesn't change that.
But if RomanMilitaryService = 1 ( 10-19 turns outside of settlements), your chance of MilitaryTribune is still 0% in the current code because you don't fire the first trigger
Then when RomanMilitaryService = 2, your chance goes up to 10% (you fire the first trigger)
Then when RomanMilitaryService = 3, your chance goes up to 135% (you fire all three triggers because trigger 2 and trigger 3 activate at the same time, since > 2 and = 3 are the same in this context)

It looks like the intent was for each of the three levels of RomanMilitaryService, to get a 10%, 35% [10% + 25%], 100% chance of getting MT. Instead of 0, 10, 100 with the 25% trigger being useless.

Sorry if that's too repetitive, I wanted to make it clear.