I may have found the bug that keeps generals from getting command stars

[Rumpole141]

In export_descr_character_traits.txt there is a multiphase set of triggers for determining whether a general improves in the "tactician" or "leader" line of traits.

Phase 2 looks at the difficulty and outcome of the battle

; Phase 2 - Set New Battle Results
;------------------------------------------
; 1-9 Battle points from Crushing Defeat to Heroic Victory
; +0, +4, +8, +12 for calculated difficulty of the battle
; +1 for Large Battles

For example:
;------------------------------------------
Trigger Standard_Battle_Narrow_Defeat
WhenToTest PostBattle

Condition IsGeneral
and not WonBattle
and BattleSuccess = close

Affects RecentDefeat 1 Chance 100
Affects BattlePoints 4 Chance 100

Trigger Siege_Battle_Defender_Hard
WhenToTest PostBattle

Condition not WasAttacker
and IsGeneral
and I_ConflictType Siege
and BattleOdds < 0.6
and not BattleOdds < 0.4

Affects RecentBattleDifficulty 3 Chance 100
Affects BattlePoints 8 Chance 100

If you win, the value of BattlePoints will range from 6 to 25.

In Phase 3, the general may learn from the battle:
Trigger Very_High_BattlePoints_High_Energy
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints = 5
and Trait NaturalEnergy = 5

Affects EnergeticCommanderLearns 1 Chance 95

The result may be to make the general a better tactician:
Trigger BecomesBetterTactician_Avg_Int
WhenToTest PostBattle

Condition IsGeneral
and Trait EnergeticCommanderLearns > 0
and Trait NaturalIntelligence = 3
and Trait GoodTactician < 3

Affects BecameBetterTactician 1 Chance 80

This leads to an increase in the GoodTactician or GoodLeader trait and grants a command star.
Trigger GoodTactician_Incremented_good
WhenToTest PostBattle

Condition IsGeneral
and Trait BecameBetterTactician > 0
and Trait BadTactician < 1

Affects GoodTactician 1 Chance 100

The problem is that the values of BattlePoints that lead to improvement are 1 through 5, which arise only through losing or drawing an easy battle.

A crude fix, which seems to work, is to convert BattlePoints from to 0-25 scale to the 1-5 scale at the end of phase 2, e.g.
Trigger EB_05_Convert_Battle_Points1
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints < 5

Affects BattlePoints 1 Chance 100

;------------------------------------------
Trigger EB_06_Convert_Battle_Points2
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints < 9

Affects BattlePoints 2 Chance 100

;------------------------------------------
Trigger EB_07_Convert_Battle_Points3
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints < 13

Affects BattlePoints 3 Chance 100

;------------------------------------------
Trigger EB_08_Convert_Battle_Points4
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints < 17

Affects BattlePoints 4 Chance 100

;------------------------------------------
Trigger EB_09_Convert_Battle_Points5
WhenToTest PostBattle

Condition IsGeneral
and Trait BattlePoints > 16

Affects BattlePoints 5 Chance 100

I had to guess at a conversion table, but there must be someone who knows the intended conversion.

Whether or not command stars have much effect, it makes the game more interesting if generals who win hard battles are rewarded with command stars.

[Dago Red]

Agreed. It's a visual measure of that man's battle experience. (It must also have an effect on auto-resolving, and the way things are now, that is really the only option for sieges much of the time). I never saw a single command star until downloading this submod compilation which gives them when a character earns the combat experience traits.

[Thuycidides]

Agreed. It's a visual measure of that man's battle experience. (It must also have an effect on auto-resolving, and the way things are now, that is really the only option for sieges much of the time). I never saw a single command star until downloading this submod compilation which gives them when a character earns the combat experience traits.

The only way to get command stars is to fight battles with very unfavorable odds. I installed that mod compilation and I like it much better.

[Antiokhos Euergetes]

That is good to know, even if I do not really understand. I still would e some of my characters, to develop some positive traits though, as well as command stars. Especially the future Basileos

[Rumpole141]

I misunderstood the way traits work. There are levels for battle points.

Is it really true that

Affects BattlePoints 4

raises the raw number by 4

while

BattlePoints = 4

tests whether the level is 4?