GovernorBuildingCompleted trait triggers don't appear to work?

[slingerblitz]

I'm running SS6.4 with HURB. Noticed that my governors don't seem to be gaining positive farming/mining traits despite being in settlements as farm/mines are finished. Updated the associated lines in export_descr_character_traits.txt to:

Trigger building_farms
WhenToTest GovernorBuildingCompleted


Condition SettlementBuildingFinished >= farms


Affects GoodFarmer 2 Chance 100


;------------------------------------------
Trigger building_mines_city
WhenToTest GovernorBuildingCompleted


Condition SettlementBuildingFinished >= mines


Affects GoodMiner 1 Chance 100

This should have guaranteed gaining levels in the GoodFarmer/GoodMiner traits when finishing the buildings, but again, the governors don't gain the traits.

Also consider:
-Granting the traits through the console using "give_trait this GoodXxxx" works just fine.
-Other GovernorBuildingCompleted triggers also aren't working, but OccupySettlement triggers and others are tested to work fine.
-There's no conflict in trigger naming.

So I'm a bit stumped on what could be causing this. Any ideas?

[gsthoed]

This should have guaranteed gaining levels in the GoodFarmer/GoodMiner traits when finishing the buildings, but again, the governors don't gain the traits.

The thresholds for acquiring the first level of GoodFarmer and GoodMiner are 3 and 2 respectively. So, if, for example, you want your general with no points in GoodMiner acquire the first level of GoodMiner, with this trigger of yours he must build 2 Buildings >= mines.

[slingerblitz]

Ahh, Threshold. Good catch!
I'd forgotten about that.