In export_descr_character traits.txt:
- Repeated triggers:
Trigger Battle_General_Took_Hits and Trigger battle1 are exactly the same.
Trigger battle_coward3 and Trigger battle7: The only difference is the chance in the affect line. If this was intended, shouldn't one of these triggers be ommitted and the other be something like the one below?
Spoiler Alert, click show to read:Trigger battle_coward3
WhenToTest BattleGeneralRouted
Affects Coward 1 Chance 25
Affects Coward 1 Chance 33
- "AI Bad Traits Remove" section:
Trigger ai_bad_traits_barrenwo, Trigger ai_bad_traits_horridwo,Trigger ai_bad_traits_bitchwo
The traits that are affected by these triggers are only for generals. However, these triggers contain the condition "AgentType = princess", which I think should be removed.
- Trigger battle_coward2
Spoiler Alert, click show to read:Trigger battle_coward2
WhenToTest PostBattle
Condition not GeneralFoughtInCombat
and PercentageEnemyKilled = 0
Affects Coward 1 Chance 10
I think a general does not deserve of being affected from this trigger if:
a) The enemy retreated without fighting. One possible solution to deal with this is provided by adding a condition "notWonBattle".
b) The battle odds were overwhelmingly against him, so he retreated to "fight another day". This can also be said for Trigger battle_coward1. One possible solution to deal with this is is provided by adding a condition "and BattleOdds < 2.1" or like.Thanks man will add these to thr bugfix compilation
Regarding the Coward triggers
BattleOdds < 2.1 is pretty much any battle, the 2.1 value is the product of the affected general's army strength divided by his opponent's army strength. So < 2.1 goes from "outnumbering" his foe 2 to 1 to being completely overwhelmed. If you aim for getting the coward roll only if odds were against him then it should be < 1.0 or lower.
However I think they could stay as is, these are the middle ages, commanders are supposed to be warriors themselves and not just tacticians/strategists that give orders or at least that's what was expected of them, also 10% is very low chance of getting the coward trait.
For differentiating battle7 from coward3 maybe we could add "and BattleOdds > 0.9", this means that if the general was facing an even odd and yet was routed he'll gets the roll for coward trait with 33% chance
As for Trigger Battle_General_Took_Hits and Trigger battle1 maybe leave the 1st as is and change battle1
Code:Trigger battle1 WhenToTest PostBattle Condition GeneralFoughtInCombat Affects Brave 1 Chance 10It was my mistake; I meant adding something like Battleodds < 0.75 or Battleodds < 0.51 for that case.
Regarding the "warrior commander" who fights all battles, I feel that this case is covered by trigger battle_coward1, where the general -whether his army was retreating or not- gave battle and lost without risking himself; in this case, yes, I accept he should be regarded as a coward.
Definetely, retreating "uncowardly" was the norm for armies that were applying hit-and-run tactics, like raiding armies or armies trying to distract a major enemy force (for example, when defending own territory and waiting for reinforcements or gathering forces). But, I know, this discussion is not suitable for this thread.
Besides, there is also the Trigger battle3Chivalry1_notchaserouters
Code:Trigger battle3Chivalry1_notchaserouters WhenToTest PostBattle Condition WonBattle and BattleSuccess >= average and PercentageEnemyKilled < 10 and not GeneralFoughtInCombat and IsGeneral and BattleOdds < 0.95 and not Trait BattleDread > 0 Affects BattleChivalry 1 Chance 33So, postbattle, a general -if he didn't fought in combat and no enemy was killed- can acquire both BattleChivalry and Coward points, which seems, at least to me, quite contradicting.Code:Trigger battle_coward2 WhenToTest PostBattle Condition not GeneralFoughtInCombat and PercentageEnemyKilled = 0 Affects Coward 1 Chance 10
This cowardly acquiring of chivalry (and being chivalriously coward) did happened once for a general of mine -it was a siege attack, I had only the general and his bodyguards, the defenders lacked cavalry, I lured them out and far from their settlement and then ran to the castle center, the defenders didn't manage to keep up as they got exhausted by chasing my cavalry unit, so I kept control of the square till time ran out; I found it hilarious too.
So, I believe that, for the trigger battle_coward2, both conditions "notWonBattle" and "Battleodds < 0.51" or like should be added.
I like that! I had commented out one of these triggers for my own play, but now I'll do just as you said. However, the fix I suggested in my previous post has exactly the same effects as the inclusion of both triggers as they are but "consumes less CPU cycles" (sorry, no more appropriate phrase came in my mind).
I like that too. I feel, however, that this case is covered in Trigger battle2a, where the general not only involved in combat, which could have happened even against his own will, but stayed and made some kills too.
I prefer this trigger being commented out, as with so many triggers affecting trait brave, generals are getting too brave for my taste. Of course, this is not any kind of "demand" for the bugfix compilation [by the way, it's a great work, I 'd like to spread reputation(?), but I don't know how]; it's not critical.
Code:Trigger battle2a WhenToTest PostBattle Condition GeneralNumKillsInBattle > 6 Affects Brave 1 Chance 15So what you guys think?But what about the scenario where a general purposely stay behind while his men win the battle for him, wouldn't he be branded as a coward then?
anyway is just 1 point of 2 needed to gain the trait which can be easily reverted by doing some courageous feats in the next battles...and about the cowardly chivalrous, why not? same as there could be dreadfully brave.





Reply With Quote





