SSHIP - General Discussion

[Ensyvtre]

Are the traits Generous and Miserly working as intended? I noticed I had some governors gain the third rank in a short manner of time. This made me curious to find out what triggered it and I found this

Trait info for Generous:

Spoiler Alert, click show to read: 

Trait Generous
Characters family

Level Generosity1
Description Generosity1_desc
EffectsDescription Generosity1_effects_desc
GainMessage Generosity1_gain_desc
Threshold 1

Effect TaxCollection -10
Effect Squalor -1

Level Generosity2
Description Generosity2_desc
EffectsDescription Generosity2_effects_desc
GainMessage Generosity2_gain_desc
Threshold 3

Effect TaxCollection -20
Effect Squalor -2

Level Generosity3
Description Generosity3_desc
EffectsDescription Generosity3_effects_desc
GainMessage Generosity3_gain_desc
Threshold 6

Effect TaxCollection -30
Effect Squalor -1

And Miserly:

Spoiler Alert, click show to read: 

Trait Miserly
Characters family

Level Miserly1
Description Miserly1_desc
EffectsDescription Miserly1_effects_desc
GainMessage Miserly1_gain_desc
Threshold 1

Effect TaxCollection 10
Effect Unrest 1

Level Miserly2
Description Miserly2_desc
EffectsDescription Miserly2_effects_desc
GainMessage Miserly2_gain_desc
Threshold 3

Effect TaxCollection 20
Effect Unrest 2

Level Miserly3
Description Miserly3_desc
EffectsDescription Miserly3_effects_desc
GainMessage Miserly3_gain_desc
Epithet Miserly3_epithet_desc
Threshold 6

Effect TaxCollection 30
Effect Unrest 3

Pretty standard stuff. One point of either trait has a small chance of being given when a character comes of age. The traits can also be inherited so there's a moderate chance that a new family member will have at least one rank in either of the two traits (inheritance of traits is a good thing in my opinion, even if it's a bad trait)
Then, in the case of generous, there are some moderate chances of gaining a point upon completion of certain tasks such as marriage, building churches and so on.

However this is what the NoGoingBack triggers look like:

Spoiler Alert, click show to read: 

;------------------------------------------
Trigger Generous_NoGoingBack
WhenToTest CharacterTurnStart

Condition Trait Generous < 3
and Trait Generous > 1

Affects Generous 10 Chance 100

;------------------------------------------
Trigger Miserly_NoGoingBack
WhenToTest CharacterTurnStart

Condition Trait Miserly < 3
and Trait Miserly > 1

Affects Miserly 10 Chance 100
;------------------------------------------

I'm not particularly well versed in M2 traits and triggers, but doesn't this mean that as soon as a character attains rank 2 (Generousity2 or Miserly2) they'll always gain the third rank as soon as the next turn begins? I assume the traits were added manually because of all the vanilla bugs associated with antitraits and NoGoingBack levels, but it seems to me that the trait gives 10 points in a trait that otherwise only requires 6 points to attain the highest rank, causing characters to always reach the final rank once they've reached the second one.

Apologies if I had just misunderstood the trait system, I was mostly just curious to find out what caused the outcome I was experiencing.

[Jurand of Cracow]

You're right, there's an error in 097 in coding. It's been fixed for 098 (note that levels might have the same name but the engine will differentiate between them):

Spoiler Alert, click show to read: 

;========================================================================================= Generosity;----- Generosity ---------------------------------------
;
;-- this personality feature depicting generosity: giving out money
;-- defined at CoA, chaging somehow during life


;-------------------------------------------------------- GENEROUS
;-- levels(points) 1(1),2(3),3(16); AntiTrait: Miserly
;------------------------------------------
Trait Generous
Characters family


Level Generosity1
Description Generosity1_desc
EffectsDescription Generosity1_effects_desc
GainMessage Generosity1_gain_desc
Threshold 1


Effect TaxCollection -10
Effect Squalor -1

Level Generosity2
Description Generosity2_desc
EffectsDescription Generosity2_effects_desc
Threshold 3


Level Generosity2
Description Generosity2_desc
EffectsDescription Generosity2_effects_desc
GainMessage Generosity2_gain_desc
Threshold 4 ; NGB trigger adds 10pts at level 2, so threshold here is low so that if there're pts taken away, the threshold doesn't fall


Effect TaxCollection -20
Effect Squalor -2

Level Generosity3
Description Generosity3_desc
EffectsDescription Generosity3_effects_desc
GainMessage Generosity3_gain_desc
Threshold 16


Effect TaxCollection -30
Effect Squalor -1

;-------------------------------------------------------- MISERLY
;-- levels(points) 1(2),2(4),3(16); AntiTrait: Generous
;------------------------------------------
Trait Miserly
Characters family


Level Miserly1
Description Miserly1_desc
EffectsDescription Miserly1_effects_desc
GainMessage Miserly1_gain_desc
Threshold 1


Effect TaxCollection 10
Effect Unrest 1


Level Miserly2
Description Miserly2_desc
EffectsDescription Miserly2_effects_desc
Threshold 3


Level Miserly2
Description Miserly2_desc
EffectsDescription Miserly2_effects_desc
GainMessage Miserly2_gain_desc
Threshold 4 ; NGB trigger adds 10pts at level 2, so threshold here is low so that if there're pts taken away, the threshold doesn't fall


Effect TaxCollection 20
Effect Unrest 2

Level Miserly3
Description Miserly3_desc
EffectsDescription Miserly3_effects_desc
GainMessage Miserly3_gain_desc
Epithet Miserly3_epithet_desc
Threshold 16


Effect TaxCollection 30
Effect Unrest 3

[Nemesis2345]

https://www.twcenter.net/forums/show...485&viewfull=1

I AM PROUD TO ANNOUNCE THAT SSHIP WON 1ST PLACE AS THE FAVORITE SUBMOD/MINIMOD FOR MEDIEVAL 2 !
AND OF COURSE, JURAND OF CRACOW WAS ALSO VOTED AS ONE OF THE FAVOURITE MODDERS.

CONGRATS !!!!!!!

[robbyh]

https://www.twcenter.net/forums/show...485&viewfull=1

I AM PROUD TO ANNOUNCE THAT SSHIP WON 1ST PLACE AS THE FAVORITE SUBMOD/MINIMOD FOR MEDIEVAL 2 !
AND OF COURSE, JURAND OF CRACOW WAS ALSO VOTED AS ONE OF THE FAVOURITE MODDERS.

CONGRATS !!!!!!!

Very much deserved

[Belovèse]

Wow, thanks a lot guys, it's heartwarming !

[CheriSh17]

Congratulations to all the SSHIP modders!! Well deserved award!

[j.a.luna]

https://www.twcenter.net/forums/show...485&viewfull=1

I AM PROUD TO ANNOUNCE THAT SSHIP WON 1ST PLACE AS THE FAVORITE SUBMOD/MINIMOD FOR MEDIEVAL 2 !
AND OF COURSE, JURAND OF CRACOW WAS ALSO VOTED AS ONE OF THE FAVOURITE MODDERS.

CONGRATS !!!!!!!

Congratulation to sship team and also for Jurand!!!
I bet on you and I knew that you would reach high in the classification, it is a great submod

[kierkegaard190]

Well deserved! Your work is much appreciated. Congrats

[Waluk]

Congratulations! May you die with a sword in your hands

[Jurand of Cracow]

Congratulations! May you die with a sword in your hands

If I'd be buried in a SSHIP new unique building, then yes, die with a sword.

[kostic]

It's really nice and encouraging to see that our SSHIP has more and more followers ! Version 098 should soon replace the complexity and diversity of the current versions ... a little more patience !

[King Athelstan]

Congrats guys, well deserved!

[_TotalWar_]

Congratulations are in order and they are deserved. I personally await eagerly the next version.

[Just let me post]

Yay!

[DavidofLaSalle]

Congratulations Jurand and everyone. Truly well deserved. Thank you for all that you do

[Pyres Δt Varanasi]

https://www.twcenter.net/forums/show...485&viewfull=1

I AM PROUD TO ANNOUNCE THAT SSHIP WON 1ST PLACE AS THE FAVORITE SUBMOD/MINIMOD FOR MEDIEVAL 2 !
AND OF COURSE, JURAND OF CRACOW WAS ALSO VOTED AS ONE OF THE FAVOURITE MODDERS.

CONGRATS !!!!!!!

​Amazing, congratulations to all

[Brezkimra]

Dear SSHIP team! I'm collecting historical Hungarian musics for different era Hungarian Kingdom (=Magyar Királyság) faction campaigns. Are you interested about the musics what I choose for SSHIP era?

[Jurand of Cracow]

Dear SSHIP team! I'm collecting historical Hungarian musics for different era Hungarian Kingdom (=Magyar Királyság) faction campaigns. Are you interested about the musics what I choose for SSHIP era?

Thanks, szikelkun! I think we are, but @JLMP is our sound director, so I'm leaving it in his hands

[Nemesis2345]

Wouldnt it be better if the Heavy Armorer blacksmith (tier 3) would be avalable AFTER the Heavy Mail event instead from the start?

So at the beggining of the game, you would be able to build only tier 1 and tier 2 (light mail at best) instead of Heavy Mail before the main event is up.

Shouldnt be too hard to mod, Jurand maybe can take a look?

[Jurand of Cracow]

Wouldnt it be better if the Heavy Armorer blacksmith (tier 3) would be avalable AFTER the Heavy Mail event instead from the start?

So at the beggining of the game, you would be able to build only tier 1 and tier 2 (light mail at best) instead of Heavy Mail before the main event is up.

Shouldnt be too hard to mod, Jurand maybe can take a look?

It seems to me that most of the benefits from this building are indeed restricted by the event Heavy Mail (and other). Given that I don't know ins and outs of the armour numbering, I wouldn't change it, even if I see the reason behind your proposal.

    armourer city requires factions { northern_european, middle_eastern, eastern_european, greek, southern_european, }    {
      convert_to 2
      capability
      {
        armour 8 requires factions { northern_european, southern_european, eastern_european, } and event_counter TRANSITIONAL_ARMOR 1
        armour 9
        armour 10 requires not factions { mongols, cumans, }
        armour 11 requires not factions { mongols, cumans, }
        armour 12 requires factions { northern_european, southern_european, eastern_european, } and event_counter HEAVY_MAIL_ARMOR 1
        armour 12 requires factions { middle_eastern, } and event_counter HEAVY_MAIL_ARMOR 1
;---------------------------------------------------------------------------------------------------------------------------------
; UPKEEP/INCOME		
		income_bonus bonus -300
      }