increasing counters

[Lazy]

I created a trait that has 6 levels!

If a general has this trait and is inside a settlement I want count it up depending on what level ithe trait has! The trait will be removed after this part works... hopefully
The game recognises the character having the trait beeing inside that settlement!
The problem seems to be something with the blue part!

If I remove that blue stuff the fow is toggled!
"toggle_fow" is just beeing used so I can see if it works... it does not!
It seems not to recognise the counter or its number... perhaps there is nothing added...
I do not even know how I can see the counters number ingame!

What did I do wrong?
I did red some tutorials... perhaps not good enough

declare_counter mycounter
set_counter mycounter 0

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram    
    
    and Trait new_trait = 2
    
    inc_counter mycounter 1          

terminate_monitor
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram    
    
    and Trait new_trait = 3
    
    inc_counter mycounter 2        

terminate_monitor
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram    
    
    and Trait new_trait = 4
    
    inc_counter mycounter 3        

terminate_monitor
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram    
    
    and Trait new_trait = 5
    
    inc_counter mycounter 4        

terminate_monitor
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram    
    
    and Trait new_trait = 6
    
    inc_counter mycounter 5        

terminate_monitor
end_monitor

monitor_event SettlementTurnStart SettlementName Mt-Gram
    
    if I_CompareCounter mycounter > 0
        console_command toggle_fow
    end_if        

terminate_monitor
end_monitor

Edit: If I change the green "inc_counter" to "set_counter" it does not work either... My tests have been all made with the last trait level!

[The Uruk]

Do you need to set the mycounter to 0 after declaring it? I thought when the counter is declared it already starts at 0.

[Lazy]

Yeah you are right! I red that out a few minutes ago... but it makes no difference I think as both numbers are eual... I cannot check this here... but I remember that in the "previous" version that was missing and I had the same effect... NONE =>

[The Uruk]

Try using a definite number for the I_CompareCounter.
For example I_CompareCounter = 6
Also there is no need for the 'end_if'

[Emperor of Hell]

No you do need end_if
The problem is the set_counter 0 at the top BTW. that will always, at any moment set the counter to 0, so that's why your script doesn't work. just remove it
Sorry for my bad spelling/grammar btw, using an itouch is kinda hard xD

[The Uruk]

No you do need end_if
The problem is the set_counter 0 at the top BTW. that will always, at any moment set the counter to 0, so that's why your script doesn't work. just remove it
Sorry for my bad spelling/grammar btw, using an itouch is kinda hard xD

Just out of curiosity, why do you need it? Why not just 'end'?

[Emperor of Hell]

I don't really know, it's just necessary

[Byg]

There is no such condition as CharacterTurnEndInSettlement afaik.

The set counter at the start is not wrong. Surely this will just set the counter to 0 when the campaign first runs and then it will not trigger again. However it is unnecessary.

[Emperor of Hell]

CharacterTurnEndInSettlement is in the docudemons.

[Lazy]

This conditions is weird... I found it in some place... but I caues only errors in the following stuff... It never worked!
Checking the settlement in the following line works better/easier!

However... thanks for the help!

[Squid]

I'm pretty sure that the order things are evaluated in are: PreFaction -> Faction -> Settlement -> Character, so you're character counter changes would have no effect on the settlement event.

[Lazy]

I'm pretty sure that the order things are evaluated in are: PreFaction -> Faction -> Settlement -> Character, so you're character counter changes would have no effect on the settlement event.

That could be it!
Thank for telling there is an order...
This script made me so angry I left my house because I was so angry...
Perhaps saved my keyboard from a beatup...

[Withwnar]

I'm pretty sure that the order things are evaluated in are: PreFaction -> Faction -> Settlement -> Character, so you're character counter changes would have no effect on the settlement event.

The order is PreFaction -> Character -> Settlement -> Faction

CharacterTurnEndInSettlement should fire at the end of the turn and SettlementTurnStart will fire at the start of the following turn. For the player this is all during the same turn end (turn end, other factions, turn start) but for the AI you won't see it until the turn after.

Maybe CharacterTurnEndInSettlement doesn't work. You could try this instead...

monitor_event CharacterTurnEnd EndedInSettlement
  and SettlementName Mt-Gram    
  and Trait new_trait = 2
    
    inc_counter mycounter 1          

terminate_monitor
end_monitor

I do not even know how I can see the counters number ingame!

In game is not possible. There is the "log_counter" command that will write a counter's value to the log. It doesn't work for event counters, only 'real' counters.

[Taiji]

Use trace and counter changes are logged anyway.

And the order is PFTS CTS STS FTS.

[Withwnar]

And the order is PFTS CTS STS FTS.

So it is. (Post edited.)

[ilmrik]

Uhm,

monitor_event SettlementTurnStart SettlementName Mt-Gram
    
    if I_CompareCounter mycounter > 0
        console_command toggle_fow
    end_if        

terminate_monitor
end_monitor

This monitor terminates the moment your campaign starts ( during the turn start procedures of turn 0 )

CharacterTurnEndInSettlement sounds like something that happens during the end of the turn 0 procedures...

Aka your test monitor terminates before any of your other monitors trigger, remove the terminate monitor and see or it does anything.

[Lazy]

I hit my head against the keayboard a few times...
suddenly it worked like this:

declare_counter my_event0
declare_counter my_event1
declare_counter my_event2
declare_counter my_event3
declare_counter my_event4
declare_counter my_counter

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    and I_EventCounter my_event0 1
    and Trait my_trait = 2
        inc_counter my_counter 1
    
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    and I_EventCounter my_event0 1
    and Trait my_trait = 3
        inc_counter my_counter 2
    
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    and I_EventCounter my_event0 1
    and Trait my_trait = 4
        inc_counter my_counter 3
    
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    and I_EventCounter my_event0 1
    and Trait my_trait = 5
        inc_counter my_counter 4
    
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    and I_EventCounter my_event0 1
    and Trait my_trait = 6
        inc_counter my_counter 5
        
end_monitor

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram

    and Trait my_trait = 6
    set_event_counter my_event0 1

end_monitor

monitor_conditions I_EventCounter my_event0 1
    if I_CompareCounter my_counter > 4
    set_event_counter my_event1 1
    end_if

    if I_CompareCounter my_counter > 9
    set_event_counter my_event2 1
    end_if

    if I_CompareCounter my_counter > 14
    set_event_counter my_event3 1
    end_if

    if I_CompareCounter my_counter > 19
    set_event_counter my_event4 1
    end_if
end_monitor

The order problem was solved by simply changing the order in the campaign_script.txt
"terminate_editor"... I cannot remember putting it there... after I removed it stuff got easier!

I will add a factionislocal or something to this "monitor_condition "later to prevent it from firing so often... even if it does not really matter...


But I have a new question... I want to decrease the monitor_events to decrease turn time but
the "if" thing does not work here:

monitor_event CharacterTurnEndInSettlement SettlementName Mt-Gram 

    if I_EventCounter my_event0 1
      and Trait my_trait = 2
      inc_counter my_counter 1
    end_if

   if I_EventCounter my_event0 1
       and Trait my_trait = 3
       inc_counter my_counter 2
     end_if

end_monitor

The log file tells me that I cannot check traits... one of the posted conditions is "<>"
There should be written something between the brickets...
I will take some time until I find out why this is happening... perhaps someone knows it?

Could the reason be that in desc_character_traits stuff is beeing changed after (?!) the campaign_script?

[ilmrik]

You can't, the "my_trait" can't be used in an if statement as it requires a condition export from an event.

You could change the monitor_conditions, by a monitor_event FactionTurnStart that way it will only run 1 time per turn. Also monitor_conditions tend to slow the game down if you use too many.

[Lazy]

Thank you!
I will try that out first!