Originally Posted by
TNZ
smoesville: I should mention that using ‘terminate_monitor’ in your elendilmir script is not such a good idea. If Aragorn has a son, but Aragorn dies before the event and the next faction leader does not have the bloodline trait, you won't be able to switch the counter back when Aragorn’s son becomes faction leader.
I just remembered there is a ‘FactionLeaderTrait’ condition. That means you don't need the elendilmir script in the first place. All you need to do is add the ‘FactionLeaderTrait’ condition to the next section of your script. It may also be a good idea to change the monitor event to ‘FactionTurnStart’:
This should also solve that bug you having problems with. This may not effect what you are trying to do, but there is in fact a small error in the original Arnor Union script. If you take a look at the section to do with rejecting the event:
I'm pretty sure that line should be ‘set_counter union_rejected 1’ the not ‘set_counter union_declined 1’.
Originally Posted by
killersmurf
the FactionLeaderTrait condition requires an CharacterTurnStart/End or whatever. I tested it with that, but that doesn't fix the bug. I think FactionTurnStart or PreFactionTurnStart would work. No other changes required. I'll do testing
EDIT: FactionTurnStart fixes the bug
You can't use the ''and FactionLeaderTrait RangerKing >= 1'' condition in combination with ''monitor_event FactionTurnStart FactionType turks''. You will get this error:
Code:
<character_record> is unavailable from event <FactionTurnStart>
when testing <FactionLeaderTrait> condition
From docudemon we have:
Code:
Identifier: FactionLeaderTrait
Trigger requirements: character_record
Parameters: trait description, logic token, level
Sample use: FactionLeaderTrait VictorRomanVirtue >= 2
Description: Test a character's faction leader traits
Battle or Strat: Either
Class: FACTION_LEADER_TRAIT_TEST
Implemented: Yes
Author: Lee
This means the script should like this (I have tested this myself and it works 100% 
):
Code:
monitor_event CharacterTurnStart FactionType turks
and not IsFactionAIControlled
and I_LocalFaction turks
and FactionLeaderTrait RangerKing >= 1
and DiplomaticStanceFromFaction sicily = Allied
and I_SettlementOwner Shire = turks
and I_SettlementOwner Bywater = turks
and I_SettlementOwner Southfarthing = turks
and I_SettlementOwner Bree = turks
and I_SettlementOwner Staddle = turks
and I_SettlementOwner Cardolan = turks
and I_SettlementOwner Weather-Hills = turks
and I_SettlementOwner Lake_Evendim = turks
and I_SettlementOwner Arthedain = turks
and I_SettlementOwner Mitheithel = turks
and I_SettlementOwner Lone-lands = turks ;Tharbad
and I_SettlementOwner Ettenmoors = turks
and FactionBuildingExists >= house_of_kings
and I_CompareCounter union_offered = 0
@TNZ: btw this counter isn't used in the script so no worries here: set_counter union_declined 1
@smoesville: thanks for your sharing your concept (and allowing me to use it 
), I consider it a very good improvement since it gives a lot more flexibility to the player in the end. 
Edit: we don't need strider anymore 
Heirs of Isildur v1.1 [3.2 Compatible]
Reply With Quote
(slyly reuploading the files) It's always been Valandil 
Under the patronage of 
