Ask for help

[attyla]

This is a part of script calling the bulgarian uprising:

monitor_event FactionTurnStart FactionIsLocal
    if I_CompareCounter miasto_zdobyte = 1
        generate_random_counter bunt_bulgarow 1 6
    end_if
end_monitor 

and second one:

monitor_event FactionTurnEnd FactionIsLocal
    and I_CompareCounter bunt_bulgarow = 1
        and I_SettlementOwner Sofia = byzantium
            historic_event start_bunt_bulgaria true

    spawn_army
(...)
    end

        siege_settlement Aleksei, Sofia, attack
        set_counter siege_sofia 1
end_monitor 

Log, as usually, says nothing.

Unfortunately it doesn't work. Historic_event is an indicator of efficiency of the code. I give it for each of levels of the script. If script does work - historic_event shows me an info if doesn't - i have no info.
In this case i have no info, so i suppose there is a problem connected with exporting the value of the event to the next level of the script.
I would like to ask someone wise to check it and advise me what need i change to make this script operational.

[Emperor of Hell]

Remove the true line from the historic event. It gives a yes/no event and that requires IIRC some counters

[attyla]

Yes/no is not enough for me. As you can see in first part of cited code, the random counter is is from 1 to 6, where each number represents a different region (in this case "1" means Corinth vel Morea, where uprising is going to start).

[Taiji]

Attyla, what is the script supposed to do? (you realise you have a 1 in 6 chance of it firing the event yes?)

Killersmurf, it generates event counters by itself, all historic events need is text in \text\historic_events.strings.bin

[attyla]

This part of script should draw the region where the uprising would rise. I'm planning that the uprising should rise in one from six specific regions.

[Emperor of Hell]

Killersmurf, it generates event counters by itself, all historic events need is text in \text\historic_events.strings.bin

So those aren't necessary? Thanks for the info

[attyla]

So generate_random_counter is not proper command to achieve my goal? What about random_counter_inc?
I need a command that would choose a random number from the given scope.

[ilmrik]

I think "generate_random_counter" sets and "event counter"
so

monitor_event FactionTurnEnd FactionIsLocal 
    and I_EventCounter bunt_bulgarow = 1 
        and I_SettlementOwner Sofia = byzantium 
            historic_event start_bunt_bulgaria true 

    spawn_army 
(...) 
    end 

        siege_settlement Aleksei, Sofia, attack 
        set_counter siege_sofia 1 
end_monitor  

Should work,
few notes though:
1) Is there a reason you're using 2 ( or 7 depending on how you wrote it) monitors ? You can put it all into 1,
2) There is nothing to prevent the event from running over and over again.

[attyla]

I'm completly confused. I didn't know, that there is so big difference between I_CompareCounter and I_EventCounter. Great thanks - it works fine now.

Ps. Do not worry about looping the script. I use command inc_counter

[ilmrik]

Yeah it's a pretty important difference, They are very similar but totally different at the same time

"counters" have to be declared before you can use any of the command for them;
declare_counter BlaBla
and have the following commands:
I_CompareCounter
inc_counter
set_counter

"event_counters" don't require declaring
they have following options
I_EventCounter
inc_event_counter
set_event_counter
generate_random_counter

They are also the ones you refer to in the EDB etc
aswel as automatically change when an historic event triggers ( e.g. the historic event GUNPOWDER will increase the event_counter named GUNPOWDER by 1) regardless of how you trigger the event ( via campaign script or vie event.txt

[Taiji]

Stick this in there somewhere:

and ! I_CharacterExists Aleksei

That should solve it.

[attyla]

1. Sofia is just one of the possible locations of the uprising.
2. Aleksei will not "live" forever
3. i have 5 other places where uprising may rise and 5 other generals who wait to be spawned by this script.

I thought that command inc_counter increases value of the event by one per turn. Is it true? If it is i'm confused because script doesn't work if i give as a condition the value 2 for example. I thought too that if i will use inc_value, the condition I_EventCounter will find value "1" one only.
So there is a question: how can i make a condition which lets the script run any command by given value and how can i make a script lets run another script only one time during given account of turns?

[Squid]

Nothing built in but you can create a counter in your script and increase it every turn after the event has occurred.

[attyla]

How to make it? Did you make something like this?

[attyla]

It's likely that the problem is solved. It was enough to add the line

set_counter miasto_zdobyte 0 

by line

generate_random_counter bunt_bulgarow 1 6

It's time to test it now