Scripts not working PLEASE HELP????

[valvegas1]

OK i am writing a script to alter the kings purse based on number of settlements a faction holds...the script is not running at all...when i check the logs i see two lines involving my script....here they are....

01:26:19.648 [game.script] [error] Script parsing error at line 4972, column 1 in mods/kingdoms_grand_campaign_mod/data/world/maps/campaign/imperial_campaign/campaign_script.txt
don't recognise this token: end_monitor
01:26:19.649 [game.script] [error] Script parsing error at line 4977, column 5 in mods/kingdoms_grand_campaign_mod/data/world/maps/campaign/imperial_campaign/campaign_script.txt
Couldn't create a script from file mods/kingdoms_grand_campaign_mod/data/world/maps/campaign/imperial_campaign/campaign_script.txt

And here's my campaign_script....The Blue lines are the lines in question (according to the log)

monitor_event FactionTurnStart FactionType england
and FactionIsLocal

if I_NumberOfSettlements england > 0
and I_NumberOfSettlements england <= 5
set_kings_purse england 2500
end_if

if I_NumberOfSettlements england > 5
and I_NumberOfSettlements england <= 10
set_kings_purse england 5000
end_if

if I_NumberOfSettlements england > 10
and I_NumberOfSettlements england <= 15
set_kings_purse england 7500
end_if

if I_NumberOfSettlements england > 15
and I_NumberOfSettlements england <= 20
set_kings_purse england 10000
end_if

if I_NumberOfSettlements england > 20
and I_NumberOfSettlements england <= 25
set_kings_purse england 12500
end_if

if I_NumberOfSettlements england > 25
set_kings_purse england 15000
end_monitor

monitor_event FactionTurnStart FactionType france
and FactionIsLocal

if I_NumberOfSettlements france > 0
and I_NumberOfSettlements france <= 5
set_kings_purse france 2500
end_if

if I_NumberOfSettlements france > 5
and I_NumberOfSettlements france <= 10
set_kings_purse france 5000
end_if

If you know what the problem is or have ideas then please help....thank you in advance for any assistance.......

[Emperor of Hell]

you should do it like this:

monitor_event FactionTurnStart FactionType england
and FactionIsLocal

if I_NumberOfSettlements england > 0
and I_NumberOfSettlements england <= 5
set_kings_purse england 2500
end_if

if I_NumberOfSettlements england > 5
and I_NumberOfSettlements england <= 10
set_kings_purse england 5000
end_if

if I_NumberOfSettlements england > 10
and I_NumberOfSettlements england <= 15
set_kings_purse england 7500
end_if

if I_NumberOfSettlements england > 15
and I_NumberOfSettlements england <= 20
set_kings_purse england 10000
end_if

if I_NumberOfSettlements england > 20
and I_NumberOfSettlements england <= 25
set_kings_purse england 12500
end_if

if I_NumberOfSettlements england > 25
set_kings_purse england 15000
end_if
end_monitor

monitor_event FactionTurnStart FactionType france
and FactionIsLocal

if I_NumberOfSettlements france > 0
and I_NumberOfSettlements france <= 5
set_kings_purse france 2500
end_if

if I_NumberOfSettlements france > 5
and I_NumberOfSettlements france <= 10
set_kings_purse france 5000
end_if

[valvegas1]

workin like a charm....thx

[Tsarsies]

Whenever you write long scripts it is very easy to over look the simplest things like forgetting to close an if statement or a minor spelling error. I find that there are certain techniques and guidelines you can use and follow that can help minimize these honest errors. The main one being formatting.

As an example i try to indent and evenly space/tab certain lines, be it a command line or condition. Try to keep some kind of order as opposed to a box like effect u had in the first post. You will find it reads easier too.

And given, ur formatting may have changed during posting, but thought i would raise the point anyway

monitor_event FactionTurnStart FactionType england
	and FactionIsLocal

	if I_NumberOfSettlements england > 20
		and I_NumberOfSettlements england <= 25
			set_kings_purse england 12500
		end_if

	if I_NumberOfSettlements england > 25
			set_kings_purse england 15000
		end_if

end_monitor

The other thing that can help you is using a text editor that uses colours. Which can help minimize spelling mistakes and scripting errors.

[valvegas1]

yeah i'm getting the hang of it...plus i found the code to log script errors and such...thanks for the help guys....