I noticed this coding a while ago. So I tried it out, and then when I realised what was going on I felt pretty stupid myself. Shoulda been able to work out that cav and siege and inf is everything... lol
As for the trigger thing, I made a little mistake. I'll do the whole trait for you so you can see everything:
Code:
;;;Stick this at the start of the file:
Trait GeneralsOnly
Characters family
Hidden
Level GeneralsOnly
Description GeneralsOnly_desc
EffectsDescription GeneralsOnly_effects_desc
Threshold 1
Effect MovementPoints 5
;;;;;;Stick this at the end of the file:
Trigger GeneralsOnlyOn
WhenTotest CharacterTurnStart
Condition PercentageUnitAttribute general_unit = 100
and not Trait GeneralsOnly = 1
Affects GeneralsOnly 1 Chance 100
Trigger GeneralsOnlyOff
WhenTotest CharacterTurnStart
Condition Trait GeneralsOnly = 1
and not PercentageUnitAttribute general_unit = 100
Affects GeneralsOnly -1 Chance 100
That stuff in blue tells you what to name your description text - The stuff that pops up when you mouseover the trait.
Not sure if you need to do it for hidden traits, like I made that one, but you'll find where in text\export_VnVs.txt.
I didn't test it so... It probably works... But don't trust it!