Upgrading general units

**Quinn Inuit** · September 02, 2011, 08:31 PM

Do I understand correctly that:
1) General units can only be upgraded if there's a building with the bodyguard attribute.
2) The hard-coded Marian Reforms occur.
3) There's a unit with a general_unit_upgrade attribute that shouldn't also have the general_unit attribute.
4) That unit is not recruitable at a building, since that will cause a CTD.
?

**Primo** · September 03, 2011, 01:16 AM

Originally Posted by Quinn Inuit

Do I understand correctly that:
1) General units can only be upgraded if there's a building with the bodyguard attribute. Yes
2) The hard-coded Marian Reforms occur. Yes
3) There's a unit with a general_unit_upgrade attribute that shouldn't also have the general_unit attribute. No I think they have to have both
4) That unit is not recruitable at a building, since that will cause a CTD. I am not sure - recruitable generals are possible, and when I declared a gladiator unit to be spartacus bodyguard but never removed them from recruiting by colloseums it didn´t lead to a ctd
5) There can be just one upgrade, the first unit in the edu with this attribut is selected by the game for it
6) I am not sure about it, but every general gets his maximum number of bodyguards, regardless if he before had -for example - 2

^

**Quinn Inuit** · September 03, 2011, 07:49 AM

Very interesting, thank you.

I know you can make generals recruitable, but AFAIK you can't make the upgraded general unit recruitable. Am I right?

That's good to know about the unit maxing out in size. Yikes.

Say the general unit upgrade occurs at Time T. At Time T + 1, your son Bob the Cunning comes of age. Will Bob the Cunning get the general_unit_upgrade unit?

**AveCaesar** · September 09, 2011, 09:53 AM

Originally Posted by Quinn Inuit

I know you can make generals recruitable, but AFAIK you can't make the upgraded general unit recruitable. Am I right?

@Quinn, I noticed this thread, and it didn't look as if this particular question was answered. Maybe you already found out on your own. I just wanted to let you know that the upgraded General units can be made recruitable, provided the Reforms have happened.

**Quinn Inuit** · September 03, 2011, 09:04 AM

Another question: if the upgrade requires the hard-coded Marian Reforms to take place, why does the Vanilla Barbarian Invasion EDB include upgrade buildings?

**Primo** · September 03, 2011, 02:44 PM

Originally Posted by Quinn Inuit

Very interesting, thank you.

I know you can make generals recruitable, but AFAIK you can't make the upgraded general unit recruitable. Am I right?

That's good to know about the unit maxing out in size. Yikes.

Say the general unit upgrade occurs at Time T. At Time T + 1, your son Bob the Cunning comes of age. Will Bob the Cunning get the general_unit_upgrade unit?

Yes.
It works even better: If you assign a general in descr_strat a random generals unit (like a roman general a barbarian bodyguard) they will be both re-filled and upgraded

Originally Posted by Quinn Inuit

Another question: if the upgrade requires the hard-coded Marian Reforms to take place, why does the Vanilla Barbarian Invasion EDB include upgrade buildings?

I never played Barbarian Invasion and I have no idea.

**ithinkitsdead** · September 06, 2011, 05:52 PM

Wait, I couldn't wrap my head around that.
You say the upgrade should NOT have the general_unit attribute if it has the general_unit_upgrade attribute????

I was running through the EDU of Vanilla to confirm and each of the upgrade units had the general_unit and general_unit_upgrade attribute's....care to elaborate?

**Squid** · September 06, 2011, 06:58 PM

Not it should have both.

**ithinkitsdead** · September 06, 2011, 06:59 PM

Hmmmmmmmmm........
All right, Squid. I will discard that as the issue. Thanks!

**Primo** · September 07, 2011, 02:07 AM

Originally Posted by ithinkitsdead

Hmmmmmmmmm........
All right, Squid. I will discard that as the issue. Thanks!

Didn´t I already said it earlier?

3) There's a unit with a general_unit_upgrade attribute that shouldn't also have the general_unit attribute. No they have to have both

**Quinn Inuit** · September 09, 2011, 10:01 AM

Hmmm...are you sure about that? I thought I read something to the contrary.

Also, I can not seem to enable the bodyguard upgrade. I've even tried starting the game with Marian reforms activated and a building in every city with the bodyguard upgrade ability, but they won't upgrade. I know the reforms are on because I attached a "Happiness + 20 requires reforms" condition* to the building as well, and that was working.

*If you're going to use a test condition, IMO you might as well make it easily noticeable.

**AveCaesar** · September 09, 2011, 10:15 AM

Yes, I do it all the time. here are 3 lines from my Imperial Palace in in my export_descr_buildings:

recruit "roman generals guard cavalry early" 0 requires factions { romans_julii, } and not marian_reforms
recruit "roman generals guard cavalry" 0 requires factions { romans_julii, } and marian_reforms and hidden_resource legio2 or hidden_resource east2 or hidden_resource gallic2 or hidden_resource alexandria or hidden_resource tingi or hidden_resource carthage or hidden_resource massilia or hidden_resource antioch
upgrade_bodyguard 1 requires factions { dacia, germans, scythia, greek, roman, }

Obviously you don't need all the hidden resources I set(I just wanted to limit where they could be hired from), but it works!

Added to that is that ownership obviously needs to be set on the unit model, as well as the general_unit_upgrade attribute. I've also done it for a few other factions as well. And I have a couple factions where I've entirely eliminated the early model, and only the upgraded general unit is recruitable, both by me or the AI from the beginning.

**Quinn Inuit** · September 09, 2011, 10:37 AM

Thanks for the explanation. I'll use that format on the recruitable generals.

How do you get the
upgrade_bodyguard 1
EDB line to function, though? That's what's really causing me headaches. It won't let me retrain generals to the upgraded versions like Nightmare Moon suggested above, and with at least some configurations new generals that came of age were still the early unit, too. (Admittedly, I haven't tried the coming of age with all configurations of code.)

**AveCaesar** · September 09, 2011, 10:44 AM

Honestly, I don't know what is happening with your game's inability to have general's coming of age be the upgraded units. For me it just seems to go like clockwork once the reforms have happened. Perhaps the key is the general unit attribute or upgrade attribute on those units in your EDU?

*I'm actually in awe that my limited experience just modding my own game would be of any use to you, as you are near-legendary, LOL.

**Primo** · September 09, 2011, 01:15 PM

Originally Posted by Quinn Inuit

Thanks for the explanation. I'll use that format on the recruitable generals.

How do you get the
upgrade_bodyguard 1
EDB line to function, though? That's what's really causing me headaches. It won't let me retrain generals to the upgraded versions like Nightmare Moon suggested above, and with at least some configurations new generals that came of age were still the early unit, too. (Admittedly, I haven't tried the coming of age with all configurations of code.)

After my knowledge it just works if you have both the Marian reform and a building with said attribute. This kinda removes the feature from the game, so I am not sure if the line is neccessary.

**ares7667** · September 12, 2011, 01:35 AM

Is there any way to get an upgrade if the marian reforms haven't happened. I ask because I want the upgrade to happen to another faction that wouldn't depend on marian reforms. I wonder if there is a way to do it with scripts?

**Squid** · September 12, 2011, 10:50 AM

No if there's no reform then no upgrade and the only way to do it through scripts is to still have a roman cultured faction still in the game, and if that was the case the reforms could still happen on their own anyways.

**ares7667** · September 12, 2011, 03:08 PM

Could I set up a script that checks for a certain building. Then if present kill off the old character and spawn the new upgraded one?

**Squid** · September 12, 2011, 08:17 PM

Only on a character by character basis and only if you knew the characters name, which only happens if you have spawned the character in the first place.

**Quinn Inuit** · December 30, 2011, 09:40 PM

Originally Posted by AveCaesar

Honestly, I don't know what is happening with your game's inability to have general's coming of age be the upgraded units. For me it just seems to go like clockwork once the reforms have happened. Perhaps the key is the general unit attribute or upgrade attribute on those units in your EDU?

*I'm actually in awe that my limited experience just modding my own game would be of any use to you, as you are near-legendary, LOL.

Me? Legendary? Are you sure you're not thinking of Squid?

Originally Posted by Nightmare Moon

After my knowledge it just works if you have both the Marian reform and a building with said attribute. This kinda removes the feature from the game, so I am not sure if the line is neccessary.

Finally got it working. I think it may have been working for awhile, but I didn't realize it because it wouldn't let me retrain. Now, though, the upgrade is kicking in even without the upgrade_bodyguard building being present. Any idea why that is? I have Marian Reforms active at the start of the game.