weird behaviour

[attyla]

hmmm. I have something really weird. If you remember, i've added bulgarian faction to my mod. This faction spawning in 1180 and starting to siege two cities: Preslaw and Sofia. They taking this sities, but tey living sities right now
you can find belowe the screenshoot.
Sctript looks like this:

monitor_event FactionTurnStart FactionIsLocal
and I_TurnNumber = 4 ;105

spawn_army
faction normans
character Ivan Asen, named character, age 18, x 351, y 187
traits Factionleader 1 , GoodCommander 3 , PublicFaith 1 , BattleDread 2 , ReligionStarter 1 , HaleAndHearty 1
unit Bulgarian Bodyguard exp 1 armour 0 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Dismounted Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Dismounted Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Cuman Horse Archers exp 1 armour 0 weapon_lvl 0
unit Cuman Horse Archers exp 1 armour 0 weapon_lvl 0
unit Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
end
siege_settlement Ivan Asen, Preslaw, maintain
set_counter siege_preslaw 1

spawn_army
faction normans
character Teodor Asen, named character, age 16, x 338, y 184
traits Factionheir 1 , GoodCommander 2 , BattleDread 3 , ReligionStarter 1 , LoyaltyStarter 1 , Austere 1
unit Bulgarian Bodyguard exp 1 armour 0 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Slav Levies exp 1 armour 1 weapon_lvl 0
unit Dismounted Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Dismounted Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Mongol Foot Archers exp 1 armour 0 weapon_lvl 0
unit Cuman Horse Archers exp 1 armour 0 weapon_lvl 0
unit Cuman Horse Archers exp 1 armour 0 weapon_lvl 0
unit Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
unit Bulgarian Cavalry exp 1 armour 0 weapon_lvl 0
end

siege_settlement Teodor Asen, Sofia, maintain
set_counter siege_sofia 1

terminate_monitor
end_monitor

What should i change/add to make Bulgarian keep taking cities?

[attyla]

No ideas how to fix this problem?

[Gigantus]

I have modified your script to the effect that the siege will be maintained for 3 rounds to allow for siege equipment to be build. You have to change the co-ordinates to be directly next to the settlement and adjust the direction according to which way the character has to look.

declare_counter siege_sofia
monitor_event FactionTurnStart FactionIsLocal
          and I_TurnNumber = 4 ;105

    spawn_army
        faction normans
character    Ivan Asen, named character, age 18, x 351, y 187, label attack1, direction W 
traits Factionleader 1 , GoodCommander 3 , PublicFaith 1 , BattleDread 2 , ReligionStarter 1 , HaleAndHearty 1 
unit        Bulgarian Bodyguard            exp 1 armour 0 weapon_lvl 0
unit        Slav Levies                exp 1 armour 1 weapon_lvl 0
sieging

siege_settlement attack1, Sofia, maintain
set_counter siege_sofia 1

    if I_CompareCounter siege_sofia < 2
            siege_settlement attack1, Sofia, maintain
    end_if
    if I_CompareCounter siege_sofia = 2
        siege_settlement attack1, Sofia, attack
    terminate_monitor
    end_if

    inc_counter siege_sofia 1
terminate_monitor
end_monitor

[attyla]

Now is worser. They don't attack Sofia and Preslaw and after breaking sieging cities immiediately go in Constantinoples direct.

[rebelyell2006]

You could set Sofia and Preslaw as horde_targets, perhaps remove the horde_target from Constantinople.

[Gigantus]

Did you change the co-ordinates to be directly next to the city?
Did enter the correct direction th echaracter has to face (if he is directly to the right of the settlement then the direction he has to face is West (W)

Reason I am asking: in 9 out of 10 cases the character will attack the city

[Taiji]

The script looks like it would increment the siege_sofia counter to a maximum of 1.

[Gigantus]

At least two rounds I think, at least that's what I remember when testing it :

    if I_CompareCounter siege_sofia = 2
         siege_settlement attack1, Sofia, attack
     terminate_monitor
     end_if

[Taiji]

But that script will only run once:

and I_TurnNumber = 4

Which makes sense when considering that it spawns an army.

[Gigantus]

Then the bottom part has to be put into it's own monitor.

monitor_event FactionTurnStart FactionIsLocal
           and I_TurnNumber = 4 ;105
      spawn_army
         faction normans character    Ivan Asen, named character, age 18, x 351, y 187, label attack1, direction W
  traits Factionleader 1 , GoodCommander 3 , PublicFaith 1 , BattleDread 2 , ReligionStarter 1 , HaleAndHearty 1  unit        Bulgarian Bodyguard            exp 1 armour 0 weapon_lvl 0 unit        Slav Levies                exp 1 armour 1 weapon_lvl 0 sieging 

 siege_settlement attack1, Sofia, maintain
   terminate_monitor
     end_monitor

  monitor_event FactionTurnStart FactionIsLocal
      if I_CompareCounter siege_sofia < 2
             siege_settlement attack1, Sofia, maintain
     end_if
     if I_CompareCounter siege_sofia = 2
         siege_settlement attack1, Sofia, attack
     terminate_monitor
     end_if
      inc_counter siege_sofia 1
 end_monitor

That must have been the reason why nothing happened. I made a two part monitor in my script, no idea why I tried to combine here.

[Taiji]

Ok, that's certainly an improvement... But now the second part of the script fires every turn. So aside from the commands at best doing nothing, it will be terminated before the first part of the script can fire. Perhaps get the second part of the script to check if the character is alive, or maybe do it based on turn number again, or perhaps even use the counter.

[Gigantus]

Before I try it from memory again, here is the one from my script:

declare_counter siege_Fareyar
monitor_event FactionTurnStart FactionType spain
    and I_TurnNumber = 1
    and not I_SettlementOwner Fareyar = norway
    and not I_SettlementOwner Fareyar = horda
    and not I_SettlementOwner Fareyar = denmark


    spawn_army
        faction spain
        character    Bjalfi, general, age 29, x 89, y 193, label v00, direction W
        unit    Huskarl Swordsmen        exp 4 armour 0 weapon_lvl 0
        unit    Leidgangr Spearmen        exp 3 armour 0 weapon_lvl 0
        unit    Leidgangr Spearmen        exp 3 armour 0 weapon_lvl 0
        unit    Herkledi Spearmen        exp 3 armour 0 weapon_lvl 0
        unit    Vikingr Axemen            exp 3 armour 0 weapon_lvl 0
        unit    Vikingr Axemen            exp 3 armour 0 weapon_lvl 0
        unit    Leidgangr Archers        exp 3 armour 0 weapon_lvl 0
    sieging
        siege_settlement v00, Fareyar, maintain
    terminate_monitor
end_monitor

monitor_event FactionTurnEnd FactionType spain
    and I_CharacterExists v00
    and not I_SettlementOwner Fareyar = norway
    and not I_SettlementOwner Fareyar = horda
    and not I_SettlementOwner Fareyar = denmark
    and I_SettlementUnderSiege Fareyar

    if I_CompareCounter siege_Fareyar < 2
            siege_settlement v00, Fareyar, maintain
    end_if
    if I_CompareCounter siege_Fareyar = 2
        siege_settlement v00, Fareyar, attack
    terminate_monitor
    end_if

    inc_counter siege_Fareyar 1
end_monitor

[Taiji]

Looks good to me

[attyla]

Resolution of my problem is very simply. I only should add horde_target to entries of Sofia and Preslaw regions in descr_regions as rebelyell2006 told and script works well now.
Thanks you all for help