Kingmaker triggers aren't working

[irishron]

This is what I got for a ctd:

18:47:31.880 [game.script.trigger] [trace] Trigger <0300K_new_faction_leader> fired
18:47:31.880 [game.script.trigger] [trace] Trigger <Usurper1> fired
18:47:31.881 [game.script] [error] Trigger processing error in <Kingmaker1>
: FactionwideAncillaryExists needs a living character.

when testing <FactionwideAncillaryExists> condition
18:47:31.881 [game.script] [error] Trigger processing error in <Kingmaker2>
: FactionwideAncillaryExists needs a living character.

This is what is in the EDA:

;------------------------------------------
Ancillary kingmaker1
Type kingmaker
Transferable 0
Image tokus_kingmaker.tga
Description kingmaker1_desc
EffectsDescription kingmaker1_effects_desc
Effect Authority 1
;------------------------------------------
Ancillary kingmaker2
Type kingmaker
Transferable 0
Image tokus_kingmaker.tga
Description kingmaker2_desc
EffectsDescription kingmaker2_effects_desc
Effect Unrest 2
Effect TaxCollection -5
Effect Command -1


;------------------------------------------
Trigger Kingmaker1
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and not FactionwideAncillaryExists kingmaker2
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker1 chance 25
;------------------------------------------
Trigger Kingmaker2
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and not FactionwideAncillaryExists kingmaker1
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker2 chance 40

What is wrong? I have tried it in the EDCT, also. It is when I kill the faction leader with no faction heir, usurper trigger fires and then the kingmaker triggers fire but the usurper trigger did not find seem to find an an heir and ctds.

[TNZ]

irishron: Have you try adding the ‘IsGeneral’ condition to the triggers?

[irishron]

I just looked above our posted that I copied verbatum and I don't see IsGeneral.

Could you please show this thick skull how to add it?

[TNZ]

;------------------------------------------
Trigger Kingmaker1
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and IsGeneral
and FactionwideAncillaryExists kingmaker2
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker1 chance 25
;------------------------------------------
Trigger Kingmaker2
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and IsGeneral
and not FactionwideAncillaryExists kingmaker1
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker2 chance 40

[irishron]

Thank you very much.

[Taiji]

Um... I don't have much to add, I don't see why it isn't working, but BecomesFactionLeader isn't going to export a character record that isn't a general. I think IsGeneral is only useful for events where the character might not be a general. If it works when you add that then I am even more confused...

[irishron]

Only time will tell, Taiji. In the year or so we have had BBB 4.0 in our mod, it has happened to me twice, once as a trait trigger and now as an ancillary trigger. It's just more testing. It could be something CA did or did not do in the hardcode, again. Gigantus has it in his PDER mod and I had one of his players contact me about it crashing his camapign. Same circumstances.

Could the IsGeneral line be tied to the way the game fires the usurper trigger before it fires the kingmaker triggers?

[redxavier]

Sorry, but did adding the IsGeneral to the trigger work?

[irishron]

I have not had a chance to test it. I need a king to kill with no apparent heir to test it and I'm not far enough into a campaign to find one or have the ai do the dirty work for me.

[Taiji]

I wonder if the king and heir died at the same time when the CTD occured.

[irishron]

The first time, no. In that one no heir on the map including the settlement but he had five Generals scattered across three regions. This time I did not check. I just saw one General take off from the settlement before I sieged it.

[irishron]

Double post time.

It did not work. Here are the lines in the log from the settlement capture to the ctd:

Spoiler Alert, click show to read: 

12:27:06.885 [game.script.trigger] [trace] Trigger <triumphs_in_capture> fired
12:27:06.885 [game.script.trigger] [trace] Trigger <0052_T_Invaded_Settlement> fired
12:27:06.885 [game.script.trigger] [trace] Trigger <0052_T_Invaded_Settlement> fired
12:27:06.885 [data.transgression] [info] Applied transgression TC_INVADED_SETTLEMENT from transgressor faction 16A0A540 against faction 16A3169C
12:27:06.982 [system.io] [trace] file open,,data/ui/greek/eventpics/settlement_taken.tga,217282
12:27:06.982 [system.io] [info] open: found data/ui/greek/eventpics/settlement_taken.tga (from: C:\Games\Medieval II Total War)
12:27:06.982 [system.io] [trace] file open,,data/ui/greek/eventpics/settlement_taken.tga,217282
12:27:06.982 [system.io] [info] open: found data/ui/greek/eventpics/settlement_taken.tga (from: C:\Games\Medieval II Total War)
12:27:06.987 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/eventpics/settlement_taken.tga
12:27:06.987 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/greek/eventpics/settlement_taken.tga
12:27:06.988 [system.io] [info] exists: missing data/ui/greek/eventpics/settlement_taken.tga.dds
12:27:06.988 [system.io] [info] exists: found data/ui/greek/eventpics/settlement_taken.tga (from: C:\Games\Medieval II Total War)
12:27:06.988 [system.io] [trace] file open,,219E9370,217282
12:27:06.988 [system.io] [info] open: found data/ui/greek/eventpics/settlement_taken.tga (from: C:\Games\Medieval II Total War)
12:27:06.988 [game.script.trigger] [trace] Trigger <0062_UI_Panel_Captured_Settlement_Trigger> fired
12:27:06.988 [game.script.trigger] [trace] Trigger <0588_Unexplored_Advisor_Request_Help_Trigger> fired
12:27:09.492 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.497 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.501 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.504 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.507 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.511 [system.io] [info] exists: missing mods/RegionMod_Kings/data/ui/generic/bribed_portrait.tga
12:27:09.512 [game.script.trigger] [trace] Trigger <0300K_new_faction_leader> fired
12:27:09.512 [game.script.trigger] [trace] Trigger <Usurper1> fired
12:27:09.544 [game.script] [error] Trigger processing error in <Kingmaker1>
: IsGeneral needs a living character.

when testing <IsGeneral> condition
12:27:09.544 [game.script] [error] Trigger processing error in <Kingmaker2>
: IsGeneral needs a living character.

when testing <IsGeneral> condition

The EDA says:

Spoiler Alert, click show to read: 

;------------------------------------------
Trigger Kingmaker1
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and IsGeneral
and not FactionwideAncillaryExists kingmaker2
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker1 chance 25
;------------------------------------------
Trigger Kingmaker2
WhenToTest BecomesFactionLeader
Condition I_TurnNumber > 0
and IsGeneral
and not FactionwideAncillaryExists kingmaker1
and not FatherTrait Factionleader >= 1
AcquireAncillary kingmaker2 chance 40

The EDCT says:

Spoiler Alert, click show to read: 

;------------------------------------------
Trigger Usurper1 ;asserting new blue blood.
WhenToTest BecomesFactionLeader

Condition Trait Offensive_To_Nobles = 0
and Trait SonofKingPrince <= 0
; and FactionIsLocal ;NEVER ADD THIS IN IT CAUSES A CRASH

Affects Offensive_To_Nobles 1 Chance 3

IsGeneral did not work. What else could we try?

[TNZ]

Irishron: Try this:

;------------------------------------------
Trigger Kingmaker1
    WhenToTest BecomesFactionLeader
    Condition FactionType moors
	  and IsGeneral
	  and I_TurnNumber > 0
	  and not FactionwideAncillaryExists kingmaker2
	  and not FatherTrait Factionleader >= 1

AcquireAncillary kingmaker1 chance 25

[irishron]

The only problem is I would have to do it 27 times, one for each faction. Personally, I have had it to me taking Georgia, Armania, and now Venice.

I added IsGeneral to usurper1 and see if I can force it to pick a general for a usurper and hopefully kingamker will take him. Maybe a shot in the dark but I at least won't know without testing.

I do like your idea. If this does not work, I will defintely test it.

[Gorrrrrn]

IIRC we disabled kingmaker in stainless steel as it didn't work reliably.

[Ishan]

Sir Ron u are using a condition in the EDA "and not FactionwideAncillaryExists kingmaker2" But in that trigger you are not mentioning the faction type it is imperative to assign a particular faction when using that condition.

[irishron]

@Rozanov, I may end up doing the same out of nothing more than frustration.

@Ishan, Is this what TNZ is trying to tell me in his last post?

[Ishan]

@Ishan, Is this what TNZ is trying to tell me in his last post?

Maybe yeah and i use this condition in EDA file in my mod at 4-5 places and we need it, that is the faction type otherwise there is no way to tell the game or to make the trigger work.

[irishron]

If that is the case, for one I owe TNZ an apology for not understanding, and two the EDA just grew a lot. 27 kingmaker1 and 27 kingmaker2.

[Taiji]

You could use CharacterIsLocal and restrict the anc to the player faction, I suppose.