taxable income bonus for colonies

[Spartan 666]

Hi, first of all congratulations on how XC is going on, very nice job! In particular I like those garrison buildings, a nice idea to keep public order in trouble situations.

I have a problem with DTW, I tried to add that taxable_income_bonus bonus 20 entry to the colonies as you have in your EDB.txt, but it results in a CTD. Any idea why? I used this code:

west_colony_1 requires factions { greek, roman, egyptian, }
        {
            capability
            {
                religious_belief christianity 1
                religious_belief christianity 1 requires factions { roman, seleucid, carthage, greek_cities, slavs, macedon, romans_brutii, germans, britons, }
                religious_belief christianity 1 requires factions { egypt, thrace, } and building_present barracks_greek
                taxable_income_bonus bonus 20 requires factions { roman, seleucid, carthage, greek_cities,  slavs, macedon, romans_brutii, germans, britons, }
                taxable_income_bonus bonus 20 requires factions { egypt, thrace, } and building_present barracks_greek
             }
            construction  2 
            cost  2400 
            settlement_min town
            upgrades
            {
            west_colony_2
            west_native
            }
        }

The code in black is fully working. The game crashes when I add the code marked in red. Plus, I tried both with and without the conditionals in the tax bonuses, it crashes all the same.

[Zarax]

A likely culprit is the number of factions covered by the bonus, try putting 8 or less, I'll try taking a better look when I get home.

[CaesarVincens]

Otherwise, it may be the religion line. From my testing, religion bonuses don't work with building conditions.

[Spartan 666]

@ Zarax: thanks!

@ Caesar: sorry, I wasn't clear enough in my first post (I edited it, it's much better now). The code I posted works, even the building conditionals with religion bonuses. It's the tax bonus that doesn't work, even without building conditionals.

[CaesarVincens]

Try putting the tax bonuses before the religion bonuses and see if that works, just on an off chance.

[Spartan 666]

It crashes all the same. It crashes even with the trade bonus.

[Zarax]

Spartan, which exe are you using?

[Spartan 666]

ALX, I simply refuse to use any other .exe if the mod has ALX compatibility...

[Zarax]

Try to check if it's an ALX only problem.

[Spartan 666]

Nope, it crashes also with RTW and BI.

[Zarax]

Ok, did you try putting less factions in?

[Spartan 666]

Yes, I tried to remove all the require factions stuff, but invain. For the game to crash it is sufficient to add ANY bonus, doesn't matter which bonus and how many or which factions that bonus is for.

[Zarax]

Extremely weird.
Here's XC equivalent and it doesn't CTD...

barb_colony_1 requires hidden_resource nobuild or factions { romans_brutii, germans, slavs, }
        {
            capability
            {
                religious_belief christianity 1 requires not factions { barbarian, }
                religious_belief christianity 2 requires factions { barbarian, }
                religious_belief christianity 1 requires factions { romans_brutii, germans, slavs, }
                taxable_income_bonus bonus 20 requires factions { romans_brutii, germans, slavs, }
            }

[Spartan 666]

I know, also XGM uses a similar code and it doesn't crash, that's what surprises me. The only difference is that DTW's code has some building conditionals, but they are for the religion bonus (and they work) and not for the tax or trade or law or whatever bonus.

[CaesarVincens]

Have you actually tried removing all of the conditions for the religion bonuses? I have a strong feeling that that will fix the problem. I tried to do conditionals with religion bonuses some time back but found that they wouldn't work.

[Spartan 666]

That might work but it would damage the cultural system for mixed factions (egypt is greek\eastern and thrace is greek\barbarian). Anyway the game works with those conditions, maybe you don't remember but it was you that helped me coding it!

[CaesarVincens]

I remember helping with the coding, but I forgot some of the specifics.

Well, all I can say at this point is I'm stumped. You're sure there is nothing else that might be causing the problem?

[Spartan 666]

Honestly I have no idea. Now the game doesn't crash at campaign start before the map appears, but when I open the construction panel and right-click on the colony building.

If you have a couple of minutes, this is the latest EDB.txt, without taxable bonuses, I really can't see anything wrong. The colony buildings are at the very bottom of the file.