Script Validator

[Pat89]

lol - what's the difference?
But was the bug itself reported correctly?

Fixed it for the next version though, thanks

[tone]

No it wasn't a bug in the script.
The other thing I've noticed is that it's picking up (presumably different) ascii symbols for white space between words and reporting those.

[HouseOfHam]

Does it check for lines containing both "not" and a condition that uses a logical operator?

[Pat89]

Can you give an example of what you mean?

Like "if not I_CompareCounter CounterX = 3"?

I think it does check that, but I would have to check it to be sure.

[Killerbee]

I think it does check that, but I would have to check it to be sure.

^i like

[Pat89]

I added a function in v1.3 to check for region names in the I_SettlementExists and I_SettlementOwner conditions, by reading descr_regions.txt (based on HouseOfHam's Settlement Coordinate Locator)

I haven't added it for "I_SettlementSelected" yet...

[chris10]

Great tool
Iam a sort of greeny on scripting issues so be nice if I get something wrong in my ignorance
I used your Validator on various scripts and found that it does not recognize the shadowing or shadowed_by feature introduced with BI.
Entry Example from the descr_sm_factions.txt: romans_brutii, shadowed by Thrace
To make use of the shadow feature the faction name has to have a comma while in the actual script there is no comma...so the Validator comes up with loads of error messages "unrecognized faction".
Maybe there is a way to bypass this in a future version as on a long scripts the list of error entrys will veeeery long just for this little issue

[Pat89]

Good point, hadn't thought of that... Though you can change the faction names manually after reading them

[chris10]

Though you can change the faction names manually after reading them

...the faction names dont have to be changed...these are false positives......
not a big problem with small scripts but when they get 9000 lines or longer....puuuuuhhh...if one has 500 false positives its easy to oversee a real error....
nevermind...great tool anyway

I post you an example of an error log full of false positives.
You will see one real error within the others which can be easily overseen...

[Pat89]

...the faction names dont have to be changed...these are false positives......
not a big problem with small scripts but when they get 9000 lines or longer....puuuuuhhh...if one has 500 false positives its easy to oversee a real error....
nevermind...great tool anyway

I post you an example of an error log full of false positives.
You will see one real error within the others which can be easily overseen...

What I meant, is that you can change the faction name the tool uses after you've read them from descr_sm_factions.txt, like this:





So all you have to do is to ensure the faction names listed in the tool are the correct ones and you won't get any errors...
(make sure to remove any comas and such as well...)

[Bardo]

Very useful tool! even more now it checks for faction and region names

If you remember, some time ago we talked about the proper use of the condition GarrisonToPopulationRatio, because it appears GarrisonSettlementRatio in the sample use of the docudemon.
Sorry if I waited so long time to check it...

Let me confirm your validator is right, and this is the proper use:

GarrisonToPopulationRatio > 0.35

While it seems the condition I was using "GarrisonSettlementRatio"does nothing.

[chris10]

What I meant, is that you can change the faction name the tool uses after you've read them from descr_sm_factions.txt, like this:
So all you have to do is to ensure the faction names listed in the tool are the correct ones and you won't get any errors...
(make sure to remove any comas and such as well...)

...uhhhh....of course.....

[Pat89]

Very useful tool! even more now it checks for faction and region names

Great! Thanks

If you remember, some time ago we talked about the proper use of the condition GarrisonToPopulationRatio, because it appears GarrisonSettlementRatio in the sample use of the docudemon.
Sorry if I waited so long time to check it...

Let me confirm your validator is right, and this is the proper use:

GarrisonToPopulationRatio > 0.35

While it seems the condition I was using "GarrisonSettlementRatio"does nothing.

Thanks a lot for testing that! Very good to know! (especially since I was about to use it myself as well )

[Pat89]

In the export_descr_advice file, I found these things (marked in red - scroll down to see the others):

;------------------------------------------
AdviceThread Character_Suggested_Action_Attack_Enemy_Thread
    GameArea Campaign

    Item Character_Suggested_Action_Attack_Enemy_Text_01
        Suppressible y
        Uninhibitable
        Verbosity  3
        Threshold  1
        MaxRepeats  100
        RepeatInterval  3
        Attitude Normal
        Presentation Default
        Parameter TargetCharacterName
        Title Character_Suggested_Action_Attack_Enemy_Text_01_Title
        Text Character_Suggested_Action_Attack_Enemy_Text_01_Text1
        Text Character_Suggested_Action_Attack_Enemy_Text_01_Text2
        Text Character_Suggested_Action_Attack_Enemy_Text_01_Text3
        Text Character_Suggested_Action_Attack_Enemy_Text_01_Text4



;------------------------------------------

AdviceThread Character_Suggested_Action_Attack_Settlement_Thread
    GameArea Campaign

    Item Character_Suggested_Action_Attack_Settlement_Text_01
        Suppressible y
        Uninhibitable
        Verbosity  3
        Threshold  2
        MaxRepeats  100
        RepeatInterval  4
        Attitude Normal
        Presentation Default
        Parameter TargetSettlementName
        Title Character_Suggested_Action_Attack_Settlement_Text_01_Title
        Text Character_Suggested_Action_Attack_Settlement_Text_01_Text1
        Text Character_Suggested_Action_Attack_Settlement_Text_01_Text2
        Text Character_Suggested_Action_Attack_Settlement_Text_01_Text3
        Text Character_Suggested_Action_Attack_Settlement_Text_01_Text4



;------------------------------------------
AdviceThread Character_Suggested_Action_Patrol_Region_Thread
    GameArea Campaign

    Item Character_Suggested_Action_Patrol_Region_Text_01
        Suppressible y
        Uninhibitable
        Verbosity  3
        Threshold  2
        MaxRepeats  100
        RepeatInterval  4
        Attitude Normal
        Presentation Default
        Parameter RegionName
        Title Character_Suggested_Action_Patrol_Region_Text_01_Title
        Text Character_Suggested_Action_Patrol_Region_Text_01_Text1
        Text Character_Suggested_Action_Patrol_Region_Text_01_Text2
        Text Character_Suggested_Action_Patrol_Region_Text_01_Text3
        Text Character_Suggested_Action_Patrol_Region_Text_01_Text4



;------------------------------------------

Etc etc...

In short, the "parameters" I found in this file are:

• SettlementName
• TargetSettlementName
• RegionName
• TargetRegionName
• CharacterName
• TargetCharacterName

Only the first one exists in the docudemons, the others don't.

Does anyone have an idea if those can somehow be used as condition in a script? (and if I should add it to the validator). Of course I can test it myself, but if someone else already did, I would be duplicating work

[Squid]

My theory on those, I ran into them when adding advice validation to ATVTW, is that they are values you can refer to in export_ancillaries to have really customized messages. None of the advice threads actually make use of them, and I haven't tried adding them to advice threads to test. There are few others that you don't mention listed in the exe but I can't remember what they are right now.

[Aradan]

Well, they don't work in traits at least. They return true all the time, so they are probably treated as invalid conditions.

[Squid]

They aren't conditions, I think they're parameters that can be used in the text description for the advice items.

[Aradan]

Well yes, I know, I just tried to see if they could be used in any way in traits (and therefore scripts). And I couldn't imagine of any other way one could use them in scripts/traits other than as conditions.

[Pat89]

Ok, pity they don't work...

Well yes, I know, I just tried to see if they could be used in any way in traits (and therefore scripts). And I couldn't imagine of any other way one could use them in scripts/traits other than as conditions.

Especially as one of them (SettlementName) is a condition as well.

[Pat89]

Does anyone know what the ! in some conditions does? Currently the validator notifies it as a bug, but it's also used in the RTW prologue script:

;;;;**********************************************************************************************
;;;;    wait for end deployement
;;;;**********************************************************************************************

    while ! I_BattleStarted
    end_while