ATVTW - Trait/Ancillary Validator

[Gigantus]

You'r da man!

[izanagi11]

This is a lifesaver, thanx for the new update!

[irishron]

[Theodotos I]

The three attributes are: Generosity, Boldness and Disposition. So Gigantus if you've got some time and want to toss those into a trait and load up M2TW and Kingdoms and see if the game barfs on those attributes it would be appreciated.

Just a little note here: Those three attributes do work in-game, however, I have yet to see them exert any effect on gameplay. The game accepts them fine, but there doesn't seem to be any effect. Either they were never fully implemented, or I'm using them for the wrong characters. Will continue to experiment and report back.

[Kahvipannu]

Thank you so much for this

[Squid]

Version 2.1.0

This is a new feature release:

Improvements:

• Will scan scripts and if it finds any traits/ancillaries will check to make sure they exist
• When scanning descr_strat if a trait/ancillary is being assigned to a faction from a culture that is excluded from acquiring the trait/ancillary this will be reported as an error

Changes from 2.0.7 Version:

• Fixed bug where in RTW if you weren't using religion not all settlement names would be read correctly
• Fixed a bug when reading enums where the enums in game text is multiple lines in length
• Fixed the contents of the form not resizing when the window is resized
• Fixed bad spacing in various error/warning messages
• Fixed the move to end of list and move forward 1 buttons
• Can scroll when moused over the status window
• Can now double-click on a setting to open it
• Can now right-click and delete a selected setting
• Added in the I_FactionLeaderTrait and I_FactionLeaderAttribute conditions for M2TW (I'd swear I'd already added them)

Go to the first post to get the new version.

[Gorrrrrn]

This prog saves hours of looking through all the files - does the job very quickly and efficiently.
Pretty much essential to any mod that touches on traits etc.

(Now to work out why Combat_V_Faction_ (factionname) only works for some factions and not others.)

[gracul]

Great Tool!
Now 1 question, is it only me, or does the program always show all ancillaries as orphans? Traits orphans check works fine.

[Squid]

There's definitely a problem with the orphans code right now. Thanks for pointing it out, I'm working on a fix.

[gracul]

Well, other noticeable bugs would include:
not recognising any integer.integer as a 'double value' (Error: For condition GeneralHPLostRatioinBattle, 0.8 is not a valid 'double value'.)
not recognising byzantium as a faction (Error: For condition FactionType, byzantium is not a valid 'faction type'.)

[Squid]

Well, other noticeable bugs would include:
not recognising any integer.integer as a 'double value' (Error: For condition GeneralHPLostRatioinBattle, 0.8 is not a valid 'double value'.)
not recognising byzantium as a faction (Error: For condition FactionType, byzantium is not a valid 'faction type'.)

I'd need to see your file set your using the program with. The first the trigger Battle_General_Took_Hits trigger in vanilla m2tw correctly recognizes 0.3 as a double value so I'm wondering if you've accidentally used a O instead of 0 in the number or some other odd character for a period. For the second in the vanilla files it recognizes byzantium in the trigger random_birth_byzantium.

[gracul]

If i would use a period or an O, or if byzantium would not be a faction type - system.log would throw me out errors which is not the case.

Attachement:

[Squid]

I've run your files through both the currently released version and the one I'm currently working on (which fixes the orphans problem) and the byzantium error is because its not adding byzantium to the list of valid factions because there's a comma missing after the color red in the primary color line (line 387 I believe). Add that comma and the byzantium error disappears. As for the GeneralHPLostRatioinBattle error, I can't reproduce it with either the current version or my in progress version.

Thanks though for the files, it pointed out at least another dozen error or bugs in my code which will be fixed in the next release.

[gracul]

Wow, thanks!

Well, this is the only thing I can actually give:

[Squid]

Now I'm confused. I'm looking at the exact same trigger running on the exact same version of the program (I downloaded it again today) and it says no errors or warning for the trigger. What's the exact version of .Net Framework are you using? There's got to be something different about your computer because I'm not getting the same behaviour as your seeing with the same version of the program and the same files.

[gracul]

.Net Framework: 3.5.30729.01

[Gorrrrrn]

Q: would the missing comma refered to above in the descr_sm_factions.txt file have other effects?

I had a problem with a campaign_script line:
console_command diplomatic_stance teutonic_order byzantium war - other factions parsed correctly, but not the byzantium one.

[gracul]

Yeah that's probably it.

Another thing is, could you change the trait parser so that if a trait is hidden, it won't throw out errors when there is no description in vnvs.txt?

[Squid]

Q: would the missing comma refered to above in the descr_sm_factions.txt file have other effects?

I had a problem with a campaign_script line:
console_command diplomatic_stance teutonic_order byzantium war - other factions parsed correctly, but not the byzantium one.

The game engine is weird it can function with incorrectly formatted files, but what the game does (or doesn't do) with incorrectly formatted files is anyone guess. For example in EDB and EDCT/EDA files in RTW (and likely M2TW as well) you should never have tab characters. The files will work properly up until some random number or placement of tabs and then will CTD. Do nothing else but remove all tabs and everything is good again.

My guess is you have something wrong with the byzantium entry and the engine is having issues with it.

Yeah that's probably it.

Another thing is, could you change the trait parser so that if a trait is hidden, it won't throw out errors when there is no description in vnvs.txt?

I could do that, but I'd hesitate to remove it entirely and might make it a warning. In case you weren't aware you can use the a vnv entry multiple times. So in my EDCT all traits that are hidden use hidden_level_name hidden_desc and hidden_effects_desc which says basically this trait should be hidden contact me if you see it.

[Gorrrrrn]

tx for that squid - the only difference was a space after the final letter of war.
have removed and am hoping for the best!
(won't fire until T260.)

(tabs and spaces can cause all sorts of problems - but sometimes it wants a tab and not a space.)
--
back to topic ......

(update - the Byz thing is now fixed in the script - works properly now.)