ATVTW - Trait/Ancillary Validator

[Squid]

I wish they'd been consistent, either always require tabs in all files, or always require spaces in all files. The mixing and matching irritates me and is a pain to code for.

[gracul]

Ok. I understand.
Because i live in Poland i have the polish ver of windows.
In eng versions the system separator is a dot ("."), however in poland we use a comma (",").
.NET is stupid when it comes to this, as it reads the system separator (thats a , for me)

static System.Globalization.NumberFormatInfo ni = null;
public ParserClass()
{
System.Globalization.CultureInfo ci =
System.Globalization.CultureInfo.InstalledUICulture;
ni = (System.Globalization.NumberFormatInfo)
ci.NumberFormat.Clone();
ni.NumberDecimalSeparator = ".";
}

and use:
double.Parse(myNumber,ni);
instead of just
double.Parse(myNumber);

[Squid]

OK, I'll code for that for the parse double (which I'm changing to parse decimal).

[gracul]

Hmm can't wait to get my hand on the updated tool....

[Squid]

Version 2.1.1

This is a bug fix release:

Changes from 2.1.0 Version:

• Fixed the Orphans check to correctly identify orphans
• Fixed various condition arguments not being checked
• Added checking for a few condition arguments that were not being checked
• Changed trait levels of hidden traits to report missing enum entries as warning instead of errors
• Fixed bug when checking double values if your cultures separator is not the period (.)
• Changed double checks to decimal checks (as all value are decimals not doubles)
• Fixed doubling of display of a condition if its requirement wasn't met
• Fixed a various conditions/events not having the proper exports
• Fixed more formatting in error messages.
• Fixed conditions IsRegionOneOf and IsTargetRegionOneOf to not report errors if there are no region names read
• Moved a bunch of code from the ATVTW.exe to the TWLibrary.dll for reuse with other projects I'm working on

Go to the first post to get the new version.

[Gigantus]

Please put the download more to the top of the post (under the version notice?), by now it takes a while to scroll to the bottom of that post.

[Squid]

I'm confused, the size of the post hasn't changed unless the spoiler tags aren't working for you, but I moved it to the top anyways.

[Gigantus]

I think it was something with the spoiler for me, it's working now, thanks.

[gracul]

Thanks for this great release. battlemodels.modeldb checker soon?

[Gigantus]

Thanks for this great release. battlemodels.modeldb checker soon?

That one exists.

[Gigantus]

Didn't use the edit button because this might otherwise not register:

When I am trying to open a setting I get an error window. No problem if I create a new setting (which will not work later once I try the 'open' function). Screenshot attached. And I am using the latest version, downloaded again just to make sure.

.

[Squid]

What the details from the error window?

[Gigantus]

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at ATVTW.OpenSettingsForm.<ReadSettings>b__4(<>f__AnonymousType0`2 <>h__TransparentIdentifier0)
at System.Linq.Enumerable.<>c__DisplayClass12`3.<CombineSelectors>b__11(TSource x)
at System.Linq.Enumerable.<>c__DisplayClass12`3.<CombineSelectors>b__11(TSource x)
at System.Linq.Enumerable.<>c__DisplayClass12`3.<CombineSelectors>b__11(TSource x)
at System.Linq.Enumerable.WhereSelectArrayIterator`2.MoveNext()
at ATVTW.OpenSettingsForm.ReadSettings()
at ATVTW.OpenSettingsForm..ctor()
at ATVTW.ATVTWForm.mnuFileOpen_Click(Object sender, EventArgs e)
at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.ToolStrip.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4200 (NetFxQFE.050727-4200)
CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
ATVTW
Assembly Version: 2.1.1.66
Win32 Version: 2.1.1.66
CodeBase: file:///C:/MyGames/Medieval%20II%20Total%20War/mods/ATVTW.exe
----------------------------------------
System.Windows.Forms
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4016 (NetFxQFE.050727-4000)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4205 (VistaSP2GDR.050727-4200)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
Assembly Version: 2.0.0.0
Win32 Version: 2.0.50727.4016 (NetFxQFE.050727-4000)
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------
TWLibrary
Assembly Version: 1.1.0.66
Win32 Version: 1.1.0.66
CodeBase: file:///C:/MyGames/Medieval%20II%20Total%20War/mods/TWLibrary.DLL
----------------------------------------
System.Core
Assembly Version: 3.5.0.0
Win32 Version: 3.5.30729.1 built by: SP
CodeBase: file:///C:/Windows/assembly/GAC_MSIL/System.Core/3.5.0.0__b77a5c561934e089/System.Core.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
<system.windows.forms jitDebugging="true" />
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

[Squid]

That is weird, there should be no null pointer exception there. Its behaving as if the registry key where the setting information is stored is not there or you can't read it. Are you running the program as an administrator? Could you export the registry key in question (it will be HKCU\Software\ATVTW\Settings\<settings name>) so I can see what exactly is in that entry?

[Gigantus]

even when I right click and choose 'run as administrator' the error persists.

Here you are, the registry key.

[gracul]

Perhaps rather then using registry entires, ATVTW should only be storing info in a simple .ini file? Using ini is much easier then reading/writing registry in C++ anyway

[Squid]

Not really, if I put in an ini I'd need to parse the file, but there's already tools in place that allow me to read from the registry and not have to worry about any parsing. Its also less prone to user error and deletion.

[Squid]

Gigantus, I've looked at your registry entries, and the problem is with the 1648 Key settings (i.e. [HKEY_CURRENT_USER\Software\ATVTW\Settings\1648]) it is missing a path value, and that missing path value is causing ATVTW to crash. If you delete that key the open will run correctly again.

EDIT: The next version will load default values so that if a value gets deleted from key it won't cause the program to crash

[Gigantus]

Works fine now, removed all the 'desperate' entries as well. Thanks for the tool.

[Squid]

Version 2.1.2

This is a bug fix release:

Changes from 2.1.1 Version:

• Fixed crash when reading a corrupted setting (the setting now gets deleted)
• All tabs now resize properly
• Ancillary tab now loses unneeded entries when reading RTW ancillaries (type and transferable)
• GeneralWithAncKilled now check for ancillary type instead of ancillary name
• Fixed script checking which was not working in any useful fashion
• Added a few extra condition to the script checker to check
• Added ability to edit existing settings
• Internal code change in an attempt to speed up file processing

Go to the first post to get the new version.