AntiTrait Problem

[Theodotos I]

Okay, I seem to be having some issues working with antitraits here. As far as I can see, my antitraits are set up the same way as vanilla.
Traits:
;-----------------------------------------------
Trait Unlicense
Characters merchant
AntiTraits License

Level Unlicensed
Description Unlicensed_desc
EffectsDescription Unlicensed_effects_desc
Threshold 1

Effect Finance -1

;-----------------------------------------------
Trait License
Characters merchant
AntiTraits Unlicense

Level Licensed
Description Licensed_desc
EffectsDescription Licensed_effects_desc
Threshold 2

Effect Finance 1

Trigger:
;------------------------------------------
Trigger Spanish_merchant4
WhenToTest CharacterTurnEnd
Condition AgentType = merchant
and EndedInSettlement
and CharacterNumTurnsIdle >= 2
and Trait Unlicense >= 1
and not Trait ShadyDealer >=1
and not Trait ServesSelfMerchant >= 1
and not Trait EnemyTrade >= 1
and SettlementBuildingExists >= consulado_seville_guild

Affects License 2 Chance 100

Pictures. Here’s the before picture

Spoiler Alert, click show to read: 

The trigger fires, and the character’s finance increases, but I don’t see the Licensed trait.

Spoiler Alert, click show to read: 

Noob question here: Am I supposed to?

[Squid]

What the trigger that gives the unlicenced trait? My guess is that the unlicenced trait has more than 1 point in it.

[Augustus Lucifer]

The problem is that he doesn't have the trait yet. You have 1 Threshold on Unlicensed, when you add 2 to that it should end up with 1 in the AntiTrait, and the threshold for Licensed is 2. Try changing the trigger to Affect it 3 instead. You can tell he doesn't have the trait because his finance only changed by one, not two(the difference between -1 and 1).

[Theodotos I]

The problem is that he doesn't have the trait yet. You have 1 Threshold on Unlicensed, when you add 2 to that it should end up with 1 in the AntiTrait, and the threshold for Licensed is 2. Try changing the trigger to Affect it 3 instead. You can tell he doesn't have the trait because his finance only changed by one, not two(the difference between -1 and 1).

Change the trigger on License to 3? Thanks, I'll try that.

[Squid]

That does fix the fact the the trigger for unlicenced is faulty and is giving more points to it than it should. Given the above screens you have a problem with your trigger that gives the unlicenced trigger. Unless that's fixed the best that following AL suggestion will give you is a temporary band-aid solution.

[Theodotos I]

Well, AL's solution has fixed it. At least, that's the way it looks and I just tested it about seven times. Basically the Unlicensed trait is given on unit creation and tied in with a hidden trait. I will have to remember this about antitraits in the future. I've had this problem before.

[Squid]

Nvm, the actual problem is that you have the threshold for licenced set to 2, it should be set to 1, and leave the triggers as they were initially. AL solution will fix the problem, but is inelegant, and will make it more difficult when you go back later to figure why you did it that way.

[Theodotos I]

I feel a little thick at the moment--I'm not putting together what you're saying. That's the way I had it originally--didn't seem to work. Then I put it together as above, still didn't work. Now, I'm using AL's solution, it's working, but I do see logic difficulties should I want the trait to revert back. I'm not sure I'm comprehending your advice.

[Augustus Lucifer]

What he's saying is instead of using Affects 3, keep it at Affects 2 for the trigger, but change the Threshold for the Licensed trait to 1 instead of 2.

Think of it like an anti-trait is the negative number corresponding to its threshold. So Unlicensed is -1 and Licensed is 1 in terms of threshold. When you add to unlicensed you are subtracting the Affects value, and Licensed you are adding it.

So [-1(Unlicensed Threshold) + 3(Affects) = 2(Licensed Threshold)]. If you change the Licensed Threshold to 1 instead, you'd have [-1(Unlicensed Threshold) + 2(Affects) = 1(Licensed Threshold)].

The game doesn't necessarily interpret one as negative and one as positive, and it can take multiple AntiTraits, but it's an easy way to illustrate it.