Lesson 1

[Augustus Lucifer]

Worst script ever.

so that's where all my money was going...

[B. Ward]

lulz...I told you...the mod is designed for you to lose...period.

[Killerbee]

Hehe , there's an error in it (well at least it looks so) There's 1 comment that's not behind a ";" .. Although this might change when you copy paste it in notepad

[B. Ward]

Which comment? They all look right to me. What's your screen size?

[Killerbee]

This one at the end :

; Yes, this script is designed for you to lose. Nothing about making the game harder, only to see you fail since the AI sucks just that much. Besides, I got this kick ass losing video for you. You should check it out.

But as i said , this may be resolved when you put it in notepad or something ..

[B. Ward]

You posted right behind me before I edited. It might be your screen's resolution. All that's on one line on my screen.

[Killerbee]

Ah , excuse me in that case

[B. Ward]

No issue. Thanks for that nonetheless.

[GrnEyedDvl]

You tease us with a video, then dont display it?? Epic fail...

[Benz282]

Here's my first script. Are we supposed to test these when we are done? And if so, how are we to do so?

Spoiler Alert, click show to read: 

;#########################################
;##_____________________________________##
;##_____________+-LESSON 1-+____________##
;##_____________________________________##
;#########################################

;
;Start Lesson 1
;
;Objective:
; - 4 Monitors for one faction
; - Add or subtract money based on situation
;

script

;Let's start out with something simple
monitor_event FactionTurnEnd FactionType england
and not FactionIsLocal
console_command add_money england, -10000
end_monitor

;Now, to rectify the situation
monitor_event FactionTurnEnd FactionType england
and not FactionIsLocal
and not Treasury > 0
console_command add_money england, 15000
end_monitor

;Let's go to war, shall we?
monitor_event FactionTurnEnd FactionType england
and not SupportCostsPercentage > 50.4
and not OnAWarFooting
and not I_FactionBesieging england
console_command add_money england, 5000
end_monitor

;Got a bit over your head there? Here's some help
monitor_event FactionTurnEnd FactionType england
and OnAWarFooting
and not I_NumberOfSettlements england > 4
and not Treasury > 7500
and I_LosingMoney england
console_command add_money england, 100000
end_monitor

wait_monitors

end_script

;
;End Lesson 1
;

[Astaroth]

In order to test your script, you need a working mod folder to begin with (see here). Then you have to put the script into (your mod's) data/world/maps/campaign/imperial_campaign/campaign_script. Afterwards, start your mod and test your script in-game. If your script increases England's treasury by 10,000 at the end of the turn for example, simply check whether this actually happens.

[Augustus Lucifer]

Looks fine Benz. Like I suggested in another thread, you don't need to use "and not" with conditions that use logic tokens(<, <=, >, >=, ==). It makes more sense to people reading the script to use for instance:

and Treasury <= 0

As opposed to:

and not Treasury > 0

They mean the same thing.

[Subuatai de Bodemloze]

I just got kingdoms installed tonight, again.... will try and write the code up tomorrow at work and test it tomorrow night.

[Squid]

Sorry for being late, but here's mine:

Spoiler Alert, click show to read: 

;**********Scripting 101 Lesson 1 - Money Script**********
;|Author| Squid
;|Purpose| Add/Remove money to/from specific factions
;|Changelog|
; - Script Created 20/06/2009

script

monitor_event FactionTurnStart FactionType england
and OnAWarFooting
console_command add_money england, -1000
end_monitor

monitor_event FactionTurnStart FactionType england
and LosingMoney
and Treasury < 1000
console_command add_money england, 5000
end_monitor

monitor_event FactionTurnStart FactionType england
and Treasury >= 10000
console_command add_money england, -1000
end_monitor

monitor_event SettlementTurnEnd FactionType england
and BuildingQueueIdleDespiteCash
console_command add_money england, 2000
end_monitor

wait_monitors

end_script

Just an interesting tidbit, since most mods keep all factions at war with the slave faction, the OnAWarFooting condition will always return true.

[Benz282]

Just an interesting tidbit, since most mods keep all factions at war with the slave faction, the OnAWarFooting condition will always return true.

Hm...never thought of that

[Augustus Lucifer]

Sorry for being late, but here's mine:

Spoiler Alert, click show to read: 

;**********Scripting 101 Lesson 1 - Money Script**********
;|Author| Squid
;|Purpose| Add/Remove money to/from specific factions
;|Changelog|
; - Script Created 20/06/2009

script

monitor_event FactionTurnStart FactionType england
and OnAWarFooting
console_command add_money england, -1000
end_monitor

monitor_event FactionTurnStart FactionType england
and LosingMoney
and Treasury < 1000
console_command add_money england, 5000
end_monitor

monitor_event FactionTurnStart FactionType england
and Treasury >= 10000
console_command add_money england, -1000
end_monitor

monitor_event SettlementTurnEnd FactionType england
and BuildingQueueIdleDespiteCash
console_command add_money england, 2000
end_monitor

wait_monitors

end_script

Just an interesting tidbit, since most mods keep all factions at war with the slave faction, the OnAWarFooting condition will always return true.

Looks fine. And yeah if it does that it's a pretty useless condition. It should be possible to replicate its purpose by checking diplomatic agreements/stances but I haven't really looked into it.

[GrnEyedDvl]

Actually I did a tiny bit of testing with OnAWarFooting and I dont think it triggers that way but its been a long time and my memory might be a bit off on this.

The AI decision tree has no real entries regarding slaves, either for attacking them or defending them. For purposes of the game the AI doesnt consider them a threat, so they default is "defend_minimal" and "invade_priority" = 0.

I dont think OnAWarFooting triggers until a certain amount of points has built up regarding a certain faction. I did do some stuff with using a TargetFactionType condition with OnAWarFooting but cant remember how that turned out.

It should be easy to test if it always fires true though:

 monitor_event FactionTurnEnd FactionIsLocal
    and OnAWarFooting ; TrueCondition if needed, then test TargetFactionType
 
    historic_event test_event
end_monitor

[Squid]

I wouldn't assume it has anything to do with the AI decision tree but rather the diplomatic stances that are established for the various factions. Admittedly my sample is small, and based mostly on RTW, but OnAWarFooting seems to be true if you are at war with a faction, regardless of how much of a threat they are. Hence my comment about the slaves which every faction is usually, if not always at war with. Everyone always being at war with the slaves causes the condition to be true all the time.

The main problem is the documentation on the condition is somewhat sparse and doesn't provide a lot of detail.

[GrnEyedDvl]

I wouldn't assume it has anything to do with the AI decision tree but rather the diplomatic stances that are established for the various factions. Admittedly my sample is small, and based mostly on RTW, but OnAWarFooting seems to be true if you are at war with a faction, regardless of how much of a threat they are. Hence my comment about the slaves which every faction is usually, if not always at war with. Everyone always being at war with the slaves causes the condition to be true all the time.

I will try and remember to check that later.

The main problem is the documentation on the condition is somewhat sparse and doesn't provide a lot of detail.

I say that with all the documentation.

[Squid]

As a coder, don't I know it!! I've been, and I'm sure continue to be, guilty of it as well.