Need to tweak some files...

**Gnostiko** · October 20, 2008, 05:26 PM

I've had a couple of family members either marrying, or born, into the royal family with the name of....

wait for it - ";"

Yes, that's right, I get prince semi-colon :-\
If someone could tell me how to nix that I'd appreciate it.

Oh, another thing. I suppose it's more of a problem for the CBUR team, but no one seems to be active on their forums, and it's a problem that doesn't necessarily require specialist knowledge, so I think someone here might know what to do - basically a (supposed-to-be) Byzantine-only trait pops up in non-byzantine campaigns and I need to obviously relegate it to well...just the Byzantines! :p

Thanks!

**aduellist** · October 21, 2008, 03:09 AM

I don't have that sub-mod installed, but I can tell you what to look for on the traits issue. Check export_descr_character_traits.txt. Find the traits triggers you need to fix and add the condition:

Code:

          and FactionType byzantium

**Gnostiko** · October 21, 2008, 07:31 AM

Hmmm, thanks, but I don't see any trait triggers...where should I copy/paste?

**aduellist** · October 21, 2008, 12:47 PM

The entire bottom half of export_descr_character_traits.txt is triggers.

Example:

Code:

;------------------------------------------
Trigger Royal_Blood_Greek_FactionHeir
    WhenToTest CharacterTurnStart

    Condition FatherTrait Royal_Founder > 0
          and FactionType byzantium
    and Trait Royal_Blood_Greek = 0
    and OriginalFactionType byzantium
    and Trait BiologicalSon > 0
          
    Affects Royal_Blood_Greek  1  Chance  100

Edit: Here's a post I made a while ago about finding traits based on text in UI:

http://www.twcenter.net/forums/showthread.php?p=3115572

Once you've identified the actual trait name, search export_descr_character_traits.txt for the trigger for that trait. That's where you'll need to insert the condition.

**Gnostiko** · October 21, 2008, 04:41 PM

Okay, I managed to find it at the bottom...problem is I can't tell a) which one is 'just' Comes and b) where to insert your trigger. I mean I can see where there is a trigger for Comes to the next rank, so logically the one before should be the trigger for Comes, but I just wanted to post here to make sure. I don't know whether I should add a conditional for just Byzantium to the other ranks, since it's only 'Comes' that other factions tend to get, and neither I nor anyone else (that I've seen) has gotten a family member with another rank higher than that.

Can you please point out where to insert the trigger?

Spoiler Alert, click show to read:

**aduellist** · October 21, 2008, 11:00 PM

All the triggers you posted have the necessary condition.

Okay, I downloaded and extracted the files and I think I've found the problem. It's these triggers:

Spoiler Alert, click show to read:

None of these triggers are specific to Byzantine characters. The first three will affect characters of any faction, the fourth characters of any orthodox faction. My suggestion would be to comment out the "Military_Career_In_Byzantium" lines in these triggers by putting a ";" at the beginning of the line like so:

Code:

;    Affects Military_Career_In_Byzantium 1 Chance 100

Note: This is NOT save compatible. You'll need to start a new campaign for the trait changes to take effect.

I'd also recommend reporting this as a bug in the BtR forum here, as it's pretty clearly an oversight.

Let me know if that fixes the problem.

Edit: Checked the BtR forum. They are aware of the trait bug and will be correcting it in the next version.

**Gnostiko** · October 22, 2008, 07:03 AM

Wow, thanks aduellist, that was pretty comprehensive help!

Just a couple of last questions though and that should be it

Just to confirm, I just have to insert a ; before all the affects militarycareerbyzantium lines, right?

On the save game compatibility - will it screw up my current game if I edit? That is, I'm not particularly bothered if it doesn't fix the current game I'm playing, so long as the next one is fixed, but I'd rather do the edits now...

**aduellist** · October 22, 2008, 01:38 PM

Originally Posted by Gnostiko

Wow, thanks aduellist, that was pretty comprehensive help!

Just a couple of last questions though and that should be it

Just to confirm, I just have to insert a ; before all the affects militarycareerbyzantium lines, right?

Nope, only the four instances I specified in my post.

Originally Posted by Gnostiko

On the save game compatibility - will it screw up my current game if I edit? That is, I'm not particularly bothered if it doesn't fix the current game I'm playing, so long as the next one is fixed, but I'd rather do the edits now...

I'd make a copy of the file and edit that. Put it aside to swap in when you start your next campaign. I honestly do not know what impact changing the file will have on a current campaign. Might be nothing, might experience odd traits behavior.

**Gnostiko** · October 22, 2008, 04:40 PM

Ok, just fired up a new game, so I'll update on here on whether or not it worked. Ditto for my current Byz game. Just to confirm, sticking those semicolons in did...what exactly?

Thanks!

**aduellist** · October 22, 2008, 05:28 PM

The semicolon is a "comment" character. Anything after a ";" on any given line is ignored by the game. Being the paranoid sort that I am, I'd rather comment something out than delete the line. That way, if something goes horribly wrong, all I have to do to revert is remove the ";" rather than remembering what the line was that I need to reinsert.

**Gnostiko** · October 22, 2008, 08:41 PM

Rrrright....I'm confused now :hmmm:

According to what little I know about modding (mostly from RTW) what you've told me to do reads like I'm stopping Byzantine FM's from racking up traits due to heroic victories and whatnot...or am I so rusty that it's simply just a case of restricting Byzantine military traits to...well, the Byzantines?

**aduellist** · October 22, 2008, 08:58 PM

You're rusty.

The four triggers I posted are not restricted to Byzantine characters and therefor cause non-Byzantine characters to pick up Byzantine traits. The triggers you posted are restricted to Byzantine characters and thus function as intended by the submod creators.

In order to give the Byz traits to only Byz characters in the four instances I cited, you'd need to add new triggers. For example:

Code:

;------------------------------------------
Trigger StandardBattle_CrushingVictory
    WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and BattleSuccess >= clear
          and I_ConflictType Normal
          and BattleOdds >= 0.25
          and BattleOdds < 1.5

    Affects GoodCommander 1  Chance  75 
    Affects Military_Edu  1  Chance  10
    Affects Military_Career_In_Byzantium 1 Chance 100

as it stands would cause a character of any faction to get the Military_Career_In_Byzantium trait.

If you still want that chance for Byz, and only Byz characters, you'd need to do this:

Code:

;------------------------------------------
Trigger StandardBattle_CrushingVictory
    WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and BattleSuccess >= clear
          and I_ConflictType Normal
          and BattleOdds >= 0.25
          and BattleOdds < 1.5

    Affects GoodCommander 1  Chance  75 
    Affects Military_Edu  1  Chance  10
;    Affects Military_Career_In_Byzantium 1 Chance 100
;------------------------------------------
Trigger StandardBattle_CrushingVictory_Byz
    WhenToTest PostBattle

    Condition IsGeneral
          and WonBattle
          and FactionType Byzantium
          and BattleSuccess >= clear
          and I_ConflictType Normal
          and BattleOdds >= 0.25
          and BattleOdds < 1.5

    Affects Military_Career_In_Byzantium 1 Chance 100

Trigger Trigger StandardBattle_CrushingVictory would fire for all factions. Trigger Trigger StandardBattle_CrushingVictory_Byz would fire only for Byzantine characters.

Rinse and repeat for the other three and your fully back to the intent of the BtR team.

**Gnostiko** · October 23, 2008, 01:07 PM

Ha!

Oh boy. Ohhhh boy. Sorry aduellist, but you've lost me

Or...I think you have (God, I am rusty).
Let me just straighten this out from my point of view....

The problem was that characters from factions other than Byzantium were picking up traits intended for Byzantine characters only. Now...when you told me to put those semi-colon's in place that's fixed it right?
I only say this because your last post makes it sound like the semicolons disabled the traits, for everyone, and that to enable them for Byzantines only (as originally intended) I should keep the semicolons as instructed, and add Trigger StandardBattle_CrushingVictory_Byz.

I know, I sound like an idiot...but my experiences with RTW and it's various submods has forced me to always clarify, clarify, clarify. I apologise profusely! :p

**aduellist** · October 23, 2008, 07:54 PM

Originally Posted by Gnostiko

Ha!

Oh boy. Ohhhh boy. Sorry aduellist, but you've lost me

Or...I think you have (God, I am rusty).
Let me just straighten this out from my point of view....

No worries. Just because I fully understand what I'm talking about doesn't necessarily mean that I've explained clearly enough for anyone else to understand.

Originally Posted by Gnostiko

The problem was that characters from factions other than Byzantium were picking up traits intended for Byzantine characters only. Now...when you told me to put those semi-colon's in place that's fixed it right?
I only say this because your last post makes it sound like the semicolons disabled the traits, for everyone, and that to enable them for Byzantines only (as originally intended) I should keep the semicolons as instructed, and add Trigger StandardBattle_CrushingVictory_Byz.

You've pretty much hit the nail on the head.

Original triggers will allow characters from any faction to pick up traits intended for Byz characters only in the four cases described.

Adding the semicolon means no character from any faction will pick up that trait as a result of those conditions.

Adding in the additional trigger means only Byz characters will pick up the Byz trait as a result of those conditions.

Clear as mud?

Originally Posted by Gnostiko

I know, I sound like an idiot...but my experiences with RTW and it's various submods has forced me to always clarify, clarify, clarify. I apologise profusely! :p

Absolutely no apologies necessary. Believe me, there are aspects of this game (like battle_models.modeldb) that completely confuse me and I won't touch, even though there are very detailed tutorials out there on how to modify them. If you had initially done what I told you, without follow-up, your problem with non-Byz characters would have been fixed. But you wouldn't have necessarily understood why. Take the time to ask questions and understand how things work and before you know it you'll be pitching in here to help others fix their issues.

**Gnostiko** · October 23, 2008, 08:53 PM

Right, think I'm 99% sure, now just three final question before I do what should hopefully be the final edit: when I add in the additional trigger, namely the _Byz and factionbyz, am I duplicating the text, or just editing it?

ala

Spoiler Alert, click show to read:

Whereby there are two entries for Trigger StandardBattle_CrushingVictory, or am I just editing the one Trigger standard battle yadda yadda?

Another holdover from my RTW days - does the exact positioning of columns matter? I noticed in your example that the three 'Affects' aren't aligned, which could cause crashes in Rome, so I'm not sure how it works in M2TW.

On a (I suppose unrelated note) while game effects of traits are edited in this file, is the text? Namely, if I edit the bonuses or penalties of a trait, will the textbox for the trait still read as the unedited trait or will it incorporate the edit I make?

A little update as well - the semicolon definitely works for stopping other factions getting the trait, I quickly ran through a Norman and Danish campaign auto_winning to simulate heroic victories and no Byzantine military traits were picked up. Now...just to make sure the Byzantines get their due...

Thanks again!

edit: oh, and keeping in line with the thread title: where I can find text for ancilliaries that need to be edited?

**aduellist** · October 23, 2008, 11:30 PM

Originally Posted by Gnostiko

Right, think I'm 99% sure, now just three final question before I do what should hopefully be the final edit: when I add in the additional trigger, namely the _Byz and factionbyz, am I duplicating the text, or just editing it?

ala

Spoiler Alert, click show to read:

Whereby there are two entries for Trigger StandardBattle_CrushingVictory, or am I just editing the one Trigger standard battle yadda yadda?

You're adding a new trigger, Trigger StandardBattle_CrushingVictory_Byz, by duplicating the existing trigger and removing all effects except "Affects Military_Career_In_Byzantium 1 Chance 100" (without semicolon). If you do the same for the other three triggeres I spotted, you'll be adding another three new triggers (Trigger HeroicBattleCommander_Byz, Trigger BrilliantTacticalCommander_Byz, and Trigger Worthy_Of_Adoption_General_Byz). The same process applies. There's no particular order they have to be in, as long as they're all below the "Start of Triggers" in the file. I usually put the new one right underneath the old one because it makes it easier for me to track the changes I've made. Arrange them however makes the most sense to you.

Originally Posted by Gnostiko

Another holdover from my RTW days - does the exact positioning of columns matter? I noticed in your example that the three 'Affects' aren't aligned, which could cause crashes in Rome, so I'm not sure how it works in M2TW.

AFAIK, it doesn't make any difference in this file, although it does in others. By using the "code" tag in my post, what you're seeing is exactly the formatting I pasted from my game file.

Originally Posted by Gnostiko

On a (I suppose unrelated note) while game effects of traits are edited in this file, is the text? Namely, if I edit the bonuses or penalties of a trait, will the textbox for the trait still read as the unedited trait or will it incorporate the edit I make?

Since you're only adding new triggers, not new traits, no changes need to be made to Stainless_Steel_6\data\text\export_VnVs.txt.

Originally Posted by Gnostiko

A little update as well - the semicolon definitely works for stopping other factions getting the trait, I quickly ran through a Norman and Danish campaign auto_winning to simulate heroic victories and no Byzantine military traits were picked up. Now...just to make sure the Byzantines get their due...

Thanks again!

Glad to hear verification it fixed the problem.

Originally Posted by Gnostiko

edit: oh, and keeping in line with the thread title: where I can find text for ancilliaries that need to be edited?

If you're talking about editing ancillaries themselves (effects and triggers), then Stainless_Steel_6\data\export_descr_ancillaries.txt.

If you mean editing the UI text associated with ancillaries, then Stainless_Steel_6\data\text\export_ancillaries.txt.

**aduellist** · October 24, 2008, 11:21 AM

My bad. You need to delete the .bin file so the game rebuilds it with your changes included.

**Liandro** · June 17, 2010, 09:38 AM

Any possibility you can post this file anywhere for download, that is, the file that regulates the Comes system to only Byzantium (Roman) Members. Thanks.