Page 4 of 10 FirstFirst 12345678910 LastLast
Results 61 to 80 of 182

Thread: ATVTW - Trait/Ancillary Validator

  1. #61
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Aradan View Post
    I've tried inserting two-three non-existent traits in differently formatted triggers (different number of conditions, events, etc) and it didn't catch any of them, so I guess the former.


    EDIT: Also, on NI, I get an Unhandled exception error when loading ATVTW with the following log:

    Spoiler Alert, click show to read: 

    Code:
    ************** Exception Text **************
    System.NullReferenceException: Object reference not set to an instance of an object.
       at ATVTW.CustomLists.RTWReligion(Options options, Settings settings)
       at ATVTW.CustomLists.readReligions(Options options, Settings settings)
       at ATVTW.CustomLists..ctor(Options options, Settings settings)
       at ATVTW.ATVTWForm.LoadHardcodedAndCustomLists()
       at ATVTW.ATVTWForm.ucParseFiles_Click(Object sender, EventArgs e)
       at ATVTW.ATVTWForm.SetSettingsAndParseFiles(Settings settings)
       at ATVTW.ATVTWForm.mnuFileOpen_Click(Object sender, EventArgs e)
       at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
       at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
       at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
       at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
       at System.Windows.Forms.ToolStripItem.FireEventInteractive(EventArgs e, ToolStripItemEventType met)
       at System.Windows.Forms.ToolStripItem.FireEvent(EventArgs e, ToolStripItemEventType met)
       at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
       at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
       at System.Windows.Forms.Control.WndProc(Message& m)
       at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
       at System.Windows.Forms.ToolStrip.WndProc(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
       at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
       at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
    Sign, another brain cramp on my part. The unhandled exception was a bug that Stuie had previously mentioned here and which if you read the next few posts after that I have already fixed, but apparently I never released the fix. So that fix will be included in the next release, which will be shortly.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  2. #62
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.0.4

    This is a minor bug fix release.

    Changes from 2.0.3 Version:

    • Fixed crash when creating/deleting settings from the Open Settings Form
    • Fixed crash caused by having extra lines at the end of the descr_beliefs.txt file for RTW
    • Fixed trait/ancillary names not being checked to see if they're valid in Affects/AcquireAncillary lines
    • Fixed the bug where the first trait/ancillary/trigger is checked twice in certain cases
    • Fixed various text issues
    • Fixed crash where if a file was being held by another process it would crash

    Go to the first post to get the new version.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  3. #63

    Default Re: ATVTW - Trait/Ancillary Validator

    I can't get any BI-based mods to get parsed, the "make sure all files are there" message keeps coming up...

  4. #64
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.0.5

    This is a minor bug fix release.

    Changes from 2.0.4 Version:

    • Fixed bug where an RTW mod will not load if it implements religion (i.e. if a descr_beliefs.txt file is in the data folder)

    Go to the first post to get the new version.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  5. #65

    Default

    Nvm

    Problem with loading fixed, thx.

    A couple more.

    1. Now getting an error parsing DS:
    Code:
    ************** Exception Text **************
    System.IndexOutOfRangeException: Index was outside the bounds of the array.
       at ATVTW.ATVTWForm.ParseDescrStrat()
       at ATVTW.ATVTWForm.tsbNextProblem_Click(Object sender, EventArgs e)
       at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
       at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
    Any chance it can be caused by a trait having the same name as one of its levels?

    2. The tool reports NoGoinBackLevel X, if X > max trait level, which is technically correct, but in our case it's used to achieve having anti-traits work properly. Maybe turn that error into a 'warning' or sth that will be logged somewhere, but not come up while checking?
    Last edited by Squid; February 11, 2010 at 05:33 PM. Reason: dp

  6. #66
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Aradan View Post
    Problem with loading fixed, thx.

    A couple more.

    1. Now getting an error parsing DS:
    Code:
    ************** Exception Text **************
    System.IndexOutOfRangeException: Index was outside the bounds of the array.
       at ATVTW.ATVTWForm.ParseDescrStrat()
       at ATVTW.ATVTWForm.tsbNextProblem_Click(Object sender, EventArgs e)
       at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
       at System.Windows.Forms.ToolStripButton.OnClick(EventArgs e)
    Any chance it can be caused by a trait having the same name as one of its levels?

    2. The tool reports NoGoinBackLevel X, if X > max trait level, which is technically correct, but in our case it's used to achieve having anti-traits work properly. Maybe turn that error into a 'warning' or sth that will be logged somewhere, but not come up while checking?
    If only I was smart enough to catch these the first time through. Anyways the descr_strat parser is crashing if a trait doesn't have a level value attached to it (i.e. a line such as traits GoodCommander would cause the crash). I'll have a fix out shortly.

    As for the NoGoingBackLevel it should only report a too high NoGoingBackLevel if the NoGoingBackLevel is greater than 1 + #ofLevels (or if you have a NoGoingBackLevel on a trait without levels), because you should never need a NoGoingBackLevel greater than that. If you can verify that it is actually doing it for NoGoingBackLevels that are greater than the number of levels and not the number of levels + 1 I'll have to figure out the problem, because the code looks fine for that.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  7. #67
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.0.6

    This is a minor bug fix release.

    Changes from 2.0.5 Version:

    • Fixed crash while parsing descr_strat.txt caused by traits without a level
    • Fixed ReligiousBelief and ReligiousOrder errors/warnings not being reported

    Go to the first post to get the new version.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  8. #68

    Default Re: ATVTW - Trait/Ancillary Validator

    Cheers, DS loads fine now and gotcha about the nogoingback, works as intended.

  9. #69
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.0.7

    This is a minor bug fix release.

    Changes from 2.0.6 Version:

    • Fixed bug where any region with a legion: XXX line would not add the proper settlement name to the settlement names list

    Go to the first post to get the new version.
    Last edited by Squid; February 04, 2010 at 11:13 PM.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  10. #70
    Caligula Caesar's Avatar Horse Lord
    Join Date
    Dec 2008
    Location
    England
    Posts
    5,510

    Default Re: ATVTW - Trait/Ancillary Validator

    Strange... it works now, but with my latest edits, it comes up with a ton of false positives. For example:

    Spoiler Alert, click show to read: 

    Level Hates_Sciences
    Description Hates_Sciences_desc
    EffectsDescription Hates_Sciences_effects_desc
    Threshold 7
    Effect Management -5
    Effect Squalor 1
    Effect Farming -3
    Effect TaxCollection -15
    Effect Trading -25
    Effect Mining -15
    Effect Construction -1


    and

    Spoiler Alert, click show to read: 

    {Hates_Sciences} Hates Sciences
    {Hates_Sciences_desc}
    Descr needed -CC
    {Hates_Sciences_effects_desc}
    Descr needed -CC


    It claims "Hates_Sciences" isn't defined. Strange, because it is...

    Also, I can't load it with certain triggers, but I'm still investigating which. Scanning triggers produces weird results. It throws up an exception whilst saying the battleodds aren't defined when they are (those triggers are as old as Vanilla, BTW, so they must be working...)

    The game won't load up at the moment due to something here, but I'm unable to find what... I do know that it isn't the same as is stopping ATVTW from loading, though. I suspect I may have done something wrong with the latest traits.

    Edit: I have ATVTW working completely now. I had said "WhenToTest CharacterEndTurn" instead of "CharacterTurnEnd".
    Last edited by Caligula Caesar; February 18, 2010 at 11:07 AM.
    RTR-VII Team Leader and Leader of Fortuna Orbis, an RTR Submod

    "History has only one concern and aim, and that is the useful; which again has one single source, and that is truth." -Lucian of Samosata

    Fortuna Orbis Beta is released!

  11. #71
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    You've got something weird going on. I put that level and the corresponding VnV entries into some test files and there were no problems reading them. Also I'd check the preceding lines in export_VnVs.txt for hidden characters or bad file format. As for battleodds make sure you're using proper capitalization it should be BattleOdds.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  12. #72
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.1.0

    This is a new feature release:

    Improvements:

    • Will scan scripts and if it finds any traits/ancillaries will check to make sure they exist
    • When scanning descr_strat if a trait/ancillary is being assigned to a faction from a culture that is excluded from acquiring the trait/ancillary this will be reported as an error

    Changes from 2.0.7 Version:

    • Fixed bug where in RTW if you weren't using religion not all settlement names would be read correctly
    • Fixed a bug when reading enums where the enums in game text is multiple lines in length
    • Fixed the contents of the form not resizing when the window is resized
    • Fixed bad spacing in various error/warning messages
    • Fixed the move to end of list and move forward 1 buttons
    • Can scroll when moused over the status window
    • Can now double-click on a setting to open it
    • Can now right-click and delete a selected setting
    • Added in the I_FactionLeaderTrait and I_FactionLeaderAttribute conditions for M2TW (I'd swear I'd already added them)

    Go to the first post to get the new version.
    Last edited by Squid; February 19, 2010 at 11:20 AM.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  13. #73
    Caligula Caesar's Avatar Horse Lord
    Join Date
    Dec 2008
    Location
    England
    Posts
    5,510

    Default Re: ATVTW - Trait/Ancillary Validator

    BattleOdds wasn't capitalised properly. I found that sometimes it had a trait as condition, and then the next condition left out the word "trait". I need to test if this works, because I have discovered that having two traits as triggers doesn't (it just triggers every time). Also, there is a condition "PercentageArmyKilled" which isn't defined. I have to test if it works. Apart from that, well, I'm still getting CTDs, so there must be something wrong with those things it can't find in export_VNVs.
    RTR-VII Team Leader and Leader of Fortuna Orbis, an RTR Submod

    "History has only one concern and aim, and that is the useful; which again has one single source, and that is truth." -Lucian of Samosata

    Fortuna Orbis Beta is released!

  14. #74
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Caligula Caesar View Post
    Also, there is a condition "PercentageArmyKilled" which isn't defined.
    The condition is PercentageOfArmyKilled, which I've checked and it is in the list of conditions for ATVTW.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  15. #75
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Caligula Caesar View Post
    I found that sometimes it had a trait as condition, and then the next condition left out the word "trait".
    I'm not sure what you mean by this, could you provide an example?

    I need to test if this works, because I have discovered that having two traits as triggers doesn't (it just triggers every time).
    Do you mean that if you have Trait xyz = n then any subsequent Trait abc = m will be ignored?
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  16. #76
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Version 2.1.1

    This is a bug fix release:

    Changes from 2.1.0 Version:

    • Fixed the Orphans check to correctly identify orphans
    • Fixed various condition arguments not being checked
    • Added checking for a few condition arguments that were not being checked
    • Changed trait levels of hidden traits to report missing enum entries as warning instead of errors
    • Fixed bug when checking double values if your cultures separator is not the period (.)
    • Changed double checks to decimal checks (as all value are decimals not doubles)
    • Fixed doubling of display of a condition if its requirement wasn't met
    • Fixed a various conditions/events not having the proper exports
    • Fixed more formatting in error messages.
    • Fixed conditions IsRegionOneOf and IsTargetRegionOneOf to not report errors if there are no region names read
    • Moved a bunch of code from the ATVTW.exe to the TWLibrary.dll for reuse with other projects I'm working on

    Go to the first post to get the new version.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  17. #77
    Caligula Caesar's Avatar Horse Lord
    Join Date
    Dec 2008
    Location
    England
    Posts
    5,510

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Sqυιd View Post
    I'm not sure what you mean by this, could you provide an example?
    For instance:

    Condition Trait X = 1
    and Y = 1

    things like that are to be found in the files... but other people use "and Trait Y = 1". I have yet to test what works.

    Quote Originally Posted by Sqυιd View Post
    Do you mean that if you have Trait xyz = n then any subsequent Trait abc = m will be ignored?
    Actually, when I tested it, both were ignored. It's always possible I was doing something wrong, though.
    RTR-VII Team Leader and Leader of Fortuna Orbis, an RTR Submod

    "History has only one concern and aim, and that is the useful; which again has one single source, and that is truth." -Lucian of Samosata

    Fortuna Orbis Beta is released!

  18. #78
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    Quote Originally Posted by Caligula Caesar View Post
    For instance:

    Condition Trait X = 1
    and Y = 1
    This will always return true for the second condition because it is an invalid condition and all invalid conditions will always return true (in other words they are just ignored).

    things like that are to be found in the files... but other people use "and Trait Y = 1". I have yet to test what works.



    Actually, when I tested it, both were ignored. It's always possible I was doing something wrong, though.
    I'd like to see the exact code, because I've made extensive use of multiple trait checks in a trigger condition and have it work correctly. Remember the right hand side of = is the level of the trait and not the points earned in the trait.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

  19. #79

    Default Re: ATVTW - Trait/Ancillary Validator

    Hello, I am trying to use your editor to play with some traits in MTW2.

    I have a fresh install of MTW2 with the 1.2 patch applied.

    I point to the /data folder and check MTW2. When I try to open those settings I get the message that it cannot find the /data/text/export_VnVS.txt and /data/text/export_ancillaries.txt files. Those files are in the /data/text folder, but are called export_vnvs.txt.strings.bin and export_ancillaries.txt.strings.bin. Renaming these files to what the program wants causes the program to hang when it tries to open them.

    I tried manually editing export_descr_character_traits.txt but it seemed to have no effect ingame and export_vnvs.txt.strings.bin is too unreadable to manually edit.

    Thanks for any help.

  20. #80
    Squid's Avatar Opifex
    Patrician Artifex Technical Staff

    Join Date
    Feb 2007
    Location
    Frozen waste lands of the north
    Posts
    17,741
    Blog Entries
    3

    Default Re: ATVTW - Trait/Ancillary Validator

    You need to use the strings.bin converter from the M2TW forums. The strings.bin files are not in the proper format.
    Under the patronage of Roman_Man#3, Patron of Ishan
    Click for my tools and tutorials
    "Two things are infinite: the universe and human stupidity; and I'm not sure about the universe." -----Albert Einstein

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •