Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
thanks, Gigantus. If any of the players would be willing to make / find such a movie to be included in the mod for coronation, he'll be warmy welcome.
I'll stick to coding, I've created 28 additional traits so that it's possible to have up to 18 provinces for simple triggers in EDA.
The code now is:
Code:
;----- crowns ------------------------------------------
; AI is excluded from the intricacies of the mechanism, but has a simple trigger here and in EDA
; and then it has a short list of provinces to gain - thus it's likely to get crowns
;-------------------------------------------------------- (A) unfit for crown
Condition FactionIsLocal
and IsFactionLeader
and Trait Crownholder < 1
Affects Crownholder 1 Chance 100
;-------------------------------------------------------- (B) fit for crown in general
;------------------------------------------- 1->2
Trigger Fit_for_crown_Lands_Conquered
WhenToTest CharacterTurnEnd
Condition IsFactionLeader
and FactionIsLocal
and Trait Crownholder > 0
and Trait Crownholder < 2
and Trait FitForOffice > 1
and Trait Usurper < 1
and Trait FactionRegent < 1
and Attribute Piety > 5
and Attribute Authority > 5
and not FactionExcommunicated
Condition IsFactionLeader
and FactionIsLocal
and Trait Crownholder > 0
and Trait Crownholder < 2
and Trait FathersLegacy > 1
and Trait Usurper < 1
and Trait FactionRegent < 1
and not FactionExcommunicated
Affects Crownholder 2 Chance 100
;-------------------------------------------------------- (C) fit for specific crowns
; hidden to the player as used only for technical reason
; used to enable more than 19 conditions in the EDA
; made in a simple way to limit the number of downgrade triggers: each turn is removed and then added
; (for poor nations threshold 20000 fl may be lowered but this will require work on the descriptions)
; (> loyalty_disillusioned is lowere than put in the description (happy))
Condition FactionIsLocal
and IsFactionLeader ; just in case of a bug
and FactionType cumans
and EndedInSettlement
and SettlementName Sharukan
and SettlementBuildingExists >= tengir_sanctuary
and not IsUnderSiege
and GovernorLoyaltyLevel > loyalty_disillusioned
and Treasury > 20000
and not I_WorldwideAncillaryExists crown_russia ; names of the crowns are not identical with the factions' names
and Trait Crownholder > 1
and Trait Crownholder < 4 ; either Legacy (2) or Lands_Conquered (3)
Condition not FactionIsLocal
and IsFactionLeader
and FactionType cumans
and EndedInSettlement
and not IsUnderSiege
and not I_WorldwideAncillaryExists crown_russia
;------------------------------------------- 5->4
;- used in script, the first trigger must come first
;-------------------------------------------
Trigger Crown_Payment_For_Ceremony
WhenToTest CharacterTurnStart
Condition HasAncType crown
and Trait Crownholder > 4
Condition HasAncType crown
and Trait Crownholder > 1
and Trait Crownholder < 3
Affects Crownholder 3 Chance 100
Code:
;========== Crown of HUNGARY ==============================;;------------------------------------------
Trigger crown_hungary_Lands_Conquered
WhenToTest CharacterTurnEndInSettlement
Condition Trait Fit_Crown_hungary > 0
and I_SettlementOwner Esztergom = hungary
and I_SettlementOwner Gyulafehervar = hungary
and I_SettlementOwner Szekesfehervar = hungary
and I_SettlementOwner Zagreb = hungary
and I_SettlementOwner Iasi = hungary
and I_SettlementOwner Severin = hungary
and I_SettlementOwner Ras = hungary
and I_SettlementOwner Varad = hungary
and I_SettlementOwner Zara = hungary
and I_SettlementOwner Nis = hungary
and I_SettlementOwner Ragusa = hungary
and I_SettlementOwner Halych = hungary
and I_SettlementOwner Vhrbosna = hungary
and I_SettlementOwner Vienna = hungary
Condition not FactionIsLocal
and Trait Fit_Crown_hungary > 0
and I_SettlementOwner Esztergom = hungary
and I_SettlementOwner Gyulafehervar = hungary
and I_SettlementOwner Szekesfehervar = hungary
and I_SettlementOwner Zagreb = hungary
and I_SettlementOwner Varad = hungary
and I_SettlementOwner Zara = hungary
and I_SettlementOwner Ragusa = hungary
AcquireAncillary crown_hungary chance 100
March 08, 2020, 07:24 AM
Lurker from Codex
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
In the Middle Ages a major reason for rulers failing to create big empires were their disloyal nobles. When the rich and powerful found themselves far away from the eye of their souverain, they would very often try to establish their own rule in the provinces. Proximity to their liege lord would generally prove sufficient to suppress these ambitions. In turn, the rulers needed legitimacy, preferably with some God's blessing. One method of acquiring this legitimacy was a formal coronation.\n This phenomenon is reflected in the SSHIP gameplay. A faction leader may acquire a crown and enjoy increased Authority. This crown gives both direct benefits (+2 Authority, +1 Law, +1 popularity and +2 sight range), but also boosts generals’ loyalty in an indirect way, as the distance to capital penalties are reduced for generals serving a crowned faction leader. Plotters and usurpers also less likely to appear in the kingdom with the crowned king. As a result, a good mid-game goal for the player may be to attain the crown of his faction. \n The map with the required provinces is shown in panel, the other requirements are described in the Ruler's relevant trait. There's also an easier way to get the crown for the ruler: having Strong Legacy from his father. In this case - what will be shown in the traits - to get a crown the son doesn't need to have personal qualities or rule over all provinces.
Quote:
Having a crown brings four benefits for the ruler:\n 1. He enjoys increased (+2) Authority. It directly translates into higher Loyalty of his generals.\n 2. Drop of generals Loyalty due to the distance to capital is reduced, enabling them to fight wars far away without risk of rebelion.\n 3. The Authority of his sons increases (+3) due to the Strong Leagacy. This makes it more likely to become legitimate heirs.\n4. Usurpers also less likely to appear, so the civil wars are rarer.\n\n As a result, a good mid-game goal for the player may be to attain the crown of his faction.
Why do you lie?
Admittedly, I can barely make sense of that part of your script (I think there is a few mistakes with confusing NearCapital and FLNearCapital traits), but in any case - being crowned/uncrowned has no impact on Near_Loyalty and Far_Loyalty traits. There is also no Clearing_House function for Near_Loyalty and Far_Loyalty, but maybe it's not needed for this pair.
I'm having problems with "openly rebellious" trait. I have quite a bunch of generals suffering from this (obviously mental) condition, sitting in my cap with FL for ages now. From what I understand, this trigger
Condition IsGeneral
and DistanceCapital < 50
and Trait Far_Loyalty > 0
and not Trait DiscontentGeneral > 0
Affects Far_Loyalty -1 Chance 10
;------------------------------------------
is supposed to get them back to their senses, but for some reason it doesn't work. Maybe they gained too many points in Far_Loyalty, or maybe chance 10 is just not enough. I thought that getting the crown will make this less of an issues, but apparently it doesn't.
March 08, 2020, 08:30 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
As many aspects of the game, this one is not fully ironed out, and definitely not balanced yet. Personally, I haven't dealt with it for 3 years now. Parts of my code are still there but I don't know how do they work altogether and you are very likely to be right that there's much confusion.
However, about lying, you've written "in any case - being crowned/uncrowned has no impact on Near_Loyalty and Far_Loyalty traits."
I'd say it's not true as I see in the code:
Code:
;--- for crowned Faction Leader ---------- Trigger FL_Near_Capital_Crown_Add
WhenToTest CharacterTurnEnd
Condition IsFactionLeader
and DistanceCapital < 50
and Trait NearCapital < 1
and Trait Crownholder > 3
Condition IsFactionLeader
and DistanceCapital >= 30
and Trait NearCapital = 1
and Trait Crownholder < 4
Affects NearCapital -1 Chance 100
As the Near and FarLoyalty depends on the FL being near the capital, this is a serious change: he gets it far more away from the capital (50, not 30 tiles). I expect it to have much impact, but as I've said, I personally haven't dealt with it for long time.
Have a look here:
Code:
;-------- for generals ------------------ Trigger General_FLNearCapital_Add
WhenToTest CharacterTurnEnd
Condition IsGeneral
and not IsFactionLeader
and FactionLeaderTrait NearCapital > 0
and Trait Officeholder < 1
and DistanceCapital < 30
and Trait FLNearCapital < 1
Condition IsGeneral
and Trait FLNearCapital < 1
and Trait Near_Loyalty > 0
and FactionIsLocal
Affects Near_Loyalty -1 Chance 5
However, I've just discerned later in the code a problem: and Trait Far_Loyalty < 11. Points and levels have been mixed up. Need to be fixed.
---
the trigger you've just cited doesn't serve to get back the "senses", but loyalty. and looks perfectly right.
March 08, 2020, 09:30 AM
Lurker from Codex
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
As the Near and FarLoyalty depends on the FL being near the capital, this is a serious change: he gets it far more away from the capital (50, not 30 tiles). I expect it to have much impact, but as I've said, I personally haven't dealt with it for long time.
See, that's the thing. Being crowned allows FL to move a bit further from the capital without losing Attending To the Court trait. If he was sitting in the capital (as a governor or whatnot) before getting crowned, then acquiring the crown will make no difference in terms of loyalty of his generals. Crown doesn't have a direct impact on how far can the generals travel from the cap and remain loyal.
Condition IsGeneral
and DistanceCapital > 80
and Trait Far_Loyalty < 11
and not InEnemyLands and FactionLeaderTrait Crownholder > 3
Affects Far_Loyalty -1 Chance 10
;------------------------------------------
This would simulate moral dilemmas like "I am currently in faraway lands, I owe nothing to the King. And yet he is the rightful King. What do I do?". You got the idea.
It's currently pretty tough to manage loyalty once your empire grows beyond 25-30 provinces - it's not even about waging wars on distant lands, but rather appointing governors of border provinces. Even if the player manages to keep loyalty (attribute) at decent levels, the bad traits alone create severe maluses, effectively making the governor more harmful for the economy.
So, considering the sheer difficulty of acquiring the crown, I would personally prefer to see more crown impact on the gameplay.
March 08, 2020, 10:13 AM
Lusitanio
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
If you want a script to take money from the player why not just creating a corruption script that takes money away from the player when he reaches a certain amount of money? On my case, I adapted a script from De Bello Mundi and created a corruption script for Carthage that has chances of taking between 3k and 20k from their treasury every winter.
March 09, 2020, 02:35 AM
Lurker from Codex
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Here is how I tweaked these triggers for my own game:
Condition IsGeneral
and DistanceCapital > 60
and Trait Far_Loyalty < 11
and FactionIsLocal
and not InEnemyLands
and Trait Officeholder < 1 and FactionLeaderTrait Crownholder < 4
Condition IsGeneral
and DistanceCapital > 70
and Trait Far_Loyalty < 11
and FactionIsLocal
and not InEnemyLands
and not Trait Upright > 0
and not Trait Prim > 0
and not Trait Stoic > 0
and not Trait WifeIsNoble > 0 and FactionLeaderTrait Crownholder < 4
Condition IsGeneral
and DistanceCapital > 60
and Trait Far_Loyalty < 11
and FactionIsLocal
and not InEnemyLands
and Trait Officeholder < 1 and FactionLeaderTrait Crownholder > 3
Condition IsGeneral
and DistanceCapital > 70
and Trait Far_Loyalty < 11
and FactionIsLocal
and not InEnemyLands
and not Trait Upright > 0
and not Trait Prim > 0
and not Trait Stoic > 0
and not Trait WifeIsNoble > 0 and FactionLeaderTrait Crownholder > 3
Condition IsGeneral
and DistanceCapital > 80
and Trait Far_Loyalty < 11
and not InEnemyLands and FactionLeaderTrait Crownholder > 3
Affects Far_Loyalty 1 Chance 5
;------------------------------------------
This way the generals lose their loyalty at standard speed until FL gets a crown. Once he does, these triggers are twice less likely to happen.
March 09, 2020, 05:15 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
@Lurker - yes, this is one way of skinning the cat. I'll take it into account when I'll come back to modifying the loyalty mechanism.
Quote:
Originally Posted by Lusitanio
If you want a script to take money from the player why not just creating a corruption script that takes money away from the player when he reaches a certain amount of money? On my case, I adapted a script from De Bello Mundi and created a corruption script for Carthage that has chances of taking between 3k and 20k from their treasury every winter.
This is something I'd like to avoid: the budget changes should be the outcome of the choices of the player or the events in the game, not a crude script. For instance, paying for a marriage or adoption of a new general or an army moving abroad (each with a simple script just taking away additiona money) looks ok to me: the player has to decide if he can afford it, while just having expenses scalling up with the size of the faction - not really.
@Lusi: Anyway, can you just post that script for Carthage here? I'd have it handy for possible future tweaking of the money balance.
@Lusi: can you have a look here and tell why it doesn't work? If I put this code, it simply disables the script. What else should be changed?
March 09, 2020, 06:48 AM
Gigantus
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Name change issue: make sure the entries exist in text\expanded.
March 09, 2020, 10:12 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Gigantus
Name change issue: make sure the entries exist in text\expanded.
yes, I'd done it, deleted .bin as well - and still didn't help.
This work:
Code:
;--- Lisbon
monitor_event GeneralCaptureSettlement SettlementName Lisbon
and CharacterReligion catholic
change_settlement_name Lisbon Lisbon
end_monitor
But this doesn't
Code:
monitor_event GeneralCaptureSettlement SettlementName Turku
and CharacterReligion catholic
change_settlement_name Turku Turku
end_monitor
EDIT: uffffffffffff, I've found the problem here. In the expanded.txt you have to keep a blank line at the end of the file...
March 09, 2020, 11:22 AM
Gigantus
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Okay, that's a bit of an anti climax :tongue:. But thanks for refreshing my memory why back then the BinEditor was set to create that blank last line in all TXT files.
March 10, 2020, 02:54 PM
Lurker from Codex
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
My second FL just got a crown after his father died. Now he is the King of all Spain. Nice.
... Except I'm playing as Novgorod.
Why, JoC?
Quote:
;========== Crown of RUSSIA ==============================;;------------------------------------------
Trigger crown_russia_Novgorod_FatherLegacy
WhenToTest CharacterTurnEnd
Condition IsFactionLeader
and EndedInSettlement
and FactionType russia
and Trait Crownholder > 2
and Trait Crownholder < 4
and SettlementName Novgorod
and SettlementBuildingExists = cathedral_o
and not I_WorldwideAncillaryExists crown_spain
AcquireAncillary crown_spain chance 100
;------------------------------------------
March 10, 2020, 04:27 PM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Lurker from Codex
My second FL just got a crown after his father died. Now he is the King of all Spain. Nice.
... Except I'm playing as Novgorod.
Why, JoC?
Well, you've answered yourself :-) It's because it was not reviewed and improved.
Just to recall what's written in the changelog:
THE CROWNS
· conceptual changes introduced as described on the relevant webpage (see the maps there!);
· all the mechanisms of getting the crown are in the game except of additional payments for crowining (at the moment you get the crown from free);
· updated lists of provinces required to get crowns of Scotland, England, France, Norway, Denmark, Poland, HRE, Lithuania, Serbia. This means they're fully operational (for the details refer to the relevant entry for each faction in this thread), while the other crowns work as they're before.
· the crowns can also be acquired by the player on the basis of ProudLegacy from the father (as described in-game). They are available for the AI - with shorter list of provinces as the AI doesn't know the ins-and-outs of the system. Future work: update of provinces for the other crowns. Putting the maps to be seen in-game.
I'm just now modifying other crowns so that you won't have that shock in the next games ;-)
March 10, 2020, 05:36 PM
j.a.luna
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
I dont understand about your last change Jurand... You will obtain the Corona ibérica or king of Spain with only 12 provinces for Aragon and without Toledo? I think that crown of Spain should be the same for all factions ( all Iberian peninsula)
March 11, 2020, 01:20 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Gigantus
Okay, that's a bit of an anti climax :tongue:. But thanks for refreshing my memory why back then the BinEditor was set to create that blank last line in all TXT files.
Well, another anti-climax was when I've found out that my settlement-change-name script didn't work because somebody coded Brandenburg as Brandeburg...
Quote:
Originally Posted by j.a.luna
I dont understand about your last change Jurand... You will obtain the Corona ibérica or king of Spain with only 12 provinces for Aragon and without Toledo? I think that crown of Spain should be the same for all factions ( all Iberian peninsula)
Well-spotted, I've changed it just 10 hours ago ;-)
The need to get 18 provinces is unbalanced. One may give the same conditions for Aragon as for Leon for a crown, but it would be boring. Provide me the correct name and description for Crown of Aragon, and I'll create a separate, but with those 12 provinces around the sea.
March 11, 2020, 01:41 AM
j.a.luna
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Jurand of Cracow
Well, another anti-climax was when I've found out that my settlement-change-name script didn't work because somebody coded Brandenburg as Brandeburg...
Well-spotted, I've changed it just 10 hours ago ;-)
The need to get 18 provinces is unbalanced. One may give the same conditions for Aragon as for Leon for a crown, but it would be boring. Provide me the correct name and description for Crown of Aragon, and I'll create a separate, but with those 12 provinces around the sea.
So you say that you will create Crown of Aragon, Crown of Portugal and Crown Of Castille and Leon?
The historical Crown of Spain was with all the Iberian Peninsula reunified,it is the same for both faction. Castille and Leon was unified with Aragon( marriage of Fernando de Aragón and Isabel de Castilla)and the conquest of Granada and also unified of little kingdom of Navarra, almost all the peninsula without kingdom of Portugal, so if you want make different crowns Ok, but exist only a unique crown of Spain for all factions
I can help you if you need ideas about what territories for the 4 factions include moors.
March 11, 2020, 02:32 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by j.a.luna
So you say that you will create Crown of Aragon, Crown of Portugal and Crown Of Castille and Leon?
The historical Crown of Spain was with all the Iberian Peninsula reunified,it is the same for both faction. Castille and Leon was unified with Aragon( marriage of Fernando de Aragón and Isabel de Castilla)and the conquest of Granada and also unified of little kingdom of Navarra, almost all the peninsula without kingdom of Portugal, so if you want make different crowns Ok, but exist only a unique crown of Spain for all factions
I can help you if you need ideas about what territories for the 4 factions include moors.
Gameplaywise it makes sense to have also a separate crown for Aragon, while keeping Corona ibérica for all factions.
After the recent changes in coding it's easy to be done.
I'll use the name Rey de Aragó e comte de Barçelona. If you'd provide the picture for this crown, I'd be grateful.
March 11, 2020, 04:59 AM
j.a.luna
1 Attachment(s)
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Jurand of Cracow
Gameplaywise it makes sense to have also a separate crown for Aragon, while keeping Corona ibérica for all factions.
After the recent changes in coding it's easy to be done.
I'll use the name Rey de Aragó e comte de Barçelona. If you'd provide the picture for this crown, I'd be grateful.
Attachment 360855 the only crown of Aragon than i saw as figure is this of the 14 century belong to the king Martin I of Aragon( 1396-1410), the rest are old images of different kings of Aragon with diferents crowns
March 11, 2020, 05:19 AM
Jurand of Cracow
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
to dark to be used in game - must be bright on dark, or dark on bright...
March 11, 2020, 05:47 AM
j.a.luna
3 Attachment(s)
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
Quote:
Originally Posted by Jurand of Cracow
to dark to be used in game - must be bright on dark, or dark on bright...
Mmm Jurand is difficult find a real image about this crown because no exist a unique crown of Aragon as figure, the ancient documents have images about kings and heraldic, also with the coat of arms of the crown of Aragon.
Maybe this can be useful for you. Attachment 360857Attachment 360858Attachment 360859
March 11, 2020, 06:01 AM
j.a.luna
Re: [I] - Crowns' fix: modification of the Crowns in the SSHIP
About the correct name is also difficult, still in the current society many historicals expert are not agree, but i think that the correct name is "Rey de la Corona de Aragón" or simply "Rey de Aragón", the catalans were belong to this crown.
Some information about this:
The name of "Corona de Aragón" is applied in the current historiography from the dynastic union between the Kingdom of Aragon and the County of Barcelona, although it was not used historically until the reign of Jaime II the Just at the end of the thirteenth century, and between the twelfth and fourteenth centuries the most widespread expression to refer to the dominions of the king of Aragon was that of "Casal d'Aragó".
Between the 13th and 15th centuries, the set of the king's possessions was designated by various names such as "Corona regni Aragonum" (Crown of the Kingdom of Aragon), "Corona Regum Aragoniae" (Crown of the Kings of Aragon), "Corona Aragonum »(Corona de Aragón) or« Corona Regia », and Lalinde Abadía points out that there are not many more reasons to speak of« Corona de Aragón »than to make it the« Corona del Reino de Aragón »or other denominations whose common element is to be the set of lands and people that were subject to the jurisdiction of the King of Aragon. Other names from the end of the 13th century are «Royal Crown», «Royal Heritage» and exceptionally, and in the context of the Privilege of annexation of Mallorca to the Crown of Aragon, from 1286, the expression «regno, dominion and crown Aragonum et Catalonie» appears (Kingdom, dominion and crown of Aragon and Catalonia - alluding to the Kingdom of Aragon and the Catalan Counties integrated within the Crown of Aragon) , although only five years later, in 1291, in the renewal of these privileges, there is already talk of "Kingdoms of Aragon, Valencia and the county of Barcelona". From the 18th century onwards, the term "was used more Crown of Aragon ”, “ Kingdoms of Aragon ”or simply“ Aragon ”.