GTCS - Generals' Traits' Common Sense fix (for 0.9.2)

[vovery]

Thanks for the thorough answer Jurand! I've been indeed micromanaging all the generals so far, but at least I've played small factions, and haven't yet played a campaign further than ~125 turns, so hasn't been that bad :-) And I think I'll still check every general each turn to keep up with their development even though there's no need to keep moving them each turn.

[Jurand of Cracow]

Thanks for the thorough answer Jurand! I've been indeed micromanaging all the generals so far, but at least I've played small factions, and haven't yet played a campaign further than ~125 turns, so hasn't been that bad :-) And I think I'll still check every general each turn to keep up with their development even though there's no need to keep moving them each turn.

Yeah, I was also checking almost each turn, but then I've introduced a number of "Gain" messages (when an important trait is upgraded), so I do it less often.
As you may know, I keep track of the generals with an Excel file

Spoiler Alert, click show to read: 

[eyelurker]

So as long as i don't build my inn in City with Ports i'm good?

[Jurand of Cracow]

So as long as i don't build my inn in City with Ports i'm good?

?

[eyelurker]

?

Oops sorry. The corrupt bad trait normally would recieve from having inn to recruit spy.

So if i build my tavern in castle or city with no ports i shouldn't get the bad traits from inn right?

[Jurand of Cracow]

Oops sorry. The corrupt bad trait normally would recieve from having inn to recruit spy.

So if i build my tavern in castle or city with no ports i shouldn't get the bad traits from inn right?

that's more complicated:

;========================================================================================= Corrupt Embezzler Upright;-------- CORRUPTION --------------------------------
; the main difference betweeen Embezzler and Corrupt is that the former is about money, while the latter about all dishonesty
; can be acquired only in a settlement
; always with TimeInRegion > 2 as getting corrupted requires building up a network of "friends" beforehand
; starts in cities (in towns only for ports and mines)
; Teenagers, Unfit immune
; depends on the buildings present and on the traits
; there're some triggers in the other parts for Bribery, 




;--------------------------------------------------------
;-- level 3 of Upright is NoGoingBack, so condition not needed




;----- Corruption in large empire -------------------------
;-------------------------------------------------------


;------------------------------------------
Trigger Corruption_FarAway_NotHonest_KingNOTCrowned
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 3
	   and Trait FitForOffice > 1
       and Trait Upright < 1
	   and FactionLeaderTrait Crownholder < 3
       and DistanceCapital > 80
       and RandomPercent > 50	
	
 Affects Corrupt 1 Chance 2
 
;------------------------------------------
Trigger Corrupt_FarAway_KingNOTCrowned
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 3
	   and Trait FitForOffice > 1
       and Trait Upright < 1
	   and FactionLeaderTrait Crownholder < 3
       and DistanceCapital > 100
       and RandomPercent > 50	


 Affects Embezzler 1 Chance 2
 
;------------------------------------------
Trigger Corruption_FarAway_Trustworthy
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 3
	   and Trait FitForOffice > 1
       and Trait Upright < 2
       and DistanceCapital > 120
       and RandomPercent > 50	
	   
 Affects Corrupt 1 Chance 2
 Affects Embezzler 1 Chance 2




;----- Corrupt from staying in a City -------------------
;--------------------------------------------------------
 
;-----------------------------------------
Trigger Corruption_Tavern
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = tavern
       and RandomPercent > 50
	
 Affects Corrupt 1 Chance 2


;-----------------------------------------
Trigger Corruption_CoachingHouse
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = coaching_house
       and RandomPercent > 50
	   
 Affects Corrupt 1 Chance 3


;-----------------------------------------
Trigger Corruption_PleasurePalace
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = pleasure_palace
       and RandomPercent > 50
	   
 Affects Corrupt 1 Chance 4


;-----------------------------------------
Trigger Corruption_Mines
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 3
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
	   and FactionLeaderTrait Crownholder < 3
       and SettlementBuildingExists = mines1
       and RandomPercent > 50	
	   
 Affects Corrupt 1 Chance 2


;-----------------------------------------
Trigger Corruption_Shaft_Mines
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 3
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
	   and FactionLeaderTrait Crownholder < 3
       and SettlementBuildingExists = mines3
       and RandomPercent > 50	
	   
 Affects Corrupt 1 Chance 2
 


;----- Embezzler from trade buildings -------------------
;--------------------------------------------------------


;-----------------------------------------
Trigger Corruption_Port
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = port
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2


;-----------------------------------------
Trigger Corruption_Shipwright
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = shipwright
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 3


;-----------------------------------------
Trigger Corruption_Dockyard
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists >= dockyard
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 4


;-----------------------------------------
Trigger Corruption_fairground
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists = fairground
       and RandomPercent > 50	
	   
 Affects Embezzler 1 Chance 2
 
;-----------------------------------------
Trigger Corruption_great_market
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists >= great_market
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2


;-----------------------------------------
Trigger Corruption_Slavemarket
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists >= slavemarket
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2


;-----------------------------------------
Trigger Corruption_MerchantBank
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists >= money3
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2 


;-----------------------------------------
Trigger Corruption_Italian_Trader_Quarters
 WhenToTest CharacterTurnEndInSettlement


 Condition not IsFactionLeader
       and TimeInRegion > 2
       and Trait Wantschool < 1
       and Trait FitForOffice > 1
       and SettlementBuildingExists >= italian_trader_quarters
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2 


;-------------------------------------------------------- self-perpetuation


;------------------------------------------
Trigger Corrupt_Selfperpetuating_NotPious
 WhenToTest CharacterTurnEndInSettlement


 Condition Trait Corrupt > 0
       and Attribute Piety < 3 
       and Trait Upright < 1
       and Trait FitForOffice > 1
       and RandomPercent > 50
	   
 Affects Corrupt 1 Chance 2 


;------------------------------------------
Trigger Corrupt_Selfperpetuating_NotLoyal
 WhenToTest CharacterTurnEndInSettlement


 Condition Trait Corrupt > 0
       and Attribute Loyalty < 3 
       and Trait Upright < 1
       and Trait FitForOffice > 1
	   and FactionLeaderTrait Crownholder < 3
       and RandomPercent > 50	
	   
 Affects Corrupt 1 Chance 1
 
;------------------------------------------
Trigger Embezzler_Selfperpetuating_NotPious
 WhenToTest CharacterTurnEndInSettlement


 Condition Trait Embezzler > 0
       and Attribute Piety < 3 
       and Trait Upright < 1
       and Trait FitForOffice > 1
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2 


;------------------------------------------
Trigger Embezzler_Selfperpetuating_NotLoyal
 WhenToTest CharacterTurnEndInSettlement


 Condition Trait Embezzler > 0
       and Attribute Loyalty < 3
       and Trait Upright < 1
       and Trait FitForOffice > 1
	   and FactionLeaderTrait Crownholder < 3
       and RandomPercent > 50
	   
 Affects Embezzler 1 Chance 2 




;------------------------------------------------------- Old age consequences
Trigger Embezzler_Corrupt_OldAge_Loss
 WhenToTest CharacterTurnEndInSettlement


 Condition Trait Senile > 1


 Affects Corrupt -1 Chance 10
 Affects Embezzler -1 Chance 10
 Affects Upright 1 Chance 3
 
;------------------------------------------------------- NoGoingBack


;------------------------------------------
Trigger Upright_NoGoingBack
 WhenToTest CharacterTurnEnd


 Condition Trait Upright < 4
       and Trait Upright > 2
	   
 Affects Upright 10 Chance 100

[eyelurker]

Soory but i also one thing. My newborn general sometime get dysfunctional and i want to avoid getting them.

[Jurand of Cracow]

Soory but i also one thing. My newborn general sometime get dysfunctional and i want to avoid getting them.

Look around you... don't you see how many slightly mad people are there? Middle Ages were not better... and I'd think that even worse