Bugs Reports & Technical Help

**kaiser29** · October 24, 2016, 05:08 AM

Originally Posted by Jurand of Cracow

Have a look at my submod fixing the provincial titles: PFT. If you would find it convincing, would like to expand it to the Italian provinces and would be ready to make an analysis of the relevant files in the way I did for Poland, Lithuania, Hungary and Ruthenia, we may join forces.

thank you very much for your proposal, I'll see what I can do (I haven't got much time).

anyway, as for Ancona, the city was an oligarchy, and was ruled by the Elder Six (don't know if I can translate it this way...), but they were also known as Six Masters, or Six Lords.

**Lifthrasir** · October 24, 2016, 05:51 AM

You're right about the Six Elders. Ancona stayed independant until it became part of the Papal States. Not sure what title would be the most relevant: Podesta?

Anyway, I suggest to continue this discussion in the thread linked by JoC (here).

**kaiser29** · October 25, 2016, 11:39 AM

found a bug in desc_faction_standing.txt.

[CONTENTBOX];------------------------------------------Trigger SicilyAI
WhenToTest FactionTurnStart

Condition FactionType sicily
and not FactionIsLocal

FactionStanding factions { england, moors } normalise 0.2 80

;------------------------------------------
Trigger SicilyBig
WhenToTest FactionTurnStart

Condition FactionType sicily
and I_NumberOfSettlements sicily > 6

FactionStanding factions { hre } normalise -0.4 55
FactionStanding factions { venice, pisa, byzantium } normalise -0.6 60

;------------------------------------------
Trigger SicilyHuge
WhenToTest FactionTurnStart

Condition FactionType sicily
and I_NumberOfSettlements sicily > 10

FactionStanding factions { hre } normalise -0.6 20
FactionStanding factions { venice, pisa, byzantium } normalise -0.8 40
FactionStanding factions { france, aragon, hungary, teutonic_order, papal_states } normalise -0.6 65
FactionStanding exclude_factions { slave } normalise -0.8 100

;------------------------------------------
Trigger SicilyCrushed
WhenToTest FactionTurnStart

Condition FactionType sicily
and I_NumberOfSettlements sicily > 7

FactionStanding factions { papal_states } normalise 0.6 10
FactionStanding factions { hre } normalise 0.4 10
FactionStanding factions { venice, pisa, byzantium } normalise 0.2 35 FactionStanding factions { france, aragon, hungary, teutonic_order } normalise 0.2 40[/CONTENTBOX]

as you can see, the Trigger SicilyCrushed (the last one) is bugged, because it implies that when sicily has more than 7 settlements, the relations with the other factions increases. it should be the opposite, something like and I_NumberOfSettlements sicily < 4 (the number 4 is just a guess)

**Jurand of Cracow** · October 25, 2016, 01:08 PM

I also have a question about code, but in the EDCT file in SSHIP

Code:

;------------------------------------------
Trigger battle3Dread_TotalAnnihilation
 WhenToTest PostBattle

 Condition WonBattle
       and BattleSuccess >= crushing
       and PercentageEnemyKilled > 90
       and not GeneralFoughtInCombat
       and IsGeneral
       and BattleOdds < 0.95
       and not Trait BattleChivalry > 0
       and NumFriendsInBattle > 750

 Affects BattleDread 2 Chance 50

whey there's "not" in the line "and not GeneralFoughtInCombat"? I think the condition shoud tell that indeed there's a battle.
In the M2TW docudemons 4.0 the similar triggers says:

Code:

Trigger battle3Dread_TotalAnnihilation
    WhenToTest PostBattle
    Condition WonBattle
          and BattleSuccess >= crushing
          and PercentageEnemyKilled > 70
          and GeneralFoughtInCombat
          and IsGeneral
          and BattleOdds < 0.95
          and not Trait BattleChivalry > 0
    Affects BattleDread  2  Chance  100

**Jurand of Cracow** · October 26, 2016, 06:31 AM

In the EDCT file there're two triggers with the same name "Trigger Building_MilitaryInclination_Castle_Archery". I think the second will not fire (and I'm surprised there're no CTD due to this fact, I didn't know the game can live with it).

On another topic:
I have tried to copy-paste the triggers from the files but TWC server blocks me. It happened to me several times in the past when I tried to copy-and-paste from EDCT. Also the at some point attaching the very EDCT was forbidden. Does anybody else experience similar thing?

**Lifthrasir** · October 26, 2016, 06:39 AM

Have you tried by zipping it? If it still doesn't work, let me know and I'll see if I can do something

**Jurand of Cracow** · October 27, 2016, 02:12 AM

I've managed to upload it as zip. BTW - the more I delve into EDCT, the more mistakes I find, and more I change for myself. Yesterday I just fixed the TourneyKnight - it's an elaborate trait, but nobody can achieve higher levels as the probabilities would require sitting in a settlement for 90 years ;-)

**Lifthrasir** · October 27, 2016, 02:31 AM

Actually, I'm not surprised. Not sure when they have been made

Btw, thanks for "cleaning" this. Appreciated

**j.a.luna** · October 27, 2016, 07:14 AM

Originally Posted by Jurand of Cracow

I've managed to upload it as zip. BTW - the more I delve into EDCT, the more mistakes I find, and more I change for myself. Yesterday I just fixed the TourneyKnight - it's an elaborate trait, but nobody can achieve higher levels as the probabilities would require sitting in a settlement for 90 years ;-)

it is good know that you improve all this traits and minor issues as generals or tittles for cities, continue with your work Jurand, i am glad with you for this hehe and also will give reputation, together can improve sship and o it more historical and challenge!

**Jurand of Cracow** · October 27, 2016, 07:59 AM

I've just fixed minor issues in the GoodTaxman and improved my minimod thread - there's now a short guide of dos and donts.

MWY/Lift/others - I have a problem understanding "tourney" buildings in EDB. For many buildings there are two sets: one for the cities, the other for the castles (eg. smith and castle_smith). How it is with jousting list? I cannot find it for a castle, yet in-game I have jousting lists in the fortresses...

@j.a.luna - thanks! I'm testing the tourneyknight, perhaps I'll put it online at some point..

**Alavaria** · October 27, 2016, 11:11 AM

Originally Posted by Jurand of Cracow

MWY/Lift/others - I have a problem understanding "tourney" buildings in EDB. For many buildings there are two sets: one for the cities, the other for the castles (eg. smith and castle_smith). How it is with jousting list? I cannot find it for a castle, yet in-game I have jousting lists in the fortresses...

You can have buildings without a castle-city lock, without any conversion between castle-city.

As you noted, the jousting list is one of them.

See:
jousting_lists requires
c_gallows requires

vs:
foundling_stables castle requires
hospital city requires

**Jurand of Cracow** · October 28, 2016, 01:57 AM

Thanks, Alavaria, I understand it now

**Jurand of Cracow** · October 30, 2016, 05:47 AM

Originally Posted by Lifthrasir

Actually, I'm not surprised. Not sure when they have been made

Lifth,
I think at least part of them were made very long time ago as I found them also in the HURB, Broken Crescent and Anatolian Principalies EDCT files. So it's not an SSHIP issue - they are inherited from the old code and should be felt also in the other mods.
For instance, I was concerned why so many my generals get the "Abhors Drink" trait. I've had a look a this trait and seeing it I suspect that the person who modified triggers for this trait simply didn't understand how the code works (well, I hope I do, but who knows... Check it).

Sobriety has 3 levels with thresholds 2, 4, 8.
The anti-trait to sobriety is Drink with 6 levels: 1, 2, 4, 8, 16, 32.

While creating the triggers you have to understand the difference between level of the trait, and a number of points gathered in the trait. For many traits there’s no difference (ie when thresholds are: 1,2,3,4…). But not here. Additionally, you've to understand that the triggers stack, so if you create "open up" triggers (the value equal or higer: >=) there may be many triggers firing (it's not equal: =).

Let’s have a look. The triggers for Sobriety fire at adoption, marriage, Coming of Age and CoA of a son (CharacterBecomesAFather).

If you look at the fatherhood triggers you conclude that they have to make a general sober – there’s so many of them and they stack, so they extremely powerful. If you get a bit of Drink points, and your son comes of age, you get inevitably sober:

;------------------------------------------
Trigger family20
WhenToTest CharacterBecomesAFather
Condition Trait Drink >= 2
Affects Sobriety 1 Chance 40
;------------------------------------------
Trigger family21
WhenToTest CharacterBecomesAFather
Condition Trait Drink >= 3
Affects Sobriety 2 Chance 30
;------------------------------------------
Trigger family22
WhenToTest CharacterBecomesAFather
Condition Trait Drink >= 4
Affects Sobriety 4 Chance 40
;------------------------------------------
Trigger family23
WhenToTest CharacterBecomesAFather
Condition Trait Drink >= 5
Affects Sobriety 8 Chance 20

Then if you look at the coming of age triggers, you also see some horrors. The author made a condition for father to be drunk for number of points of 5 or 6, while he thought it’s for levels of 5 or 6. And then he attached an extreme probability of 90%. As a result, the generals who got just past merry have an instant chance to pass way beyond Abhors Drink. This is the trigger:

;------------------------------------------
Trigger dads_totally_drunk_vnv_trigger
WhenToTest CharacterComesOfAge
Condition FatherTrait Drink >= 5
and FatherTrait Drink <= 6
Affects Sobriety 18 Chance 90
Affects Drink 1 Chance 17

So the conclusion is – the EDCT need very careful examination with understanding what do the triggers mean. And also how they interact, this is another issue which gets important with modding, submods, minimods – everybody is changing triggers for one reason, but they may have unanticipated consequences.

Code:

 
In the EDCT file: effects
 ;------------------------------------------
Trait Drink
 Characters family
 ExcludeCultures middle_eastern
 NoGoingBackLevel 5 
 AntiTraits Sobriety
 
 Level Social_Drinker
   Description Social_Drinker_desc
   EffectsDescription Social_Drinker_effects_desc
   LoseMessage Social_Drinker_lose_desc
   Threshold 1 
 
   Effect Command 1 
   Effect LocalPopularity 1 
 
 Level Gets_Merry
   Description Gets_Merry_desc
   EffectsDescription Gets_Merry_effects_desc
   Threshold 2 
 
   Effect Command 1 
 
 Level Steady_Drinker
   Description Steady_Drinker_desc
   EffectsDescription Steady_Drinker_effects_desc
   Threshold 4 
 
   Effect LocalPopularity -1
 
 Level Drunken_Heathen
   Description Drunken_Heathen_desc
   EffectsDescription Drunken_Heathen_effects_desc
   Threshold 8 
 
   Effect Command -1 
   Effect Authority -1 
   Effect LocalPopularity -1
 
 Level Alcoholic
   Description Alcoholic_desc
   EffectsDescription Alcoholic_effects_desc
   Threshold 16 
 
   Effect Command -2 
   Effect Authority -3 
   Effect LocalPopularity -2
 
 Level Paralytic
   Description Paralytic_desc
   EffectsDescription Paralytic_effects_desc
   GainMessage Paralytic_gain_desc
   Epithet Paralytic_epithet_desc
   Threshold 32 
 
   Effect Command -3 
   Effect Authority -5 
   Effect LocalPopularity -3 
 
;------------------------------------------
Trait Sobriety
 Characters family
 ExcludeCultures middle_eastern
 AntiTraits Drink
 
 Level Sensible_Drinker
   Description Sensible_Drinker_desc
   EffectsDescription Sensible_Drinker_effects_desc
   Threshold 2 
 
   Effect Command 1 
 
 Level Sober
   Description Sober_desc
   EffectsDescription Sober_effects_desc
   Threshold 4 
 
   Effect Command 1 
   Effect TroopMorale -1 
   Effect PersonalSecurity 1 
   Effect LocalPopularity -1 
 
 Level Abhors_Drink
   Description Abhors_Drink_desc
   EffectsDescription Abhors_Drink_effects_desc
   Threshold 8 
 
   Effect Command 1 
   Effect TroopMorale -2 
   Effect PersonalSecurity 2 
   Effect LocalPopularity -2
 
 
In the EDCT file: triggers for fatherhood
 
;------------------------------------------
Trigger family20
 WhenToTest CharacterBecomesAFather
 
 Condition Trait Drink >= 2
 
 Affects Sobriety 1 Chance 40 
 
;------------------------------------------
Trigger family21
 WhenToTest CharacterBecomesAFather
 
 Condition Trait Drink >= 3
 
 Affects Sobriety 2 Chance 30 
 
;------------------------------------------
Trigger family22
 WhenToTest CharacterBecomesAFather
 
 Condition Trait Drink >= 4
 
 Affects Sobriety 4 Chance 40 
 
;------------------------------------------
Trigger family23
 WhenToTest CharacterBecomesAFather
 
 Condition Trait Drink >= 5
 
 Affects Sobriety 8 Chance 20 
 
In the EDCT file: triggers for CoA
 
;------------------------------------------
Trigger dads_a_bit_drunk_vnv_trigger
 WhenToTest CharacterComesOfAge
 
 Condition FatherTrait Drink >= 1
       and FatherTrait Drink <= 2
 
 Affects Sobriety 3 Chance 33 
 Affects Drink 1 Chance 17 
 
;------------------------------------------
Trigger dads_more_drunk_vnv_trigger
 WhenToTest CharacterComesOfAge
 
 Condition FatherTrait Drink >= 3
       and FatherTrait Drink <= 4
 
 Affects Sobriety 9 Chance 17 
 Affects Drink 1 Chance 17 
 
;------------------------------------------
Trigger dads_totally_drunk_vnv_trigger
 WhenToTest CharacterComesOfAge
 
 Condition FatherTrait Drink >= 5
       and FatherTrait Drink <= 6
 
 Affects Sobriety 18 Chance 90 
 Affects Drink 1 Chance 17 
 
In the EDCT file: triggers for marriage
 
;------------------------------------------
Trigger family11
 WhenToTest CharacterMarries
 
 Condition Trait Drink >= 2
 
 Affects Sobriety 1 Chance 40 
 
;------------------------------------------
Trigger family12
 WhenToTest CharacterMarries
 
 Condition Trait Drink >= 3
 
 Affects Sobriety 2 Chance 30 
 
;------------------------------------------
Trigger family13
 WhenToTest CharacterMarries
 
 Condition Trait Drink >= 4
 
 Affects Sobriety 4 Chance 40 
 
;------------------------------------------
Trigger family14
 WhenToTest CharacterMarries
 
 Condition Trait Drink >= 5
 
 Affects Sobriety 8 Chance 20 
 
;------------------------------------------
Trigger family15
 WhenToTest CharacterMarries
 
 
 Affects Sobriety 1 Chance 5 
 Affects Prim 1 Chance 5 
 Affects Drink 1 Chance 5 
 Affects Girls 1 Chance 2 
 Affects Sane 1 Chance 10 
 
In the EDCT file: triggers for selfperpetuation
 
;------------------------------------------
Trigger selfperpetuating33
 WhenToTest CharacterTurnEnd
 
 Condition Trait Sobriety >= 1
 
 Affects Sobriety 1 Chance 4

**Lifthrasir** · October 30, 2016, 06:47 AM

I agree with you. I'm convinced that most of them were already there before SSHIP. I don't remember that we (actual team) have modified them, at least not in a major way. Unfortunately, I have no idea if Ravenant (former developer) has modified them a lot. It was before my time

Anyway, thanks again for taking time to work on these

**wafu** · November 02, 2016, 09:01 AM

CTD during turn phase.
Steam version. UAC off during installation. No submods.
Turn 1215AD, end turn and CTD "unspecified error" on Independent Nations. I followed movement through toggle_fov, no problems until Independent Nations, I don't see anything move (it stays on the previous faction, as if it was just about to tick to my turn phase) and I get crash.

13:40:27.922 [system.rpt] [always] CPU: SSE2
13:40:27.922 [system.rpt] [always] ==== system log start, build date: Sep 5 2014 version development ===
13:40:27.927 [system.io] [always] mounted pack packs/data_0.pack
13:40:27.927 [system.io] [always] mounted pack packs/data_1.pack
13:40:27.927 [system.io] [always] mounted pack packs/data_2.pack
13:40:27.927 [system.io] [always] mounted pack packs/data_3.pack
13:40:27.927 [system.io] [always] mounted pack packs/data_4.pack
13:40:27.927 [system.io] [always] mounted pack packs/localized.pack
13:40:35.671 [game.script] [always] Germanicu5 ReallyBadAI v5.7 Running. Please upload log and savegames when reporting battle CTDs for SS.
13:41:47.849 [game.script] [error] Script execution error for <siege_settlement>, at line 8775, in mods/SS6.3/data/world/maps/campaign/imperial_campaign/campaign_script.txt:
Attacker <scotland4wallace> cannot siege settlemnt <Edinburgh>.
13:42:48.763 [system.rpt] [error] Medieval 2: Total War encountered an unspecified error and will now exit.

Here's the log but don't think it's of any use.. Wallace has been a vassal for like 30 years so doubt that's related.

**Lifthrasir** · November 02, 2016, 11:01 AM

Have you implemented your config file as per this thread (last option is the best)? If not, I recommend to do it and to repost your log. Note that it will be much longer. You will need to zip it and to post it as an attachement

**wafu** · November 02, 2016, 02:00 PM

Thanks I fixed it, here's the log

Spoiler Alert, click show to read:

Here's the zipped log file

**Jurand of Cracow** · November 03, 2016, 03:37 AM

Originally Posted by Lifthrasir

I agree with you. I'm convinced that most of them were already there before SSHIP. I don't remember that we (actual team) have modified them, at least not in a major way. Unfortunately, I have no idea if Ravenant (former developer) has modified them a lot. It was before my time

Anyway, thanks again for taking time to work on these

It seems also the health traits have fallen pray to the ineptitude of a modder who didn't recegnize the difference between levels and values of the traits. The result is not as serious as it was for the soberity - the diseases are simply much less common amoung your generals as it was intended by Pnut.

You may compare two parts of the code.

Spoiler Alert, click show to read:

**j.a.luna** · November 03, 2016, 03:51 AM

So Jurand, you can fix these files also?when the new patch is released i will add all your minimods! You are doing an excellent work!

**Jurand of Cracow** · November 03, 2016, 09:41 AM

Originally Posted by j.a.luna

So Jurand, you can fix these files also?when the new patch is released i will add all your minimods! You are doing an excellent work!

Thank's mate! Sobrierty fixed for you, even if not yet fully documented and entirely thought-out. Find it here.
I will change diseases when I get my bearings in all their consequences.

Thread: Bugs Reports & Technical Help

Thread Tools

Search Thread

Display

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Re: SSHIP - Bugs Reports & Technical Help

Tags for this Thread

Posting Permissions