Settlement name change

[falcom4ever]

Hello

I am trying to add settlement name change in the campaign script.

I found this in the americas campaign as exemple

;;;;; Mexico - Tenochtitlan

    declare_counter Tenochtitlan_Spain
    
    ;;; Spain captures Tenochtitlan
    monitor_conditions I_SettlementOwner Tenochtitlan = spain
        and I_CompareCounter Tenochtitlan_Spain = 0
        
        set_counter Tenochtitlan_Spain 1
        change_settlement_name Tenochtitlan Mexico

     end_monitor

    ;;; Natives capture Tenochtitlan
    monitor_conditions not I_SettlementOwner Tenochtitlan = spain
        and not I_SettlementOwner Tenochtitlan = england
        and not I_SettlementOwner Tenochtitlan = france
        and I_CompareCounter Tenochtitlan_Spain = 1

        set_counter Tenochtitlan_Spain 0
        change_settlement_name Tenochtitlan Tenochtitlan

     end_monitor

An I wrote this, but when the factions normans take the settlement, the name doesn't change Did I mistaked ?

;;;;; Naha - Shuri

    declare_counter Shuri_Japan
    
    monitor_conditions I_SettlementOwner Tenochtitlan = normans
        and I_CompareCounter Shuri_Japan = 0
        
        set_counter Shuri_Japan 1
        change_settlement_name Shuri Naha

     end_monitor

    monitor_conditions not I_SettlementOwner Tenochtitlan = normans
        and I_CompareCounter Shuri_Japan = 1

        set_counter Shuri_Japan 0
        change_settlement_name Shuri Shuri

     end_monitor

[Gigantus]

The new settlement name needs an entry in text\expanded.txt - in the same way as it would be in text\imperial_campaign...txt
The same applies if the name gets reversed to the original one.

[falcom4ever]

I added the settlement name.

No need to add the region/province name right ?

[lolIsuck]

Why is Tenochtitlan still in the script? I don't know a lot about scripting so I could be wrong but that seems weird.
This way it says that if Tenochtitlan is Norman the name of Shuri will change to Naha, seems to make sense then that when you capture Shuri nothing will change.

[falcom4ever]

Oops

But still doesn't work :S

Here is all the script I simplified to test first how to do...

script
;;;;;;;;;;;;;;;;;;;;;;;; Name Settlements ;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;;;;; Naha - Shuri

    monitor_conditions I_SettlementOwner Shuri = normans
        change_settlement_name Shuri Naha
     end_monitor

    monitor_conditions I_SettlementOwner Shuri = ryukyu
        change_settlement_name Shuri Shuri
     end_monitor
end_script

I simply added this to expanded :

{Naha}Naha
{Shuri}Shuri

[Gigantus]

You forgot the "wait_monitors" line, second last row\line of your script.

[falcom4ever]

Thanks it works now :

script
;;;;;;;;;;;;;;;;;;;;;;;; Name Settlements ;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;;;;; Naha - Shuri

    monitor_conditions I_SettlementOwner Shuri = normans
        change_settlement_name Shuri Naha
     end_monitor

    monitor_conditions I_SettlementOwner Shuri = ryukyu
        change_settlement_name Shuri Shuri
     end_monitor

wait_monitors

end_script

But now when I take the settlement, it looks like if it was in loop. I can't do CTRL+A to select the army, as it unselect. Maybe it is because the script is too small and it renames always the settlement ?

[Aikanár]

Yep, since monitor_conditions is a real time monitor and since you've not defined an end to this, you're caught in an infinite loop
Add a counter to it like f.e.:

declare_counter shuri
monitor_conditions I_SettlementOwner Shuri = ryukyu
and I_CompareCounter shuri = 0
change_settlement_name shuri shuri
set_counter shuri 1
end_monitor

[Gigantus]

One of the reasons I avoid monitor_conditions wherever I can.

[falcom4ever]

I see thanks about that.

My first time at scripting sorry.

[Aikanár]

One of the reasons I avoid monitor_conditions wherever I can.

This!

I see thanks about that.

My first time at scripting sorry.

Welcome and no need to apologise, just enjoy modding