traits, ancillaries, and names

**iamphet** · February 11, 2009, 02:01 AM

Guys, sorry for flooding this forum with my findings but I couldn't resist because your mod looks promising and I got some spare time

I ran traits, ancillaries, and names files through a validator. It reported some errors.

1. export_descr_character_traits.txt. Triggers to add HP to HaleAndHearty generals are missing Trait keyword, here are fixed ones:

Code:

Trigger generalhpplusone
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
		  and not IsFactionLeader
		  and not IsFactionHeir
		  and not Trait HaleAndHearty >= 1
	
	Affects HaleAndHearty  1  Chance  100
	
Trigger generalhpplustwoleader
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
		  and IsFactionLeader
		  and not Trait HaleAndHearty >= 1
		  and not CultureType nomad
		  and not FactionType empire_west_rebels
		  and not FactionType sassanids
	
	Affects HaleAndHearty  2  Chance  100
	
Trigger generalhpplustwoheir
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
		  and IsFactionHeir
		  and not Trait HaleAndHearty >= 1
		  and not CultureType nomad
		  and not FactionType empire_west_rebels
		  and not FactionType sassanids
	
	Affects HaleAndHearty  2  Chance  100

Trigger generalhpplusminusexheir
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
		  and Trait Exheir = 1
	
	Affects HaleAndHearty  -2  Chance  100
	
Trigger generalhpplusoneAI
    WhenToTest CharacterTurnEnd

    Condition IsGeneral
		  and not FactionIsLocal
		  and not Trait HaleAndHearty >= 3
		  and not CultureType nomad
	
	Affects HaleAndHearty  1  Chance  100

2. export_VnVs.txt. Aigeneral hidden trait lacks its descriptions (Anyone_desc and Anyone_effects_desc)

3. export_descr_ancillaries.txt. There are few typos, perhaps inherited from BI. Corrected entries:

Code:

Ancillary carthaginian_turncoat
    Image easterner_ancillary.tga
    ExcludeCultures carthaginian
    Description carthaginian_turncoat_desc
    EffectsDescription carthaginian_turncoat_effects_desc
    Effect Combat_V_Carthaginian  1

and

Code:

Ancillary easterner_turncoat
    Image easterner_ancillary.tga
    ExcludeCultures barbarian, carthaginian, eastern, nomad, iapygian
    Description easterner_turncoat_desc
    EffectsDescription easterner_turncoat_effects_desc
    Effect Combat_V_Eastern  1

4. Some lines in descr_strat.txt were reported as erroneous because O_Marhais is described as a name in descr_names.txt rather than surname.

[ERROR] faction 'saxons' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt
[ERROR] faction 'saxons' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt
[ERROR] faction 'ostrogoths' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt
[ERROR] faction 'ostrogoths' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt
[ERROR] faction 'ostrogoths' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt
[ERROR] faction 'ostrogoths' descr_strat.txt male surname 'O_Marhais' not in descr_names.txt

5. Also the validator complained about unknown culture iapygian. Has anyone checked the triggers worked for this culture?

Fixes for issues 1-3: http://www.twcenter.net/forums/showt...26#post4445326

**Hister** · February 11, 2009, 03:24 AM

Superb findings - keep it up - very valuable!

**DaVinci** · February 12, 2009, 03:52 PM

5. Also the validator complained about unknown culture iapygian. Has anyone checked the triggers worked for this culture?

This is because the validator works on the vanilla base. If the culture is properly added to the mod then it'll work also proper.

Good to see PI got a new contributor.

**iamphet** · February 13, 2009, 02:31 AM

Thanks for the information.
BTW here are the fixes for traits and ancillaries, I did not touch descr_strat.txt: http://files.filefront.com/PI+ancill.../fileinfo.html