Lesson 4 part 2 Traits and Ancillaries

[absinthia]

Spoiler Alert, click show to read: 

Spoiler Alert, click show to read: 

;------------------------------------------
Trigger Pendragon
WhenToTest PostBattle

Condition WonBattle
and BattleSuccess >= average
and PercentageEnemyKilled < 20
and IsGeneral
and FactionType dyfneint

Affects Dragon 1 Chance 50

Spoiler Alert, click show to read: 

;------------------------------------------
Trigger cestus_dei_anc_trigger
WhenToTest GovernorBuildingCompleted
Condition IsGeneral
and SettlementBuildingFinished = cathedral

AcquireAncillary cestus_dei chance 10

[Icedie El Guaraní]

So here is my creation
Traits Hates Danelags

Spoiler Alert, click show to read: 

Ancillaries Thor hammer

Spoiler Alert, click show to read: 

Traits triggers

;------------------------------------------
Trigger dad_FearsDanelags
    WhenToTest CharacterComesOfAge

    Condition FatherTrait Fearsdanelags >= 1

    Affects Hatesdanelags  1  Chance  50

Anti-traits

;------------------------------------------
Trigger dad_hatesDanelags
    WhenToTest CharacterComesOfAge

    Condition FatherTrait Hatesdanelags >= 1

    Affects Hatesdanelags  1  Chance  50

Ancillaries Thor hammer

;------------------------------------------
Ancillary thor_hammer
    Type Relic
    Transferable  1 
    Image thor_Hammer.tga
    ExcludeCultures mesoamerican, middle_eastern
    Description thor_hammer_desc
    EffectsDescription thor_hammer_effects_desc
    Effect Authority  1 
    Effect TroopMorale  1 
    Effect Law  2

Trigger

;------------------------------------------
Trigger thor_hammer_vnv_trigger
    WhenToTest PostBattle
    Condition WasAttacker
          and IsGeneral
          and WonBattle
          and GeneralFoughtInCombat
          and PercentageEnemyKilled > 66
          and BattleOdds < 1.5
          and Trait BattleDread > 0

    AcquireAncillary thor_hammer chance  50

GED am i done with the course?

[GrnEyedDvl]

Looking good everyone. I will add names to the list.

[Hunter Makoy]

Two things i learnt from this class,

Never mod while you are tired. You may well make a mistake.

Never mod if you have had a couple of drinks you definatly will make a mistake.

yeah who would've thought sleepy drunks would make mistake in modding? :laughing:

[GrnEyedDvl]

Also I never name the ancillary the same as the trigger, append it with _trigger or something so there is no confusion.

If you are getting a crash, comment out the trigger and make sure the ancillary part works. If it does then there is something wrong with the trigger. Just a way of narrowing it down a bit.

[GrnEyedDvl]

{white_stallion_desc_effects}+25% to Movement Points (gives armies the ability to forced march)

 EffectsDescription white_stallion_effects_desc

Aha!

I didnt notice that the first time around. Sorry.

[Hunter Makoy]

oooo yeah thats a tough one to figure out. i also end up putting effect instead of effects sometimes too.

esp. when your doing a whole list of traits and everything starts to blur together.

[Alex-ander]

If you are getting a crash, comment out the trigger and make sure the ancillary part works. If it does then there is something wrong with the trigger. Just a way of narrowing it down a bit.

How do i comment out the trigger. Is it something like the REM that was used in basic.

[GrnEyedDvl]

Just use a semicolon.

; this is a comment

[Alex-ander]

edited

[absinthia]

stuff moved. delete at your own convenience.

[Alex-ander]

I have really run out of ideas with trying to add an ancillary. Nothing seems to work for me. I can add a Vanilla ancillary with no problems. It really needs somebody to look over the files. And see if i am missing something please can somebody check these files.

Here they are
export_dscr_ancillaries
Attachment 26150

export ancillaries.txt
Attachment 26152

export_dscr_ancilaries_emums
Attachment 26153

The log file
Attachment 26154

The log file does show a script error but i have not idea if that is relevant to my problem. Really as i said i have run out of ideas to get this working. I am beginning to think my mod is faulty maybe i made a typo somewhere that was not enough to stop the mod working but makes it crash if i try anything else. I am open to suggestions.

[Alex-ander]

I have decided to slash and burn. I think either my game or mod have become corrupt so i will reinstall the game and redo the mod folders. I presume i dont need to redo all the lessons as i have already done them.

I just need to get the ancillary and trait bit done

Is their a way to get the game animations to appear in our mod. I thought i saw somthing here but i cant find it now.

[Nevada]

sry, I couldn't answer your PM, I jsut found the time to look through it, but i didn't find anything.

Before you redo everything (if you haven't started already):
I can give you my working files and you can use them to test if it's your modfolder.
If it doesn't work, it must be your modfolder...

[Alex-ander]

Thanks Nevada i sorted it it out. It must have been that my game/mod folder was corrupted. I redid it and the script that was causing a CTD every time worked first time and my ancillary appears so the trigger works. Now to get to grips with traits :hmmm:

It was good practice redoing the mod and what took me weeks and many crashes i did in a few hours with only one CTD which was easy to sort out.

A question about traits and all other scripts really if you look in the vinalla files everything is neat with blank lines between the lines of a script or at the end of a script. Do you need to maintain the same format or do the blank lines not matter.

[Nevada]

i don't think you have to keep the layout, but I think it helps you to keep the overview over the stuff you add.

[Alex-ander]

edited

[Hunter Makoy]

yes i always try to keep the same order as far as lines above and below, how far things are indented, and whether it uses tabs or spaces. i think that in many cases it doesn't matter, but sometimes it makes a huge difference. take for example the family trees, if its not done with tabs and spaces in the correct order and number, it will crash. so as i general rule of thumb i try to keep things the same. however, if you look at the traits files for other mods, sometimes they use a slightly different indent style, and it seems to work fine.

if you've managed to get ancs to work, the traits shouldn't be a problem for you. your following the same basic system, except there is no .tga file, and you have thresholds and levels.

[musicdemon]

I'm getting a CTD after the splash screen after I completed the code for my ancillary. Here's the relevant sentence in the log:

"15:16:10.484 [script.err] [error] Script Error in mods/ModBasics/data/export_descr_ancillaries.txt, at line 11, column 5
expecting category"

I checked that part of the log and on the web, but I haven't been able to find out what that means, exactly. Here are pictures of the code for my ancillary and its trigger:

Spoiler Alert, click show to read: 

The ancillary image is only temporary

I used screenshots with the M2TW formatting to make it easier to debug I know that mostly everybody who will finish this class has finished, but please help me anyway!

[Hunter Makoy]

it says it was looking for it in line 11, which doesn't make much since because thats where the transfer is, not the type. i dont have the vanilla texts infront of me so i can't really double check against anything. i think you have it in the right order, but maybe there should be a blank line there.